Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Purity Musyoki
On Mon, Mar 9, 2015 at 4:05 PM, Tommi Saviranta w...@iki.fi wrote: On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that there is some sample code of what has been done so far regarding the [native] bluetooth idea. I have gone through the source

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Lubomir I. Ivanov
On 9 March 2015 at 15:36, Jef Driesen j...@libdivecomputer.org wrote: On 2015-03-09 14:05, Tommi Saviranta wrote: On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that there is some sample code of what has been done so far regarding the [native]

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Jef Driesen
On 2015-03-09 14:05, Tommi Saviranta wrote: On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that there is some sample code of what has been done so far regarding the [native] bluetooth idea. I have gone through the source code for the Subsurface

GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Purity Musyoki
Hi, I am a potential Google Summer of Code student, interested in working on the native bluetooth support idea. I have some experience in working with the bluetooth stack and BTLE. In the ideas page, it is noted that there is some sample code of what has been done so far regarding the bluetooth

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Tommi Saviranta
On Mon, Mar 09, 2015 at 15:18:59 +0200, Benjamin wrote: Could you perhaps elaborate on your statement that Subsurface needs some persuasion to work with the Petrel? In short, when I select Shearwater/Petrel, I cannot (intuitively) enter the device address until I try and fail to download the

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Lubomir I. Ivanov
On 9 March 2015 at 15:21, Purity Musyoki purity.sy...@gmail.com wrote: Hi On Mon, Mar 9, 2015 at 4:12 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: i haven't seen any patches reach the mailing list; this could be located in a separate branch which i'm not aware of. perhaps someone

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Purity Musyoki
On Mon, Mar 9, 2015 at 4:27 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: just saw that, still wondering what the GSoC idea implies. If I understand it well, it means that currently Subsurface connects to bluetooth computers using serial emulation, and the need of the GSoC idea is to

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Benjamin
Could you perhaps elaborate on your statement that Subsurface needs some persuasion to work with the Petrel? On 9 Mar 2015 15:05, Tommi Saviranta w...@iki.fi wrote: On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that there is some sample code of

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Tommi Saviranta
On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that there is some sample code of what has been done so far regarding the [native] bluetooth idea. I have gone through the source code for the Subsurface project, but I am unable to find the bluetooth

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Dirk Hohndel
On Mar 9, 2015, at 7:10 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 9 March 2015 at 15:36, Jef Driesen j...@libdivecomputer.org wrote: On 2015-03-09 14:05, Tommi Saviranta wrote: On Mon, Mar 09, 2015 at 15:33:24 +0300, Purity Musyoki wrote: In the ideas page, it is noted that

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 07:49:47AM +0200, Yosef Hamza wrote: Those 2 patches are actually one, But I think that the second patch needs some discussion. As Robert already mentioned, the second patch (0003) is simply wrong. That code was there for a reason :-) I think it's better this way

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Purity Musyoki
On Mon, Mar 9, 2015 at 5:44 PM, Dirk Hohndel d...@hohndel.org wrote: I am perfectly happy to have a Linux and Windows implementation the first time around (that’s 80+% of our users). I know that Nick has Mac Bluetooth code and he mentioned that he could be talked into donating that to

Re: GSoC Project: Native Bluetooth support for Linux and/or Windows

2015-03-09 Thread Jef Driesen
On 2015-03-09 14:12, Lubomir I. Ivanov wrote: i'm not very familiar with this GSoC idea and bluetooth in general. Subsurface and the underlying libdivecomputer today use the rfcomm emulation to communicate with Bluetooth enabled dive computers. We should use native Bluetooth instead

Re: [PATCH 1/2] Ticket #837 Fix

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 07:45:31AM +0200, Yosef Hamza wrote: The fix is according to the comment on the ticket. - your patch was attached as base64 encoded attachment. Nothing horribly wrong with that, but it's inconvenient as it makes it hard to comment on the code in a response. - changing

Re: Regarding understanding code

2015-03-09 Thread Tomaz Canabrava
On Sat, Mar 7, 2015 at 7:13 AM, Anton Lundin gla...@acc.umu.se wrote: On 06 March, 2015 - Raghu Ram Vadapalli wrote: Can you please tell me where the code for the styles such as scroll bars is located. We don't use styles, so they aren't located in the code.

Re: Galileo Sol dive log decoding.

2015-03-09 Thread Willem Ferguson
On 09/03/2015 17:19, Jef Driesen wrote: On 2015-03-09 14:24, Willem Ferguson wrote: I am currently working with dive logs of the Galileo. I am looking at the events during the dive. Are you talking about direct downloading from the dive computer, or importing from the Uwatec application? I

Re: [PATCH 1/2] Ticket #837 Fix

2015-03-09 Thread Yosef Hamza
If the user hasn't made any changes and now it displays Add location close. Is there anything special that should happen when the choose Add location? If now why it has to change when the user make changes, we can keep Add location instead of Save and close? Let me know what you think. §Yousef

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Davide DB
Il 09/mar/2015 18:36 Dirk Hohndel d...@hohndel.org ha scritto: That's a strange edge case. Here are some assumptions that we tend to make a) most people get the data into Subsurface via a download from their dive computer (or, initially, importing from other software). b) if there are errors

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Henrik Brautaset Aronsen
On 09 Mar 2015, at 19:24, Davide DB dbdav...@gmail.com wrote: Il 09/mar/2015 18:36 Dirk Hohndel d...@hohndel.org ha scritto: So basically it seems rather unlikely that the user really has the wrong order of tanks and needs to switch to a different tank. Dirk, does this means that

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Yosef Hamza
About patch -0002- The thing is timeAxis-valueAt(scenePos) can return a negative value if the cursor was pointing to the negative part of the axis to the left, which is the case here. The unsigned assigning happens at the very end of assigning series when assigned finally to duration_t of event

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 06:48:52PM +0200, Yosef Hamza wrote: About patch -0002- The thing is timeAxis-valueAt(scenePos) can return a negative value if the cursor was pointing to the negative part of the axis to the left, which is the case here. The unsigned assigning happens at the very

Fix #795

2015-03-09 Thread Joakim Bygdell
0001-Fixes-795.patch Description: Binary data /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

GSOC 2015 proposal

2015-03-09 Thread Yash Kumar
Hello, I am a college student who has an idea for android app. I will get straight to my app. I propose an idea of bus tracking using the GPS receiver in our smartphones. We can simply use google maps to pin point the location of that particular bus the user wants. So, I am thinking of proposing

Re: some patches regarding the location edit.

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 04:01:12PM -0300, Tomaz Canabrava wrote: From 7e89b79afbefd508015841a667cc68a73865754b Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tomaz.canabr...@intel.com Date: Mon, 9 Mar 2015 15:12:48 -0300 Subject: [PATCH 3/6] Remove redundant code Another bit of piece of

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 07:26:05PM +0100, Henrik Brautaset Aronsen wrote: On 09 Mar 2015, at 19:24, Davide DB dbdav...@gmail.com wrote: Il 09/mar/2015 18:36 Dirk Hohndel d...@hohndel.org ha scritto: So basically it seems rather unlikely that the user really has the wrong order of tanks

Re: [PATCH 1/2] Ticket #837 Fix

2015-03-09 Thread Dirk Hohndel
Yosef, please try to figure out how to answer inline. This is a technical mailing list where top posting is considered quite annoying. The occasional email from a phone may be acceptable, but in general we expect people to use in line responses... On Mon, Mar 09, 2015 at 07:01:09PM +0200, Yosef

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Dirk Hohndel
On Mon, Mar 09, 2015 at 07:24:15PM +0100, Davide DB wrote: Il 09/mar/2015 18:36 Dirk Hohndel d...@hohndel.org ha scritto: That's a strange edge case. Here are some assumptions that we tend to make a) most people get the data into Subsurface via a download from their dive computer (or,

Re: Customizable Print Formats GSoC 2015

2015-03-09 Thread Long, Martin
I've only really scanned this thread, so please excuse me if I'm raising something that's already been covered. It seems we're talking about rendering using HTML along with a few other things. Have we considered pagination? I know this is something that HTML isn't great at. You can, of course,

Re: Customizable Print Formats GSoC 2015

2015-03-09 Thread Gehad Elrobey
On Tue, Mar 10, 2015 at 1:20 AM, Long, Martin mar...@longhome.co.uk wrote: I've only really scanned this thread, so please excuse me if I'm raising something that's already been covered. It seems we're talking about rendering using HTML along with a few other things. Have we considered

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Yosef Hamza
On Tue, Mar 10, 2015 at 1:18 AM, Dirk Hohndel d...@hohndel.org wrote: @@ -1392,6 +1395,23 @@ void ProfileWidget2::changeGas() qDebug() failed to parse tank number; tank = get_gasidx(displayed_dive, gasmix); } + + struct event **events =

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Yosef Hamza
Here's the proposed change by Robert fixes the problem for all. It doesn't show the gas change icon @0:00, But you can still change gases @0:00. §Yousef On Mon, Mar 9, 2015 at 10:42 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, Mar 09, 2015 at 07:26:05PM +0100, Henrik Brautaset Aronsen

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 12:52:16AM +0200, Yosef Hamza wrote: Here's the proposed change by Robert fixes the problem for all. Well, it may fix one problem, but using that patch would create a lot of others... This whole two patch rule is about making sure you understand how to submit changes and

Re: [PATCH 1/2] Ticket #837 Fix

2015-03-09 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 01:08:19AM +0200, Yosef Hamza wrote: Is there anything special that should happen when the choose Add location? As I said, that exceeds the easy fix part of this. Yes, we should add the code that allows people to create a new location. But that's a bit more

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-09 Thread Davide DB
On Mon, Mar 9, 2015 at 9:42 PM, Dirk Hohndel d...@hohndel.org wrote: If this is actually a show stopper for you guys, then I'll try to get in a hack so you can use the software, but a real solution will likely take a little longer. No problem at all, I can live with them. In the last few

Re: [PATCH 1/2] Ticket #837 Fix

2015-03-09 Thread Yosef Hamza
On Mon, Mar 9, 2015 at 9:05 PM, Dirk Hohndel d...@hohndel.org wrote: Yosef, please try to figure out how to answer inline. This is a technical mailing list where top posting is considered quite annoying. The occasional email from a phone may be acceptable, but in general we expect people to

[PATCH 2/2] HTML: Report start cylinder pressure correctly.

2015-03-09 Thread Gehad Elrobey
Fix start pressure cylinder values. -- regards, Gehad From 8a211da68dabdbccb856f60b68d96558d81d Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Tue, 10 Mar 2015 02:05:28 +0200 Subject: [PATCH 2/2] HTML: Report start cylinder pressure correctly. Report start

[PATCH v2] Fix building with NO_PRINTING for Android

2015-03-09 Thread Anton Lundin
Back in 4867ee8ad87399f34a399f30def700b2fc045309 (Move the Profile out of the mainwindow.ui) the way to access the PlannerDetails object changed. This does the corresponding change to the NO_PRINTING block, making it build on Android again. Signed-off-by: Anton Lundin gla...@acc.umu.se ---

Re: Off Topic -- slightly. Dive Computers

2015-03-09 Thread Anton Lundin
On 07 March, 2015 - Steve Butler wrote: On 03/07/2015 03:36 AM, Anton Lundin wrote: ... It got great readability and i love how compact it is. I also like the mecanical push-buttons better than the piezoelectric ones in the OSTC2 and predator/petrel. It doesn't do air-integration. It would