Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Dirk Hohndel
> On Jun 15, 2015, at 4:21 PM, Miika Turkia wrote: >> I know that Tomaz has a ton of stuff implemented. I'm waiting for him to >> send patches so we can get a much more functional version into master. And I am still waiting for just that. Not much I can do -- the downside of an open source proje

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Miika Turkia
> On 15 Jun 2015, at 21:32, Dirk Hohndel wrote: > >> On Mon, Jun 15, 2015 at 03:27:01PM +0200, Davide DB wrote: >>> On Mon, Jun 15, 2015 at 3:20 PM, Dirk Hohndel wrote: >>> > I had three dives for the same location name and GPS. They were merged correctly but for every die it added

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Claudiu Olteanu
> > So we agree that this is a reasonable way to do things. > > And then on the Subsurface side we use QtBluetooth plus a Windows specific > Bluetooth implementation. > > Correct? > Yes. The Windows specific Bluetooth implementation could be either on Subsurface side or on libdivecomputer side. It

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Thiago Macieira
On Monday 15 June 2015 12:30:07 Dirk Hohndel wrote: > And then on the Subsurface side we use QtBluetooth plus a Windows specific > Bluetooth implementation. Until QtBluetooth offers Windows support, at which point we could drop our own code. -- Thiago Macieira - thiago (AT) macieira.info - thiag

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 10:03:32PM +0300, Claudiu Olteanu wrote: > > > > The reason we explored QtBluetooth was that I was told that in Qt5.5 it > > was going to support all our platforms. It appears that this was wrong an > > it supports all except for Windows :-( > > Well, no.. Sorry to disappoi

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Claudiu Olteanu
> > The reason we explored QtBluetooth was that I was told that in Qt5.5 it > was going to support all our platforms. It appears that this was wrong an > it supports all except for Windows :-( > Well, no.. Sorry to disappoint you. For Qt 5.5 it is planned to offer support for iOS and OS X and a st

Re: Current subsurface issues..

2015-06-15 Thread Linus Torvalds
On Sun, Jun 14, 2015 at 9:22 PM, Jef Driesen wrote: > > You're looking for DC_SAMPLE_RBT. This name has its roots in the Uwatec > devices and means "Remaining Bottom Time". The Uwatec manual describes it as > follows: Ok. Is the argument in minutes? The EON Steel seems to give seconds remaining..

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 09:20:44PM +0300, Claudiu Olteanu wrote: > > > > > > > > Given the lack of Bt support on Windows when just using bluez I wonder if > > there is value in Anton's idea to modify libdivecomputer to use a callback > > to open a serial connection and then have Subsurface (or othe

Re: Renumber GUI bug (was Re: EON Steel parsing fixups)

2015-06-15 Thread Thiago Macieira
On Monday 15 June 2015 10:01:47 Tomaz Canabrava wrote: > QMaps are not ordered, so the factor could be just 'luck' Yes they are. QMaps are sorted based on the key type's operator<. Insertion and searching is therefore O(log n) (binary search). If you don't need the order, the best way is to use

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Thiago Macieira
On Monday 15 June 2015 06:13:54 Dirk Hohndel wrote: > On Mon, Jun 15, 2015 at 03:01:44PM +0200, Jef Driesen wrote: > > I did already think about this :-) See [1] for some more background info. > > > > In a nutshell, the serial layer will be changed from a concrete > > implementation into an abstra

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Claudiu Olteanu
> > > > Given the lack of Bt support on Windows when just using bluez I wonder if > there is value in Anton's idea to modify libdivecomputer to use a callback > to open a serial connection and then have Subsurface (or other consumers > of libdivecomputer) provide that serial stream back to libdivec

Dive Planner

2015-06-15 Thread Rick Walsh
I am testing the planner on the latest git (v4.4.2-740-gb144518a85f1). The profile appears to be calculated correctly, but the table output is giving a misleading gas switching depth when the 'display transitions in deco' option is not selected. Using EAN80, the switch should be at the 9 m stop,

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 03:27:01PM +0200, Davide DB wrote: > On Mon, Jun 15, 2015 at 3:20 PM, Dirk Hohndel wrote: > > > > Yes, please. I'd really appreciate this. Subsurface should have created a > > V2 backup file when you did the conversion. > > I'm full of logbook files on my box. > Unfortunat

Re: Marble strange behaviours

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 10:25:01AM -0300, Tomaz Canabrava wrote: > On Mon, Jun 15, 2015 at 10:23 AM, Dirk Hohndel wrote: > > > On Mon, Jun 15, 2015 at 10:20:59AM -0300, Tomaz Canabrava wrote: > > > > > > > > > > http://trac.subsurface-divelog.org/ticket/779 > > > > > > > > > > It seems like there

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Davide DB
On Mon, Jun 15, 2015 at 3:20 PM, Dirk Hohndel wrote: > > Yes, please. I'd really appreciate this. Subsurface should have created a > V2 backup file when you did the conversion. I'm full of logbook files on my box. Unfortunately, in a moment of euphoria, I added my last ten dives only to V3 logb

Re: Marble strange behaviours

2015-06-15 Thread Tomaz Canabrava
On Mon, Jun 15, 2015 at 10:23 AM, Dirk Hohndel wrote: > On Mon, Jun 15, 2015 at 10:20:59AM -0300, Tomaz Canabrava wrote: > > > > > > > > http://trac.subsurface-divelog.org/ticket/779 > > > > > > > > It seems like there is still some use case not covered. > > > > > > Yes, both Tomaz and I have bee

Re: Marble strange behaviours

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 10:20:59AM -0300, Tomaz Canabrava wrote: > > > > > > http://trac.subsurface-divelog.org/ticket/779 > > > > > > It seems like there is still some use case not covered. > > > > Yes, both Tomaz and I have been banging our heads against the zoom bug. It > > seems so easy and str

Re: Marble strange behaviours

2015-06-15 Thread Tomaz Canabrava
> > > > http://trac.subsurface-divelog.org/ticket/779 > > > > It seems like there is still some use case not covered. > > Yes, both Tomaz and I have been banging our heads against the zoom bug. It > seems so easy and straight forward when I think about it, but somehow the > implementation is entire

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 03:10:36PM +0200, Davide DB wrote: > On Mon, Jun 15, 2015 at 3:04 PM, Dirk Hohndel wrote: > > > > That's not what I think is the RIGHT behavior and I thought I fixed that. > > At first that's what I implemented then after the discussions here I came > > to the conclusion th

Re: Marble strange behaviours

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 02:55:01PM +0200, Davide DB wrote: > I filed a ticket on this: > > http://trac.subsurface-divelog.org/ticket/882 > > Daily 4.4.2.740 on Windows (multiscreen computer) > > Jumping from a dive to another over and over, Marble map misses the > location mark. That's interest

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 03:01:44PM +0200, Jef Driesen wrote: > > I did already think about this :-) See [1] for some more background info. > > In a nutshell, the serial layer will be changed from a concrete > implementation into an abstract interface. This will allow us to have > multiple impleme

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 12:19:32PM +0300, Claudiu Olteanu wrote: > Ok. In the beginning I will try to implement the downloading > entirely in Subsurface and re-implement the dive computer > protocol for HW OSTC family. > > To be honest I believe that a better idea would be to > continue the work y

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Davide DB
On Mon, Jun 15, 2015 at 3:04 PM, Dirk Hohndel wrote: > > That's not what I think is the RIGHT behavior and I thought I fixed that. > At first that's what I implemented then after the discussions here I came > to the conclusion that we should ONLY turn multiple locations into the > same dive site i

Re: Renumber GUI bug (was Re: EON Steel parsing fixups)

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 10:01:47AM -0300, Tomaz Canabrava wrote: > On Mon, Jun 15, 2015 at 9:53 AM, Dirk Hohndel wrote: > > > On Sun, Jun 14, 2015 at 08:59:22PM -1000, Linus Torvalds wrote: > > > On Sun, Jun 14, 2015 at 7:21 PM, Dirk Hohndel wrote: > > > > > > > > Umm, Subsurface doesn't build w

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Dirk Hohndel
On Mon, Jun 15, 2015 at 12:16:02PM +0200, Davide DB wrote: > My V2 xml file had these dives: > > Isola di Giannutri - Nasim > II > Isola di Giannutri - Le macchine > del Nasim > Isola di Giannutri - Le macchine > del Nasim > Isola di Giannutri - Le macchine > del Nasim > Isola di Giannutri - Le ma

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Jef Driesen
On 2015-06-15 13:46, Anton Lundin wrote: On 15 June, 2015 - Claudiu Olteanu wrote: Ok. In the beginning I will try to implement the downloading entirely in Subsurface and re-implement the dive computer protocol for HW OSTC family. I think this is a bad path. I would rather suggest something

Re: Renumber GUI bug (was Re: EON Steel parsing fixups)

2015-06-15 Thread Tomaz Canabrava
On Mon, Jun 15, 2015 at 9:53 AM, Dirk Hohndel wrote: > On Sun, Jun 14, 2015 at 08:59:22PM -1000, Linus Torvalds wrote: > > On Sun, Jun 14, 2015 at 7:21 PM, Dirk Hohndel wrote: > > > > > > Umm, Subsurface doesn't build with Qt4 anymore. > > > So what's the qt5-devel version you have? > > > > Uhhu

Marble strange behaviours

2015-06-15 Thread Davide DB
I filed a ticket on this: http://trac.subsurface-divelog.org/ticket/882 Daily 4.4.2.740 on Windows (multiscreen computer) Jumping from a dive to another over and over, Marble map misses the location mark. It happens more frequently if you pan or zoom the map between jumping through dives. A vide

Re: Renumber GUI bug (was Re: EON Steel parsing fixups)

2015-06-15 Thread Dirk Hohndel
On Sun, Jun 14, 2015 at 08:59:22PM -1000, Linus Torvalds wrote: > On Sun, Jun 14, 2015 at 7:21 PM, Dirk Hohndel wrote: > > > > Umm, Subsurface doesn't build with Qt4 anymore. > > So what's the qt5-devel version you have? > > Uhhuh. > > It's qt5-qtbase-devel-5.4.2-2.fc22.x86_64 That I find inter

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Anton Lundin
On 15 June, 2015 - Claudiu Olteanu wrote: > Ok. In the beginning I will try to implement the downloading > entirely in Subsurface and re-implement the dive computer > protocol for HW OSTC family. > I think this is a bad path. I would rather suggest something like implementing a "serial" backend

Re: Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

2015-06-15 Thread Davide DB
My V2 xml file had these dives: Isola di Giannutri - Nasim II Isola di Giannutri - Le macchine del Nasim Isola di Giannutri - Le macchine del Nasim Isola di Giannutri - Le macchine del Nasim Isola di Giannutri - Le macchine del Nasim GPS data are the same because it's the same entry point but dif

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Claudiu Olteanu
Ok. In the beginning I will try to implement the downloading entirely in Subsurface and re-implement the dive computer protocol for HW OSTC family. To be honest I believe that a better idea would be to continue the work you started and to use directly the BlueZ stack instead of Qt Bluetooth API. I

Re: [PATCH] Reproducable hang when using "edit dive in planner" on non-planned dive

2015-06-15 Thread Jan Darowski
ok. 2015-06-15 6:24 GMT+02:00 Dirk Hohndel : > On Mon, Jun 15, 2015 at 12:25:43AM +0200, Jan Darowski wrote: >> First problem from the "daily build of subsurface hangs (reproducable >> for me)" thread solved: >> in planner.c unsigned int stoplevels were compared with int depth. > > Thanks for trac

Re: [GSoC] Week 3 (Native Bluetooth support)

2015-06-15 Thread Jef Driesen
On 2015-06-14 23:43, Claudiu Olteanu wrote: Thanks for your suggestions, Jef! I can definitely do that but I was looking for a solution which doesn't imply changes on *libdivecomputer* project. An ideal solution which is implemented on *Subsurface* project and doesn't need to re-implement the di

Re: Current subsurface issues..

2015-06-15 Thread Jef Driesen
On 2015-06-15 06:58, Linus Torvalds wrote: On Sun, Jun 14, 2015 at 3:24 PM, Linus Torvalds wrote: Our handling of "air time remaining" events is pretty nasty. This is not new, but I noticed just because I added support for it to the EON steel backend now that the v1.1.15 release has airtime su

Re: GSoC Status - Week 3 (VPM-B)

2015-06-15 Thread Henrik Brautaset Aronsen
On Sun, Jun 14, 2015 at 11:14 PM, Jan Darowski wrote: > Plans: > I think the worst part is behind me, We have two weeks before the > midterm evaluation and I believe that the algorithm will be working > fine to this time. > Great news! Looking forward to check it out. Henrik _