Re: Linking error with recent libdc

[2015-07-07 20:35:14 -1000] Gaetan Bisson: > [2015-07-07 20:21:49 -1000] Gaetan Bisson: > > Building subsurface master against that still fails for me. > > So things work as expected if I compile libdc without build flags. > > Our build system uses: > > CPPFLAGS="-D_FORTIFY_SOURCE=2" > CFLAGS="-

Re: Linking error with recent libdc

[2015-07-08 08:40:04 +0200] Jef Driesen: > On 2015-07-08 07:13, Gaetan Bisson wrote: > >[2015-07-07 21:45:49 -0700] Dirk Hohndel: > >>On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: > >>> Linking CXX executable subsurface > >>> libsubsurface_corelib.a(libdivecomputer.c.o): In functio

Re: Linking error with recent libdc

On 2015-07-08 07:13, Gaetan Bisson wrote: [2015-07-07 21:45:49 -0700] Dirk Hohndel: On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: > Linking CXX executable subsurface > libsubsurface_corelib.a(libdivecomputer.c.o): In function `do_libdivecomputer_import': > /build/subsurface-git

Re: Linking error with recent libdc

[2015-07-07 20:21:49 -1000] Gaetan Bisson: > Building subsurface master against that still fails for me. So things work as expected if I compile libdc without build flags. Our build system uses: CPPFLAGS="-D_FORTIFY_SOURCE=2" CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-stron

[PATCH] move notes options

Rick, does this fit better on your screen? 0001-Planner-move-notes-options-under-gas-options.patch Description: Binary data /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listi

Re: Linking error with recent libdc

On Tue, Jul 07, 2015 at 09:45:49PM -0700, Dirk Hohndel wrote: > > I just force pushed a new libdc/Subsurface-testing that updates to Jef's > latest master. Jef has merged almost all of Linus' EON Steele code - > basically just the string field related changes are left in our branch, > and of cours

Re: Linking error with recent libdc

On Tue, Jul 07, 2015 at 07:13:53PM -1000, Gaetan Bisson wrote: > [2015-07-07 21:45:49 -0700] Dirk Hohndel: > > On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: > > > Linking CXX executable subsurface > > > libsubsurface_corelib.a(libdivecomputer.c.o): In function > > > `do_libdivecom

Re: [PATCH] small changes to the planner.

> On 07 Jul 2015, at 23:46, Rick Walsh wrote: > > Hi, > > > Thank you. > > > > Silly question, what was the forth patch in the series (since they are > > > numbered x/4)? :-) > > > > The fourth was an idea to spell Bühlmann correctly, > > Ha. I got flamed big time when I (as a German) opted

Re: Linking error with recent libdc

[2015-07-07 21:45:49 -0700] Dirk Hohndel: > On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: > > Linking CXX executable subsurface > > libsubsurface_corelib.a(libdivecomputer.c.o): In function > > `do_libdivecomputer_import': > > /build/subsurface-git/src/subsurface/libdivecomputer.c

Re: [PATCH] update disclaimer.

> On 07 Jul 2015, at 22:51, Dirk Hohndel wrote: > > On Tue, Jul 07, 2015 at 10:18:41PM +0200, Joakim Bygdell wrote: >> Now the way it should have been the first time. > > Umm, I was just about to thank you and then I saw this... > > } > else { > > AHH - my eyes

Re: Linking error with recent libdc

On Tue, Jul 07, 2015 at 05:59:00PM -1000, Gaetan Bisson wrote: > Hi, > > I'm getting errors when compiling a recent subsurface (git snapshot > fe8605e) against a recent subsurface-libdc (git snapshot c164cfb, > Subsutface-testing banch). Basically all goes well and then: > > [100%] Building CXX o

Linking error with recent libdc

Hi, I'm getting errors when compiling a recent subsurface (git snapshot fe8605e) against a recent subsurface-libdc (git snapshot c164cfb, Subsutface-testing banch). Basically all goes well and then: [100%] Building CXX object CMakeFiles/subsurface.dir/subsurface_automoc.cpp.o Linking CXX executab

Re: [PATCH] small changes to the planner.

Hi, On 8 July 2015 at 02:12, Dirk Hohndel wrote: > On Tue, Jul 07, 2015 at 05:20:22PM +0200, Joakim Bygdell wrote: > > > Didn't manage to quote the patch for some reason... anyway, any chance > we > > > could have the disclaimer message once and use a parameter to insert > the > > > algorithm? T

Re: [GSoC] Week 6 (Native Bluetooth support)

On Mon, Jul 06, 2015 at 10:17:12PM -0700, Dirk Hohndel wrote: > My guess is that this is because I'm in a VM. Once I figure out the Ubuntu > situation I'll use a different computer that is running Ubuntu directly. I > don't consider being able to run inside a VM critical... And I was able to verif

Re: [PATCH] update disclaimer.

On Tue, Jul 07, 2015 at 10:18:41PM +0200, Joakim Bygdell wrote: > Now the way it should have been the first time. Umm, I was just about to thank you and then I saw this... } else { AHH - my eyes... they are bleeding!!! /D _

[PATCH] update disclaimer.

Now the way it should have been the first time. 0001-Planner-update-disclamer.patch Description: Binary data /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurfac

Re: [PULL REQUEST] VPM-B Attempt 2.

No problem, but before that I want to check one place I suspect can be wrong... 2015-07-07 21:33 GMT+02:00 Dirk Hohndel : > On Tue, Jul 07, 2015 at 09:29:19PM +0200, Jan Darowski wrote: >> I think I will check all the units once again. But it's true that it's >> another mistake on the deepocean.ne

Re: [PULL REQUEST] VPM-B Attempt 2.

On Tue, Jul 07, 2015 at 09:29:19PM +0200, Jan Darowski wrote: > I think I will check all the units once again. But it's true that it's > another mistake on the deepocean.net > The real values are 0.257 N/m and 0.0179 N/m (paper by Baker confirms) > but these constants are always (that's what I will

Re: [PATCH] Fix tab stop order in planner

On Tue, Jul 07, 2015 at 12:28:00PM -0700, Dirk Hohndel wrote: > Jocke get's today's award for "most responsive contributor"... And I get today's award for lack of English grammar :-) :facepalm: /D ___ subsurface mailing list subsurface@subsurface-divel

Re: [PULL REQUEST] VPM-B Attempt 2.

I think I will check all the units once again. But it's true that it's another mistake on the deepocean.net The real values are 0.257 N/m and 0.0179 N/m (paper by Baker confirms) but these constants are always (that's what I will check again) in the context like: pressure + skin_compression / radiu

Re: [PATCH] Fix tab stop order in planner

Jocke get's today's award for "most responsive contributor"... (and he catapulted himself into the list of the top dozen contributors to Subsurface 4.5) /D On Tue, Jul 07, 2015 at 09:12:33PM +0200, Joakim Bygdell wrote: > > > On 07 Jul 2015, at 20:55, Dirk Hohndel wrote: > > > > I do notice t

[PATCH] Fix tab stop order in planner

On 07 Jul 2015, at 20:55, Dirk Hohndel wrote:I do notice that the tab order on that screen is completely psychodelic -not necessarily caused by you, but something that will need to beaddressed at some point :)/D 0001-Planner-fix-tab-stop-order.patch Description: Binary data /Jo

Re: [PATCH] small changes to the planner.

On Tue, Jul 07, 2015 at 08:32:38PM +0200, Joakim Bygdell wrote: > > > On 07 Jul 2015, at 18:12, Dirk Hohndel wrote: > > > 0002, rearranged the GUI to make it visibly easier to see which settings > that belong together. > 0003, disables GF fields when VPM-B is the selected deco mo

Re: [PATCH] small changes to the planner.

> On 07 Jul 2015, at 18:12, Dirk Hohndel wrote: > 0002, rearranged the GUI to make it visibly easier to see which settings that belong together. 0003, disables GF fields when VPM-B is the selected deco model. >>> >>> Those both seem like great additions. Thank you. What I'm wond

Re: [PATCH] Clean double free in copy_dive_site()

2015-07-07 19:39 GMT+02:00 Dirk Hohndel : > On Tue, Jul 07, 2015 at 07:35:26PM +0200, Salvador Cuñat wrote: > > This makes subsurface crash by simply clicking a dive in the list. > > I didn't get that crash (which is surprising, looking at the code), I think the free_taxonomy() call works only i

Re: [PATCH] Clean double free in copy_dive_site()

On Tue, Jul 07, 2015 at 07:35:26PM +0200, Salvador Cuñat wrote: > This makes subsurface crash by simply clicking a dive in the list. I didn't get that crash (which is surprising, looking at the code), but you are right, good catch. The pointer is freed in the free_taxonomy() call already. /D > S

[PATCH] Clean double free in copy_dive_site()

This makes subsurface crash by simply clicking a dive in the list. Signed-off-by: Salvador Cuñat --- divesite.c | 1 - 1 file changed, 1 deletion(-) diff --git a/divesite.c b/divesite.c index 5abab76..5c96bb2 100644 --- a/divesite.c +++ b/divesite.c @@ -171,7 +171,6 @@ void copy_dive_site(struc

Re: [PATCH] small changes to the planner.

On Tue, Jul 07, 2015 at 05:20:22PM +0200, Joakim Bygdell wrote: > > Didn't manage to quote the patch for some reason... anyway, any chance we > > could have the disclaimer message once and use a parameter to insert the > > algorithm? That way the translators only need to do it once as well. > > >

Re: [PATCH] small changes to the planner.

> On 07 Jul 2015, at 17:10, Dirk Hohndel wrote: > > Hi Jocke, > > On Tue, Jul 07, 2015 at 04:41:55PM +0200, Joakim Bygdell wrote: >> 0001, updates the disclaimer to reflect the deco model that where used to >> generate the plan. > > Didn't manage to quote the patch for some reason... anyway,

Re: [PATCH] small changes to the planner.

Hi Jocke, On Tue, Jul 07, 2015 at 04:41:55PM +0200, Joakim Bygdell wrote: > 0001, updates the disclaimer to reflect the deco model that where used to > generate the plan. Didn't manage to quote the patch for some reason... anyway, any chance we could have the disclaimer message once and use a pa

[PATCH] small changes to the planner.

0001, updates the disclaimer to reflect the deco model that where used to generate the plan. 0002, rearranged the GUI to make it visibly easier to see which settings that belong together. 0003, disables GF fields when VPM-B is the selected deco model. 0001-Planner-update-disclamer.patch Descr

BT support on Mac

Just another data point... it appears on the Mac the test if (!localDevice->isValid()) { fails - even though BT is enable and the dive computer is paired with the Mac. I'm not quite sure how to debug this further... Thanks /D ___ subsurface ma

Re: [PATCH] Update INSTALL file for Debian/Ubuntu

On Tue, Jul 07, 2015 at 11:48:08AM +0100, Miika Turkia wrote: > Qt Bluetooth support requires the added packages on Debian/Ubuntu > (tested on Ubuntu 15.04) > > Signed-off-by: Miika Turkia > --- > INSTALL | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/INSTALL b/INSTA

Re: [PULL REQUEST] VPM-B Attempt 2.

On Tue, Jul 07, 2015 at 08:41:56PM +1000, Rick Walsh wrote: > Dirk, Jan, > > On 5 July 2015 at 23:56, Dirk Hohndel wrote: > > > On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: > > > Hi, > > > Here is another pull request. I hope now it's better. Everything was > > > reorganized fro

Re: [GSoC] Week 6 (Native Bluetooth support)

On Tue, Jul 07, 2015 at 01:49:08PM +0300, Miika Turkia wrote: > On Tue, Jul 7, 2015 at 9:02 AM, Thiago Macieira wrote: > > On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: > >> I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem > >> to figure out which package to install

Re: [GSoC] Week 6 (Native Bluetooth support)

On Tue, Jul 7, 2015 at 9:02 AM, Thiago Macieira wrote: > On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: >> I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem >> to figure out which package to install to get the QtBluetooth stuff. Any >> suggestion on the right package n

[PATCH] Update INSTALL file for Debian/Ubuntu

Qt Bluetooth support requires the added packages on Debian/Ubuntu (tested on Ubuntu 15.04) Signed-off-by: Miika Turkia --- INSTALL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index 32af14f..b784f89 100644 --- a/INSTALL +++ b/INSTALL @@ -73,7 +73,8 @@ s

Re: [PULL REQUEST] VPM-B Attempt 2.

Dirk, Jan, On 5 July 2015 at 23:56, Dirk Hohndel wrote: > On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: > > Hi, > > Here is another pull request. I hope now it's better. Everything was > > reorganized from scratch, the final code is almost the same. > > I like the patches much be