Fixes for Location selection on Mac

2015-07-20 Thread Tomaz Canabrava
So, I was working in the location management but some of the things on mac where pissing me off - Wrong colors, Wrong selection marker and stuff like this. This fixes it. Let me continue on the other stuff here now. 0001-Code-uneeded-because-the-drawControw-does-this-by-it.patch Description: Bin

Re: [GSoC] Week 8 (Native Bluetooth support)

2015-07-20 Thread Thiago Macieira
On Tuesday 21 July 2015 00:46:07 Claudiu Olteanu wrote: > What I know is that programming with Win32/Winsock2 API is > quite tricky (at least for me..:) ). Not just you. And it only gets worse with WinRT, which lacks even Winsock2... Fortunately, that's not a target for Subsurface. -- Thiago

[GSoC] Week 8 (Native Bluetooth support)

2015-07-20 Thread Claudiu Olteanu
Hello, Here is a summary about what I did last week: - tested and fixed some issues for Android platform - implemented a combobox which can be used to choose the local Bluetooth adapter - continue the documentation and developing the sample for Windows platform - created a new environment with Win

Re: Ctrl-+ and Qt5.5

2015-07-20 Thread Thiago Macieira
On Monday 20 July 2015 08:40:24 Thiago Macieira wrote: > I have an external USB with numeric keypad in the office. I'll see if I can > test that. Ctrl+KP_Plus works for me even without the patch. I can't tell what the patch is fixing then. -- Thiago Macieira - thiago (AT) macieira.info - thiago

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Dirk Hohndel
On Mon, Jul 20, 2015 at 07:59:15PM +0300, Claudiu Olteanu wrote: > Hi, > > I agree with Thiago. Probably it is a good idea to keep the Bluetooth > download feature only for versions >= 5.4. This is due the fact that in > version 5.4 they added support for BlueZ 5.X stack and probably most > of the

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Claudiu Olteanu
> > In general the mentor is not necessarily the clean up person... > I know, Thiago offered, but just to put this out here. > When I said that he should do some investigations I didn't mean to start hunting memory leaks on my code. I can do that by myself using their best friend - Valgring :). I

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Claudiu Olteanu
Hi, I agree with Thiago. Probably it is a good idea to keep the Bluetooth download feature only for versions >= 5.4. This is due the fact that in version 5.4 they added support for BlueZ 5.X stack and probably most of the users have this stack. To be honest I didn't take into account to test the

Re: Ctrl-+ and Qt5.5

2015-07-20 Thread Claudiu Olteanu
Yes, when I tested the shortcut I used the "+" key without shift. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Ctrl-+ and Qt5.5

2015-07-20 Thread Thiago Macieira
On Monday 20 July 2015 05:54:17 Dirk Hohndel wrote: > On Sun, Jul 19, 2015 at 07:43:19PM -0700, Thiago Macieira wrote: > > On Sunday 19 July 2015 19:38:25 Thiago Macieira wrote: > > > On Sunday 19 July 2015 06:28:37 Gaetan Bisson wrote: > > > > [2015-07-19 17:06:48 +0300] Claudiu Olteanu: > > > > >

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Thiago Macieira
On Monday 20 July 2015 06:59:30 Dirk Hohndel wrote: > So I pushed these patches and learned that they require at least Qt5.3 as > QBluetoothDeviceDiscoveryAgent::InvalidBluetoothAdapterError isn't defined > yet in Qt5.2. > > But that got me thinking - what is actually the reasonable minimum versio

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Dirk Hohndel
> On Jul 20, 2015, at 07:30, Miika Turkia wrote: > >>> >>> Agreed. Better looking templates or at least templates that look closer to >>> what we had. I'll admit that the "shades of orange and beige" color scheme >>> isn't high on my list of favorites. If we really want to play with colors >>

[PATCH] Add tooltip for geolocation lookup

2015-07-20 Thread Miika Turkia
Signed-off-by: Miika Turkia --- qt-ui/maintab.ui | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui/maintab.ui b/qt-ui/maintab.ui index c83d12e..4390d04 100644 --- a/qt-ui/maintab.ui +++ b/qt-ui/maintab.ui @@ -213,6 +213,9 @@ ... +

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Miika Turkia
On Mon, Jul 20, 2015 at 5:27 PM, Gehad Elrobey wrote: > > On Jul 20, 2015 3:27 PM, "Dirk Hohndel" wrote: >> >> On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: >> > >> - the cmake issues! can you even reproduce those? :-( >> > >> >> > > >> > > No I couldn't, it always works corr

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Gehad Elrobey
On Jul 20, 2015 3:27 PM, "Dirk Hohndel" wrote: > > On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: > > >> - the cmake issues! can you even reproduce those? :-( > > >> > > > > > > No I couldn't, it always works correctly with me. > > > > > > > this could be windows cmake specific

Re: [PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Gehad Elrobey
On Jul 20, 2015 3:38 PM, "Lubomir I. Ivanov" wrote: > > On 20 July 2015 at 16:34, Dirk Hohndel wrote: > > On Mon, Jul 20, 2015 at 04:29:50PM +0300, Lubomir I. Ivanov wrote: > >> On 20 July 2015 at 16:22, Dirk Hohndel wrote: > >> > On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Dirk Hohndel
So I pushed these patches and learned that they require at least Qt5.3 as QBluetoothDeviceDiscoveryAgent::InvalidBluetoothAdapterError isn't defined yet in Qt5.2. But that got me thinking - what is actually the reasonable minimum version for QtBluetooth support to be enabled in Subsurface builds?

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Miika Turkia
On Mon, Jul 20, 2015 at 4:27 PM, Dirk Hohndel wrote: > On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: >> >> - the cmake issues! can you even reproduce those? :-( >> >> >> >> do you think the timings are OK for the pencils down date? what else >> >> is on your TODO list? >> > >>

Re: [PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 16:34, Dirk Hohndel wrote: > On Mon, Jul 20, 2015 at 04:29:50PM +0300, Lubomir I. Ivanov wrote: >> On 20 July 2015 at 16:22, Dirk Hohndel wrote: >> > On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: >> >> Part 4 of the new GSoC printing module from Gehad. >> >

Re: [PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 16:22, Dirk Hohndel wrote: > On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: >> Part 4 of the new GSoC printing module from Gehad. > > I merged this. > >> ATM this is useable, but the stock templates aren't pretty yet; an important >> thing on the TODO list is

Re: [PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Dirk Hohndel
On Mon, Jul 20, 2015 at 04:29:50PM +0300, Lubomir I. Ivanov wrote: > On 20 July 2015 at 16:22, Dirk Hohndel wrote: > > On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: > >> Part 4 of the new GSoC printing module from Gehad. > > > > I merged this. > > > >> ATM this is useable, but

Re: [PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 16:22, Dirk Hohndel wrote: > On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: >> Part 4 of the new GSoC printing module from Gehad. > > I merged this. > thanks. lubomir -- ___ subsurface mailing list subsurface@subs

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Dirk Hohndel
On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: > >> - the cmake issues! can you even reproduce those? :-( > >> > > > > No I couldn't, it always works correctly with me. > > > > this could be windows cmake specific, but it's quite bad as it breaks > the entire build the second t

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 16:10, Gehad Elrobey wrote: > > > On Mon, Jul 20, 2015 at 3:02 PM, Lubomir I. Ivanov > wrote: >> >> On 20 July 2015 at 14:59, Gehad Elrobey wrote: >> > >> > Now we always rasterize for grayscale, I pushed the updates. >> > >> >> PR sent. thank you for bearing with the greyscal

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Gehad Elrobey
On Mon, Jul 20, 2015 at 3:02 PM, Lubomir I. Ivanov wrote: > On 20 July 2015 at 14:59, Gehad Elrobey wrote: > > > > Now we always rasterize for grayscale, I pushed the updates. > > > > PR sent. thank you for bearing with the greyscale issues... > > some important things TODO would be: > > - add t

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 14:59, Gehad Elrobey wrote: > > Now we always rasterize for grayscale, I pushed the updates. > PR sent. thank you for bearing with the greyscale issues... some important things TODO would be: - add the old "6 dives per page" template. some of the users will probably bring up

Re: Ctrl-+ and Qt5.5

2015-07-20 Thread Dirk Hohndel
On Sun, Jul 19, 2015 at 05:06:48PM +0300, Claudiu Olteanu wrote: > Hi there, > > I have a Fedora 22 with Qt 5.5.0 and the shortcut is working. > Subsurface version: 4.4.2-1040-g5cbbff008411c322. Given Thiago's email I at first was confused... but then of course I'm not familiar with Romanian keyb

Re: Ctrl-+ and Qt5.5

2015-07-20 Thread Dirk Hohndel
On Sun, Jul 19, 2015 at 07:43:19PM -0700, Thiago Macieira wrote: > On Sunday 19 July 2015 19:38:25 Thiago Macieira wrote: > > On Sunday 19 July 2015 06:28:37 Gaetan Bisson wrote: > > > [2015-07-19 17:06:48 +0300] Claudiu Olteanu: > > > > I have a Fedora 22 with Qt 5.5.0 and the shortcut is working.

[PULL REQUEST] GSoC Printing: part 4

2015-07-20 Thread Lubomir I. Ivanov
Part 4 of the new GSoC printing module from Gehad. Adds: 1) Better greyscale conversations when "print in color" is de-selected. Due to a QPrinter->setColorMode() bug we are forced to rasterize the entire page (profile, tables, everything) when in greyscale. We have faced some limitations here inc

Re: [PATCH] Bluetooth improvements

2015-07-20 Thread Dirk Hohndel
On Sun, Jul 19, 2015 at 11:25:17PM +0300, Claudiu Olteanu wrote: > > > > Child QObjects don't need to be cleaned. But I'm not seeing any > > parent-child > > relationship here. > > > > I'm deferring to you here. I'm just pointing out, I haven't done any > > investigation. > > > > Would you like me

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Gehad Elrobey
On Mon, Jul 20, 2015 at 12:20 PM, Lubomir I. Ivanov wrote: > On 20 July 2015 at 13:06, Gehad Elrobey wrote: > > > > > > On Sun, Jul 19, 2015 at 9:56 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 19 July 2015 at 13:23, Gehad Elrobey wrote: > >> > > >> > > >> > On Fri, Jul 17, 2015 at 9:28 PM, L

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-20 Thread Lubomir I. Ivanov
On 20 July 2015 at 13:06, Gehad Elrobey wrote: > > > On Sun, Jul 19, 2015 at 9:56 PM, Lubomir I. Ivanov > wrote: >> >> On 19 July 2015 at 13:23, Gehad Elrobey wrote: >> > >> > >> > On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> On 17 July 2015 at 22:17, Lubomir I. Iv

[PATCH] Enable android build on Mac.

2015-07-20 Thread Joakim Bygdell
This adds system specific versions to certain parameters when building the Android package on a Mac. 0001-Enable-Android-build-on-Mac.patch Description: Binary data /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.su