Re: [PULL REQUEST] VPM-B

2015-08-15 Thread Rick Walsh
Hi Jan, On 16 August 2015 at 00:11, Jan Darowski jan.darow...@gmail.com wrote: Hi! Here is my next pull request, it adds all the remaining vpm-b elements. What is left to code is some way of logged dives rating against vpm-b and probably some fixes. I've looked at and tested your latest

Re: [PATCH] Parse erroneous sample time for MK6

2015-08-15 Thread Willem Ferguson
On 15/08/2015 13:57, Dirk Hohndel wrote: On Wed, Aug 12, 2015 at 06:33:02PM +0300, Miika Turkia wrote: Sometimes MKVI records sample time erroneously and we have to fix the time. The 2 samples (from single DC) I have seen suffering this issue can be corrected by subtracting 65528 from the

Re: Customizable prints progress

2015-08-15 Thread Lubomir I. Ivanov
On 14 August 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 12 August 2015 at 18:47, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I have resolved most of the issues you have

Re: [PATH] Add native Bluetooth support for Windows platforms

2015-08-15 Thread Dirk Hohndel
On Fri, Aug 14, 2015 at 12:13:40AM +0300, Claudiu Olteanu wrote: These patches will add Bluetooth support for Windows platforms and will fix some potential issues. Since we cannot use the QtBluetooth framework I needed to implement our custom Bluetooth device discovery agent. I decided to

Re: [PATCH] Unify ceiling calculation between Buehlmann and VPM-B

2015-08-15 Thread Dirk Hohndel
On Wed, Aug 12, 2015 at 12:44:50PM +0200, Robert Helling wrote: From cb8aa7d60ba419cb7c0b50276df336557f359b3f Mon Sep 17 00:00:00 2001 From: Robert C. Helling hell...@atdotde.de Date: Wed, 12 Aug 2015 12:06:52 +0200 Subject: [PATCH] Some unification between Buehlmann and VPM-B as a bonus,

Re: [PATCH] Parse erroneous sample time for MK6

2015-08-15 Thread Dirk Hohndel
On Wed, Aug 12, 2015 at 06:33:02PM +0300, Miika Turkia wrote: Sometimes MKVI records sample time erroneously and we have to fix the time. The 2 samples (from single DC) I have seen suffering this issue can be corrected by subtracting 65528 from the sample time. Fixes #916 Signed-off-by:

Re: [PATCH] libdivecomputer: Subsurface-testing branch

2015-08-15 Thread Dirk Hohndel
On Fri, Aug 14, 2015 at 12:11:28AM +0300, Claudiu Olteanu wrote: Hi there, You can find attached some patches which will add a set_timeout callback for our custom implementation. This callback will be needed for Windows platforms. Thanks. Just a small comment - don't simpyl repeat the

[PULL REQUEST] GSoC Printing: part 6

2015-08-15 Thread Lubomir I. Ivanov
This is the last batch of patches from Gehad for the soft pencils down date. For those who have free time and are interested in the printing module please compile and have a look at this update. I have requested multiple revisions on how the bundled templates look, trying to get them as close to

Re: [PATCH] Fix regular expressions for git repositories

2015-08-15 Thread Dirk Hohndel
On Mon, Aug 10, 2015 at 09:56:42PM +0200, Salvador Cuñat wrote: 2015-08-10 20:42 GMT+02:00 Salvador Cuñat salvador.cu...@gmail.com: I've been testing this a bit and, curiously, both regexps worked fine. Funnier still, the git repo is opened typping ~/git_divelog[tests] or

Re: [PATH] Add native Bluetooth support for Windows platforms

2015-08-15 Thread Claudiu Olteanu
Can you explain this a bit more? Should we not prefer the deviceLabel IF we can get it? When I created that patch I thought that it would be better to use only the device address to identify if the device is already in the list. This is due the fact that currently the pattern of the

[PULL REQUEST] VPM-B

2015-08-15 Thread Jan Darowski
Hi! Here is my next pull request, it adds all the remaining vpm-b elements. What is left to code is some way of logged dives rating against vpm-b and probably some fixes. The following changes since commit 342479586d1f34a2b7f3d1d69037cb0d631489fa: Planner: use the heap for note buffers

Re: [PATCH] Unify ceiling calculation between Buehlmann and VPM-B

2015-08-15 Thread Robert Helling
On 15 Aug 2015, at 13:49, Dirk Hohndel d...@hohndel.org wrote: Hi Dirk, Please remind me, what is missing to be able to show VPM-B ceilings for logged dives? I remember there was something about the way VPM-B makes assumptions about remainder of the dive… OK, here is VPM-B in a nutshell

Re: [PATCH] Parse erroneous sample time for MK6

2015-08-15 Thread Miika Turkia
On Sat, Aug 15, 2015 at 2:57 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Aug 12, 2015 at 06:33:02PM +0300, Miika Turkia wrote: Sometimes MKVI records sample time erroneously and we have to fix the time. The 2 samples (from single DC) I have seen suffering this issue can be corrected by

Re: [PATH] Add native Bluetooth support for Windows platforms

2015-08-15 Thread Claudiu Olteanu
No I didn't do any copy and paste. I will send you tomorrow the patches with the modification discussed (I will clear the discovered devices list after each update) and I will update the commit message for the patch with the implementation of a device discovery agent. Claudiu

Re: Customizable prints progress

2015-08-15 Thread Lubomir I. Ivanov
On 15 August 2015 at 14:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 August 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 12 August 2015 at 18:47, Gehad Elrobey gehadelro...@gmail.com

Re: Customizable prints progress

2015-08-15 Thread Lubomir I. Ivanov
On 15 August 2015 at 15:23, Lubomir I. Ivanov neolit...@gmail.com wrote: On 15 August 2015 at 14:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 August 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov neolit...@gmail.com

Re: [PATH] Add native Bluetooth support for Windows platforms

2015-08-15 Thread Dirk Hohndel
On Sat, Aug 15, 2015 at 04:15:54PM +0300, Claudiu Olteanu wrote: Can you explain this a bit more? Should we not prefer the deviceLabel IF we can get it? When I created that patch I thought that it would be better to use only the device address to identify if the device is already in the

Re: [PATCH] Unify ceiling calculation between Buehlmann and VPM-B

2015-08-15 Thread Dirk Hohndel
Hi Robert, On Sat, Aug 15, 2015 at 04:19:12PM +0200, Robert Helling wrote: Please remind me, what is missing to be able to show VPM-B ceilings for logged dives? I remember there was something about the way VPM-B makes assumptions about remainder of the dive… OK, here is VPM-B in a