Re: Cloud storage merge, baby steps

On Tue, Sep 08, 2015 at 01:01:12PM +0930, Steve wrote: > > Something I noticed when testing and making backups. > If I use the cloud storage then save it as a local file, after opening the > local file the line breaks in the dive site edit notes field are not retained > (v1498 daily on windows

Re: Beta Testing

On 9 September 2015 at 14:07, Lubomir I. Ivanov wrote: > > ok, so apparently it's a generic Windows issue. > > but i do see it, on Windows 7 SP1. > tried with or without the "Aero" compositor and it always shows for me. > notes to self: i'm building with Qt 5.3 so this

Re: printing patches

On Wed, Sep 9, 2015 at 1:14 PM, Lubomir I. Ivanov wrote: > On 9 September 2015 at 13:15, Dirk Hohndel wrote: > > Gehad, Lubomir, > > > > I saw some patches a while ago that Lubomir commented on and that Gehad > > said he would rework and resubmit. Did I

Re: Profile graphics on printing

On 9 September 2015 at 13:44, Anton Lundin wrote: > Hi. > > I had some time while waiting for a build server to catch up at work and > played with the new fancy printing. > > It looks great for most things, but some of the graphics on the profile > is a bit to blurry and

Re: Beta Testing

Ahh, that might be it. My w7 pc is a corporate one which has a number of restrictions on it. Ill try an installation on an unrestricted pc > On 9 Sep 2015, at 10:44, "Dirk Hohndel" wrote: > >> On Wed, Sep 09, 2015 at 09:08:16AM +, John Smith wrote: >> >>> That one

Re: Beta Testing

On 9 September 2015 at 13:32, John Smith wrote: > Yes, whilst initially loading the ui, everything locks up. > If i click on something, i occasionally get a program not responding error or > a delay until it activates > that's a sign that the spinner (which is a dialog

Re: [PATCH] uemis-downloader: don't use unknown type u_int32_t

On Wed, Sep 09, 2015 at 12:21:57AM +0300, Guido Lerch wrote: > > Dirk. > If I stash my current changes and get the new master would I pickup Lubomir's > changes?  Yes. Are you developing on master? Not a good idea. It would be much better if you worked on a branch... /D

printing patches

Gehad, Lubomir, I saw some patches a while ago that Lubomir commented on and that Gehad said he would rework and resubmit. Did I miss the resubmission? I'm trying to make sure nothing gets dropped and we continue to make progress towards 4.5 and printing certainly is one of the cool new features

Re: printing patches

On 9 September 2015 at 14:43, Gehad Elrobey wrote: > > > On Wed, Sep 9, 2015 at 1:14 PM, Lubomir I. Ivanov > wrote: >> >> On 9 September 2015 at 13:15, Dirk Hohndel wrote: >> > Gehad, Lubomir, >> > >> > I saw some patches a while

Re: Beta Testing

On 9 September 2015 at 12:08, John Smith wrote: > > > How about if I copy my preferences file from one pc to the other? that > shoudl prove that its either user error or not. - where is it and whats it > called though? > technically you can export your Subsurface registry

Profile graphics on printing

Hi. I had some time while waiting for a build server to catch up at work and played with the new fancy printing. It looks great for most things, but some of the graphics on the profile is a bit to blurry and dis-proportional for my taste. Eg. the gas-change icons are a bit to big, and thus a

Re: Beta Testing

On 9 September 2015 at 13:57, Sander M. Kleijwegt wrote: > btw john is not the only one having spinner issues. I am working from windows > 7 pro SP1 with subsurface 4.5beta1 and was unaware there should be a spinner > until I read the discussions on the mailing list. When

Re: printing patches

On Wed, Sep 09, 2015 at 02:14:21PM +0300, Lubomir I. Ivanov wrote: > On 9 September 2015 at 13:15, Dirk Hohndel wrote: > > Gehad, Lubomir, > > > > I saw some patches a while ago that Lubomir commented on and that Gehad > > said he would rework and resubmit. Did I miss the

Re: Beta Testing

On Wed, Sep 09, 2015 at 09:08:16AM +, John Smith wrote: > > > That one I want to understand more about. Do you have some screen shots > > that show what's happening. Feel free to blank out your password (as we > > show that in preferences). > > Ive attached screen grabs from both systems

Re: printing patches

On 9 September 2015 at 13:15, Dirk Hohndel wrote: > Gehad, Lubomir, > > I saw some patches a while ago that Lubomir commented on and that Gehad > said he would rework and resubmit. Did I miss the resubmission? last week Gehad said he is (and/or going to be) busy. there are 3

Re: Beta Testing

On Wed, Sep 09, 2015 at 02:29:52PM +0300, Lubomir I. Ivanov wrote: > On 9 September 2015 at 14:07, Lubomir I. Ivanov wrote: > > > > ok, so apparently it's a generic Windows issue. > > > > but i do see it, on Windows 7 SP1. > > tried with or without the "Aero" compositor and

Re: Beta Testing

On Wed, Sep 09, 2015 at 01:38:18PM +0200, Robert Helling wrote: > Hi, > > > On 09.09.2015, at 11:55, Lubomir I. Ivanov wrote: > > > > > > technically you can export your Subsurface registry settings and > > import (merge) them on another machine. > > > > Start menu -> in

Bluetooth blues

I was trying to document the Bluetooth interface using a Shearwater Petrel. Below is the console output of the three attempts. I had three sessions: 1) Ubuntu 15.04 2) Fedora 22 3) Fedora 22 On Ubuntu, the first four of 37 dives were downloaded. On Fedora it resulted in a segfault both times

[RFC PATCH] Datatrak parsing

I have some trouble understanding this code, but as there is a clear bug involved (null dereference), I ask others to verify if I am onto something. And if datatrak import still works with this patch. From af2935622b1f00f373ed38c8e3194e25504372b6 Mon Sep 17 00:00:00 2001 From: Miika Turkia

Question about ostc code

I am looking at ostc_prepare_data function and do not fully understand the code. It looks like in successful case ldc_dat memory allocation is freed and we end up pointing to unallocated data in our data structures. However, the failure case ends up leaking memory. Is the attached patch correct

[PATCH] Delay freeing of memory after use

Signed-off-by: Miika Turkia --- qtserialbluetooth.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qtserialbluetooth.cpp b/qtserialbluetooth.cpp index 45fc8d1..ebbd1d4 100644 --- a/qtserialbluetooth.cpp +++ b/qtserialbluetooth.cpp @@ -151,12 +151,12

[PATCH 1/2] qthelper.cpp: use timeFormat and dateFormat for the Dive class

From: "Lubomir I. Ivanov" The Dive class has a method which sets the m_time and m_date members but it uses a custom format. By using the static dateFormat and timeFormat variables this helper class now uses the same date and time format as in the dive list. Fixes #920

[PATCH 2/2] qthelper.cpp: don't hardcode the Dive m_duration as minutes

From: "Lubomir I. Ivanov" get_dive_duration_string() should be used in a similiar way to socialnetworks.cpp so that the Dive::put_duration() method sets the variable in the h:min format. Signed-off-by: Lubomir I. Ivanov --- qthelper.cpp | 2 +- 1 file

Re: Beta Testing

On Wednesday 09 September 2015 07:23:34 Dirk Hohndel wrote: > I'm in a bit of a rush this morning (strangely, being up half of the night > caused me to oversleep in the morning...). But I believe that QSettings > can write an ini style file on all platforms. > Maybe one of the Qt experts can give

Re: Bluetooth blues

On 09/09/2015 16:56, Claudiu Olteanu wrote: Hi there, It seems that it doesn't use our custom implementation for the open method. It should use *shearwater_common_custom_open *to open the device. This means that your libdivecomputer version is incorrect or the SSRF_CUSTOM_SERIAL wasn't cached

[PATCH 6/6] Initialize variable before use

Signed-off-by: Miika Turkia --- uemis-downloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index d9ddde6..0bc5938 100644 --- a/uemis-downloader.c +++ b/uemis-downloader.c @@ -788,7 +788,7 @@ static bool

[PATCH 1/6] Delay freeing of memory after use

Signed-off-by: Miika Turkia --- qtserialbluetooth.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qtserialbluetooth.cpp b/qtserialbluetooth.cpp index 45fc8d1..ebbd1d4 100644 --- a/qtserialbluetooth.cpp +++ b/qtserialbluetooth.cpp @@ -151,12 +151,12

[PATCH 3/6] Fix memory leaks in serial ftdi

Signed-off-by: Miika Turkia --- serial_ftdi.c | 4 1 file changed, 4 insertions(+) diff --git a/serial_ftdi.c b/serial_ftdi.c index ab74b9a..cbac026 100644 --- a/serial_ftdi.c +++ b/serial_ftdi.c @@ -186,6 +186,7 @@ static dc_status_t serial_ftdi_open (serial_t

[PATCH 4/6] Fix memory leak on uemis downloader

Signed-off-by: Miika Turkia --- uemis-downloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index 0cb0f9f..d17f67d 100644 --- a/uemis-downloader.c +++ b/uemis-downloader.c @@ -960,7 +960,7 @@ static bool

[PATCH] Save settings in closeEvent, not destructor

This switches to use the closeEvent to save settings and cleanup instead of the destructor. Signed-off-by: Anton Lundin --- qt-ui/configuredivecomputerdialog.cpp | 4 1 file changed, 4 insertions(+) diff --git a/qt-ui/configuredivecomputerdialog.cpp

Re[2]: Question about ostc code

:-) this saves me the Google search. I'll take a look once I am back from my fire brigade exercises. G. Lerch Mittwoch, 9. September 2015 18:54 +0200 von Dirk Hohndel : >On Wed, Sep 09, 2015 at 07:48:03PM +0300, Guido Lerch wrote: >> >> Hi Miika >> I might have some time to

[PATCH] Do not ignore the first tag on autocompletion.

I found this bug while investigating ticket #923. It seems that if the user had a taglist like: Sentinel, s, sggg, s this patch would fix showing of Sentinel since it was the first tag in the list. If the user had a taglist like "s, sbbb, Sentinel, s, sggg" then this patch won't

RE: manualy adding shallow dives stick to 15m

I have seen this as well, but it has nothing to do with the actual depth. When you edit the profile before saving the dive, the depth parameters for the dive are updated correctly. Once you saved the dive however, there is no way of changing them again. I haven't had time to look into it yet. I

[PATCH] Exit with failure if dc_open method fails

If the dc_serial_*_open method fails then we should exit with an error and don't try to open the device using the native implementation. Currently if the local Bluetooth adapter doesn't connect successfully to a dive computer it tries to open the device using the native serial implementation

Re: Profile graphics on printing

> On 09 Sep 2015, at 14:07, Lubomir I. Ivanov wrote: > > On 9 September 2015 at 13:44, Anton Lundin > wrote: >> Hi. >> >> I had some time while waiting for a build server to catch up at work and >> played with the new fancy

Re: Question about ostc code

On Wed, Sep 09, 2015 at 07:48:03PM +0300, Guido Lerch wrote: > > Hi Miika > I might have some time to test tomorrow. I have an OSTC 3. > Need to figure out first how to apply the patch my testing branch, Google > will help I suppose. It's pretty easy. Save the email to a file. git am < file

RE: [PATCH] Do not ignore the first tag on autocompletion.

Added a "See #923" in the commit per request. -Original Message- From: subsurface [mailto:subsurface-boun...@subsurface-divelog.org] On Behalf Of Sander M. Kleijwegt Sent: woensdag 9 september 2015 21:04 To: Subsurface Mailing List Subject: [PATCH] Do not ignore the first tag on

manualy adding shallow dives stick to 15m

Hi all, I seem to have run into an issue when manualy adding dives with less than 15m depth. After editing the dive profile the profile stays as i created it (e.g. 10m), but in the dive list the depth sticks to 15m. Even if i create a dive to for example 30m, save and then change it back to 10m

Re: [RFC PATCH] Datatrak parsing

Godd night Dirk, Miika 2015-09-09 18:13 GMT+02:00 Dirk Hohndel : > On Wed, Sep 09, 2015 at 06:13:49PM +0300, Miika Turkia wrote: > > I have some trouble understanding this code, but as there is a clear > > bug involved (null dereference), I ask others to verify if I am onto > >