Re: Windows binary saga

2015-09-23 Thread Lubomir I. Ivanov
On 23 September 2015 at 15:40, Dirk Hohndel wrote: > On Wed, Sep 23, 2015 at 02:58:14PM +0300, Lubomir I. Ivanov wrote: >> >> "Windows Key" + R (opens the "run prompt") >> type: "eventvwr" >> >> it can point out the faulting module, offset and the error type, but >> that's far

Re: Windows binary saga

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 12:47:41PM +0300, Lubomir I. Ivanov wrote: > On 23 September 2015 at 12:28, Lubomir I. Ivanov wrote: > > On 23 September 2015 at 10:54, Lubomir I. Ivanov > > wrote: > >> On 23 September 2015 at 06:52, Dirk Hohndel

Re: Windows binary saga

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 10:54:14AM +0300, Lubomir I. Ivanov wrote: > On 23 September 2015 at 06:52, Dirk Hohndel wrote: > > > Lots of progress. > > > > I massaged MXE to go from MinGW 5.2.0 back to 4.9.2 (the compiler used in > > the official Qt5.5 builds). That turned out to

Re: Windows binary saga

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 02:58:14PM +0300, Lubomir I. Ivanov wrote: > > "Windows Key" + R (opens the "run prompt") > type: "eventvwr" > > it can point out the faulting module, offset and the error type, but > that's far less useful than what OSX has as crash log info, for > instance. > from there

Re: Windows binary saga

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 02:58:14PM +0300, Lubomir I. Ivanov wrote: > On 23 September 2015 at 14:14, Dirk Hohndel wrote: > > > > On Windows 10 you apparently no longer have the option to see a stack > > trace or any crash information. It appears to simply send that data to > >

[PATCH 7/7] planner.c: fix missing brances warning

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" for a 'struct gasmix' initialization, the 'permille' value from franction_t should have it's own braces. Signed-off-by: Lubomir I. Ivanov --- planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/7] divesite.c: fix warnings about unused variables

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- divesite.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/divesite.c b/divesite.c index a8c5ea4..f668889 100644 --- a/divesite.c +++ b/divesite.c @@ -55,7 +55,6 @@

[PATCH 6/7] planner.c: fix warnings about unused variables

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- planner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/planner.c b/planner.c index 722eeb1..d4bf478 100644 --- a/planner.c +++ b/planner.c @@ -975,7 +975,6 @@ bool plan(struct

[PATCH 3/7] file.c: fix warnings about unused variables

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/file.c b/file.c index a7a340f..a7b407f 100644 --- a/file.c +++ b/file.c @@ -844,7 +844,6 @@ int parse_csv_file(const char

[PATCH 4/7] libdivecomputer.c: fix warnings about unused variables

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- libdivecomputer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libdivecomputer.c b/libdivecomputer.c index 631e0da..26f5e59 100644 --- a/libdivecomputer.c +++ b/libdivecomputer.c @@

[PATCH 1/7] deco.c: fix warnings about unused variables

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- deco.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/deco.c b/deco.c index 39a6b34..f9d6032 100644 --- a/deco.c +++ b/deco.c @@ -369,7 +369,6 @@ double calc_surface_phase(double

[PATCH 5/7] load-git.c: fix warning about sscanf() argument

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Type of the 4th argument is detected as "enum *", we cast it to (int *) when passed to sscanf(). Signed-off-by: Lubomir I. Ivanov --- untested! --- load-git.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Gaetan Bisson
[2015-09-23 14:58:43 -1000] Gaetan Bisson: > cmake \ > -DCMAKE_BUILD_TYPE=Release \ > -DCMAKE_INSTALL_PREFIX=/usr \ > -DMARBLE_INCLUDE_DIR='/usr/include/subsurface' \ > -DUSE_LIBGIT23_API=1 \ > . I had missed this error

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Gaetan Bisson
[2015-09-23 20:04:56 -0700] Dirk Hohndel: > On Wed, Sep 23, 2015 at 07:58:02PM -0700, Dirk Hohndel wrote: > > On Wed, Sep 23, 2015 at 04:36:45PM -1000, Gaetan Bisson wrote: > > > [2015-09-23 15:53:59 -1000] Gaetan Bisson: > > > > Ah, that second issue goes away (and subsurface builds fine) when I

Re: Windows binary saga

2015-09-23 Thread Lubomir I. Ivanov
On 23 September 2015 at 06:52, Dirk Hohndel wrote: > Lots of progress. > > I massaged MXE to go from MinGW 5.2.0 back to 4.9.2 (the compiler used in > the official Qt5.5 builds). That turned out to be a bit of a pain but hey, > I think I have it working. > > Rebuilt all the

Re: DiveLocationManagement rewrite

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 05:45:44PM -0300, Tomaz Canabrava wrote: > Dirk, > Here comes the rest of the series. I'v tested with: > - No Dives > - Dives > - Creating Dives > - Cancelling > > everything seemed to work - I need a bit of help testing it. after all it's > a major rewrite. Much as it

Re: Windows binary saga

2015-09-23 Thread Dirk Hohndel
And after a lot more of what I would mostly call "random changes that make no sense" I appear to have a working daily build. Please try subsurface-4.4.97-41-g148b30849aba.exe (or a newer version, in case you read this after I make a newer one available). I'm especially interested in a) does it

Re: DiveLocationManagement rewrite

2015-09-23 Thread Tomaz Canabrava
Dirk, Here comes the rest of the series. I'v tested with: - No Dives - Dives - Creating Dives - Cancelling everything seemed to work - I need a bit of help testing it. after all it's a major rewrite. points: - new code is *much* more easy to read and follow. - Lots of dead code removed. - you

[PATCH] RoutingWidget.cpp: fix error about non-static const QString

2015-09-23 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" If 'info' remains as const an error is thrown that it has to be a static member. Signed-off-by: Lubomir I. Ivanov --- this is a patch against the Subsurface-branch of ssrfmarble. --- src/lib/marble/routing/RoutingWidget.cpp |

[PATCH] Add icon for georeference in preferences

2015-09-23 Thread Miika Turkia
It looks odd if one item is missing an icon. Thus suggesting (yet another) placeholder icon for the preferences dialog. Signed-off-by: Miika Turkia --- I totally understand, if this is not accepted, knowing my artistic skills and the state where we are on release cycle...

Re: Windows binary saga

2015-09-23 Thread Lubomir I. Ivanov
On 23 September 2015 at 10:54, Lubomir I. Ivanov wrote: > On 23 September 2015 at 06:52, Dirk Hohndel wrote: >> >> Anyway, I'll stop here for today. Feel free to play with it - it's in >> downloads/daily as subsurface-4.4.97-26-ge66f0895c68c.exe >> > > ok,

Re: Windows binary saga

2015-09-23 Thread Lubomir I. Ivanov
On 23 September 2015 at 12:28, Lubomir I. Ivanov wrote: > On 23 September 2015 at 10:54, Lubomir I. Ivanov wrote: >> On 23 September 2015 at 06:52, Dirk Hohndel wrote: >>> >>> Anyway, I'll stop here for today. Feel free to play with it

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Gaetan Bisson
[2015-09-23 15:53:59 -1000] Gaetan Bisson: > Ah, that second issue goes away (and subsurface builds fine) when I add > the cmake option -DMARBLE_LIBRARIES=/usr/lib/libssrfmarblewidget.so . Oh, now I'm getting a segfault when I edit any dive and click "Apply Changes". Program received signal

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 04:36:45PM -1000, Gaetan Bisson wrote: > [2015-09-23 15:53:59 -1000] Gaetan Bisson: > > Ah, that second issue goes away (and subsurface builds fine) when I add > > the cmake option -DMARBLE_LIBRARIES=/usr/lib/libssrfmarblewidget.so . > > Oh, now I'm getting a segfault when

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Dirk Hohndel
On Wed, Sep 23, 2015 at 07:58:02PM -0700, Dirk Hohndel wrote: > On Wed, Sep 23, 2015 at 04:36:45PM -1000, Gaetan Bisson wrote: > > [2015-09-23 15:53:59 -1000] Gaetan Bisson: > > > Ah, that second issue goes away (and subsurface builds fine) when I add > > > the cmake option

Re: user-manual: Geo-lookup

2015-09-23 Thread Dirk Hohndel
> On Sep 23, 2015, at 3:49 PM, Willem Ferguson > wrote: > > Dirk, > Apologies for being a nuisance. I am busy with the Preferences section. > I know we corresponded about this beforehand but I am not confident to write > user manual text on this. Some

RE: User manual: Bluetooth UI description

2015-09-23 Thread Steve
Claudiu, Andrej, Guido, I added a description of the Bluetooth UI to the user manual (section 5.2.2). You will do me a big favour if you would be prepared to read through this and comment on the accuracy and completeness of the information?? Kind regards, Willem This was not addressed

[PATCH] User manual systematic update (Part 4)

2015-09-23 Thread Willem Ferguson
[PATCH] User manual systematic review (Part 4) 1) Delete section on mobile application 2) Update Preferences and Menu options sections Only the text is updated, no images are added or replaced. Signed-off-by: Willem Ferguson From

Re: cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Gaetan Bisson
[2015-09-23 14:58:43 -1000] Gaetan Bisson: > linking fails with: > > [100%] Linking CXX executable subsurface > libsubsurface_interface.a(subsurface_interface_automoc.cpp.o): In > function `GlobeGPS::qt_metacall(QMetaObject::Call, int, void**)': >

cmake -DMARBLE_INCLUDE_DIR broken?

2015-09-23 Thread Gaetan Bisson
Hi, I've just built and installed today's git snapshot of our marble branch. Now I'm trying to build today's git snapshot of subsurface against it. However, invoking cmake as: cmake \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=/usr \