Re: 4.5.2

2015-11-09 Thread Matthias Heinrichs
Hi all, Sorry for that, we had to include some minor changes to remove some annoying bugs in our internal logbook. So life doesn't get boring for you ;-) Cheers, Matthias Am 07.11.2015 um 23:05 schrieb Dirk Hohndel: Just a quick heads up. Heinrichs Weikamp surprised us with a firmware cha

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 08:57, Dirk Hohndel wrote: > > What we have in master works. if something can't be written in plain old C++ then it's probably badly engineered, lazy or feature hungry. > > I have no interest in seeing Subsurface code made unreadable by C++11 > features - i'm sure a lot of

something is wrong with the "facebook_integration" module

2015-11-09 Thread Lubomir I. Ivanov
hey Tomaz, cmake version 3.2.0-rc2, native Windows. with the latest master i get thousands of "undefined references" errors. CMakeFiles\facebook_integration.dir/objects.a(facebookconnectwidget.cpp.obj): In function `ZN15FacebookManager8sendDiveEv': C:/dev/subsurface/desktop-widgets/plugins/faceb

[PATCH] pluginmanager.h: fix a warning about return statement

2015-11-09 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- subsurface-core/pluginmanager.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subsurface-core/pluginmanager.h b/subsurface-core/pluginmanager.h index 19e88b8..6a46c87 100644 --- a/subsurface-core/pluginma

Re: something is wrong with the "facebook_integration" module

2015-11-09 Thread Tomaz Canabrava
On Mon, Nov 9, 2015 at 11:21 AM, Lubomir I. Ivanov wrote: > hey Tomaz, > > cmake version 3.2.0-rc2, native Windows. > > with the latest master i get thousands of "undefined references" errors. > > > CMakeFiles\facebook_integration.dir/objects.a(facebookconnectwidget.cpp.obj): > In function `ZN15F

Re: [PATCH] divetooltipitem.cpp: prettify the tooltip bounds and padding

2015-11-09 Thread Lubomir I. Ivanov
On 8 November 2015 at 15:41, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > When the tooltip is expanded, not enough padding is present right > from the text and bottom from it, making the tooltip border > appear very close to the text. > > When the tooltip is collapsed (no time entries

Re: something is wrong with the "facebook_integration" module

2015-11-09 Thread Dirk Hohndel
> On Nov 9, 2015, at 6:25 AM, Tomaz Canabrava wrote: > > Hey > > to me it looks like that in my case the facebook module is not linked > both to the core and the desktop-widget modules. > > if set the following in the cmake CMD line: > -DDISABLE_PLUGINS=1 -DFBSUPPORT=1 > all is good. > > and

Re: something is wrong with the "facebook_integration" module

2015-11-09 Thread Tomaz Canabrava
No worries, I can still have the separation (that's something that I want) and remove the plugin, I'll do that today. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Save image thumbnails cache

2015-11-09 Thread Robert C. Helling
From d06818c1f8573c186cf58e9a21a8500262568ad9 Mon Sep 17 00:00:00 2001 From: "Robert C. Helling" Date: Mon, 9 Nov 2015 16:48:12 +0100 Subject: [PATCH] Store Thumbnails with image hashes This drastically improves the time it takes to select a dive with several pictures at the expense of longer sta

Re: something is wrong with the "facebook_integration" module

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 17:24, Dirk Hohndel wrote: > > On Nov 9, 2015, at 6:25 AM, Tomaz Canabrava wrote: > >> also, unless i'm mistaken, if a plugin is static linked against the >> same .a modules that the executable is linked (core, profile, >> desktop-widges, etc) aren't we are going to distribu

[PATCH 2/2] modeldelegates: remove printing related delegates

2015-11-09 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Remove HTMLDelegate and ProfilePrintDelagate as these are obosolete. The print related rendering at the moment happens via QWebView. Signed-off-by: Lubomir I. Ivanov --- desktop-widgets/modeldelegates.cpp | 66 -- desktop-widgets/mo

[PATCH 1/2] qt-models: remove obsolete printer related classes

2015-11-09 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" The profileprintmodel.cpp/.h and the tableprintmode.cpp/.h pairs are obsolete. The print layouting is now handled via the Grantlee library and HTML. Signed-off-by: Lubomir I. Ivanov --- qt-models/CMakeLists.txt| 4 +- qt-models/profileprintmodel.cpp | 157 -

Re: [PATCH 1/2] qt-models: remove obsolete printer related classes

2015-11-09 Thread Tomaz Canabrava
Removed Obsolete Code <3 Music to my ears. On Mon, Nov 9, 2015 at 4:42 PM, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > The profileprintmodel.cpp/.h and the > tableprintmode.cpp/.h pairs are obsolete. > > The print layouting is now handled via the Grantlee library > and HTML. > > Si

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira wrote: > > > > Can you try adding the -stdlib option in the AppleClang branch to see what > > happens? > > I have an odd question. > > Why? Well, for one thing, because it would use libc++,

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Dirk Hohndel
On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira wrote: > > > > > > Can you try adding the -stdlib option in the AppleClang branch to see what > > > happens? > > > > I hav

[PATH] Remove facebook plugin, clean code, deal with old cmakes, oh my...

2015-11-09 Thread Tomaz Canabrava
From 06f52f5c5d4e984b58dc72f76ebfdcb4e7397f02 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 9 Nov 2015 18:05:30 -0200 Subject: [PATCH 1/4] Remove Facebook from Plugins Signed-off-by: Tomaz Canabrava --- CMakeLists.txt | 1 + desktop-widgets/mainwin

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 22:11, Dirk Hohndel wrote: > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: >> >> Fair enough, but you won't get away with that for long :-P >> >> Qt 5.6 will be the last release to support building in C++98 mode. Starting >> with Qt 5.7, a great deal of C++

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
On Mon, Nov 9, 2015 at 6:11 PM, Dirk Hohndel wrote: > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > > On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira > wrote: > > > > > > > > Can you try adding the -stdlib option i

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
On Mon, Nov 9, 2015 at 7:21 PM, Lubomir I. Ivanov wrote: > On 9 November 2015 at 22:11, Dirk Hohndel wrote: > > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > >> > >> Fair enough, but you won't get away with that for long :-P > >> > >> Qt 5.6 will be the last release to suppo

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 23:23, Tomaz Canabrava wrote: >> >> http://lists.qt-project.org/pipermail/development/2015-June/022090.html >> >> CopperSpice is Qt fork discussed in the above thread: >> https://www.youtube.com/watch?v=LIiwBNvTllk >> >> i'm quickly skipping trough it ATM. >> these CopperSpic

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
http://lists.qt-project.org/pipermail/development/2015-July/022219.html On Mon, Nov 9, 2015 at 7:25 PM, Lubomir I. Ivanov wrote: > On 9 November 2015 at 23:23, Tomaz Canabrava wrote: > >> > >> http://lists.qt-project.org/pipermail/development/2015-June/022090.html > >> > >> CopperSpice is Qt fo

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 12:11:30 Dirk Hohndel wrote: > > > private: > > > PluginManager(); > > > > > > - PluginManager(const PluginManager&) = delete; > > > - PluginManager& operator=(const PluginManager&) = delete; > > > + PluginManager(const PluginManager&){}; > > >

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 19:33:55 Tomaz Canabrava wrote: > http://lists.qt-project.org/pipermail/development/2015-July/022219.html > > thiago's > > > > > answers made me stick with Qt side. > > > > links? is it in that same thread? That's a link to an email from Simon. I can't find my own ans

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 23:47, Thiago Macieira wrote: > On Monday 09 November 2015 19:33:55 Tomaz Canabrava wrote: >> http://lists.qt-project.org/pipermail/development/2015-July/022219.html > >> > thiago's >> > >> > > answers made me stick with Qt side. >> > >> > links? is it in that same thread? >

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 19:22:23 Tomaz Canabrava wrote: > it deletes the Copy Constructor and the operator=, if you don't declare > them the compiler will declare one anyhow. the way one does that in pre > c++11 is to declare an empty copy constructor and equal operator on the > private area, b

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Tuesday 10 November 2015 00:10:15 Lubomir I. Ivanov wrote: > constexpr specifically seems to have landed in msvc 2015 RTM. > http://blogs.msdn.com/b/vcblog/archive/2015/06/02/constexpr-complete-for-vs-> > 2015-rtm-c-11-compiler-c-17-stl.aspx Yeah, but it doesn't work. If you try Qt's tst_compi

Re: AppImage for testing

2015-11-09 Thread K. "pestophagous" Heller
I arrived late to this testing party. Just wanted to say that the AppImage is working great on: Debian 8 jessie with Xfce desktop. Linux 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u3 (2015-08-04) x86_64 GNU/Linux things that work: the marble globe printing editing planning [did not find any