editing a dive in Subsurface-mobile

2015-12-07 Thread Dirk Hohndel
I have a semi-working most definitely incorrect implementation. I checked it into master anyway because that seems like the best way to get someone who actually knows what they are doing to look at it and fix it :-) Here's how you can try it. Tap on a dive in the dive list. Then slide the control

Re: [pull request]: dive details rework

2015-12-07 Thread Dirk Hohndel
On Mon, Dec 07, 2015 at 06:47:49PM +, Sebastian Kügler wrote: > Please pull from g...@github.com:sebasje/subsurface.git > branch "divedetailssplit". Thank you. I'll do that over lunch :-) > The plan was to split up viewing and editing the dives in order to make > both modes work better for

[pull request]: dive details rework

2015-12-07 Thread Sebastian Kügler
Please pull from g...@github.com:sebasje/subsurface.git branch "divedetailssplit". The plan was to split up viewing and editing the dives in order to make both modes work better for their purpose. (For example, we don't need the huge profile picture in the edit mode, since it can't be edited, a

translations for 4.5.3

2015-12-07 Thread Dirk Hohndel
Turns out that there appear to be four new strings that need translations. None of them are horribly critical (all just error messages that most users should never see), but if you have a moment and would like to help make 4.5.3 even better in your language - please log into transifex and translate

Re: 4.5.3

2015-12-07 Thread Dirk Hohndel
... and once again learning to do things first, then post about them... On Mon, Dec 07, 2015 at 09:27:05AM -0800, Dirk Hohndel wrote: > > My usual approach for the dot releases is to pick things that are clearly > fixes plus small, self contained things that are clearly improvements but > appear

Re: 4.5.3

2015-12-07 Thread Dirk Hohndel
On Mon, Dec 07, 2015 at 06:38:21PM +0200, Lubomir I. Ivanov wrote: > On 7 December 2015 at 18:01, Miika Turkia wrote: > > > > > >> On 07 Dec 2015, at 17:55, Lubomir I. Ivanov wrote: > >> > >>> On 7 December 2015 at 17:45, Dirk Hohndel wrote: > >>> No comments from anyone? No nominations for addi

Re: 4.5.3

2015-12-07 Thread Lubomir I. Ivanov
On 7 December 2015 at 18:01, Miika Turkia wrote: > > >> On 07 Dec 2015, at 17:55, Lubomir I. Ivanov wrote: >> >>> On 7 December 2015 at 17:45, Dirk Hohndel wrote: >>> No comments from anyone? No nominations for additional commits? >> >> hmm, is cherry-picking really required - e.g. are there fea

Re: 4.5.3

2015-12-07 Thread Lubomir I. Ivanov
On 7 December 2015 at 17:45, Dirk Hohndel wrote: >> >> Lubomir I. Ivanov (4): >> subsurfacestartup.c: don't double free 'default_filename' >> NSIS: add a couple of uninstaller checkboxes the above needs: 5002fa4 PreferencesDialog.cpp: store 'default_directory' in QSettings but that's te

Re: 4.5.3

2015-12-07 Thread Miika Turkia
> On 07 Dec 2015, at 17:55, Lubomir I. Ivanov wrote: > >> On 7 December 2015 at 17:45, Dirk Hohndel wrote: >> No comments from anyone? No nominations for additional commits? > > hmm, is cherry-picking really required - e.g. are there features which > are WIP ATM? > why not include all commits

Re: 4.5.3

2015-12-07 Thread Lubomir I. Ivanov
On 7 December 2015 at 17:45, Dirk Hohndel wrote: > No comments from anyone? No nominations for additional commits? > hmm, is cherry-picking really required - e.g. are there features which are WIP ATM? why not include all commits between the last version and this one? lubomir -- _

Re: 4.5.3

2015-12-07 Thread Dirk Hohndel
No comments from anyone? No nominations for additional commits? /D > On Dec 6, 2015, at 9:42 AM, Dirk Hohndel wrote: > > On Sun, Dec 06, 2015 at 08:46:04AM -0800, Dirk Hohndel wrote: >> >>> On Dec 6, 2015, at 8:24 AM, Benjamin wrote: >>> >>> Are there new strings that need translation? >>>

Re: Subsurface mobile and the GPS service

2015-12-07 Thread Sebastian Kügler
On Saturday, December 05, 2015 06:23:39 AM Dirk Hohndel wrote: > > 1) When I activate Subsurface-mobile I get the screen on the left of the > > attached image. The button at the bottom allows me to drag the screen to > > the right, bringing up the middle screen in the attached image. Notice > > tha

Re: mobile ui todo

2015-12-07 Thread Sebastian Kügler
On Sunday, December 06, 2015 10:03:40 PM Lubomir I. Ivanov wrote: > On 3 December 2015 at 21:04, Sebastian Kügler wrote: > > Hey all, > > > > We received pretty useful feedback during the testing of the latest mobile > > ui changes. > i just tested quickly the mobile build and it seems that the