Re: TestFlight feedback for Subsurface-mobile.

2016-04-20 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 07:37:16AM +0200, HEMARD Bertrand wrote: > Missing ppo2 curve in the graph ;) We decided against showing the tech graphs on the mobile app. /D ___ subsurface mailing list subsurface@subsurface-divelog.org

TestFlight feedback for Subsurface-mobile.

2016-04-20 Thread HEMARD Bertrand
Missing ppo2 curve in the graph ;) App Information: App Name: Subsurface-mobile App Version: 1.0.5 (4.5.2.1289) Installed App Version: 1.0.5 (4.5.2.1283) Device Information: Device: iPhone4,1 iOS Version: 9.3.1 Language: fr-FR (français (France)) Carrier: SFR Timezone: UTC+2 Architecture:

Re: Better "make clean"? Or easier configuration?

2016-04-20 Thread Thiago Macieira
On quarta-feira, 20 de abril de 2016 16:31:13 PDT Linus Torvalds wrote: > There's no "distclean" or similar target, but I *can* basically just do > > ccmake . > > and just hit 'c' and 'g' to (re-)configure and generate, and that does > fix the problem. Also: make rebuild_cache --

Re: Better "make clean"? Or easier configuration?

2016-04-20 Thread Dirk Hohndel
> On Apr 20, 2016, at 5:35 PM, Tomaz Canabrava wrote: >mkdir build >cd build >cmake .. > > it will fail on grantlee. I'm not sure why. I get > > CMake Error at cmake/Modules/HandleFindGrantlee.cmake:10 (find_package): > By not providing

Re: Better "make clean"? Or easier configuration?

2016-04-20 Thread Tomaz Canabrava
On Wed, Apr 20, 2016 at 8:31 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > So Fedora just upgraded their qt version today (or at least recently). > > After that, building subsurface gets me > > make[2]: *** No rule to make target > '/usr/lib64/libQt5Concurrent.so.5.5.1', needed

Better "make clean"? Or easier configuration?

2016-04-20 Thread Linus Torvalds
So Fedora just upgraded their qt version today (or at least recently). After that, building subsurface gets me make[2]: *** No rule to make target '/usr/lib64/libQt5Concurrent.so.5.5.1', needed by 'subsurface'. Stop. Oops. Ok, I'll just do "make clean". That doesn't help, same error.

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 01:14:32PM -0700, Linus Torvalds wrote: > On Apr 20, 2016 12:48 PM, "Dirk Hohndel" wrote: > > > > Reading the patch the code makes sense and seems an improvement. I'm not > > in love with "int entry" since we have pi->entry (which is a pointer) to > >

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Linus Torvalds
On Apr 20, 2016 12:48 PM, "Dirk Hohndel" wrote: > > Reading the patch the code makes sense and seems an improvement. I'm not > in love with "int entry" since we have pi->entry (which is a pointer) to > confuse it with, but heck, I'm sure you had a good reason for picking that >

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 11:34:51AM -0700, Linus Torvalds wrote: > On Wed, Apr 20, 2016 at 11:00 AM, Dirk Hohndel wrote: > >> > >> If it's just the min/max arrays, let me fix that for you. I'll make > >> them indices instead of pointers. > > > > That's it indeed. And your fix

Re: SubsurfacePi report

2016-04-20 Thread Jeroen Massar
On 2016-04-18 16:16, Robert Helling wrote: [..] > I have the RPi acting as an access point and my iPhone connects to it > (and for example I can access the RPi’s web server with safari). It does > not yet boot into that state for unknown reasons, I still have to > ifconfig manually, but that

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Linus Torvalds
On Wed, Apr 20, 2016 at 11:00 AM, Dirk Hohndel wrote: >> >> If it's just the min/max arrays, let me fix that for you. I'll make >> them indices instead of pointers. > > That's it indeed. And your fix would be appreciated. Just make sure you > also fix the "consumer" of this over

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Tomaz Canabrava
On Wed, Apr 20, 2016 at 3:00 PM, Dirk Hohndel wrote: > On Wed, Apr 20, 2016 at 10:33:28AM -0700, Linus Torvalds wrote: > > On Wed, Apr 20, 2016 at 10:26 AM, Dirk Hohndel wrote: > > > > > > Oh boy... that data structure, umm, does not lend itself well to >

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 10:33:28AM -0700, Linus Torvalds wrote: > On Wed, Apr 20, 2016 at 10:26 AM, Dirk Hohndel wrote: > > > > Oh boy... that data structure, umm, does not lend itself well to copying. > > It interenally has pointers into itself. Yikes. I'll try to fix this. >

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Linus Torvalds
On Wed, Apr 20, 2016 at 10:26 AM, Dirk Hohndel wrote: > > Oh boy... that data structure, umm, does not lend itself well to copying. > It interenally has pointers into itself. Yikes. I'll try to fix this. If it's just the min/max arrays, let me fix that for you. I'll make them

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 09:38:06AM -0700, Dirk Hohndel wrote: > On Wed, Apr 20, 2016 at 06:07:50PM +0200, Robert Helling wrote: > > Hi, > > > > > On 20.04.2016, at 17:39, Robert Helling wrote: > > > > > > But it is far from obvious how that would cause the problem. > > > >

Re: Subsurface-mobile -- make offline the default?

2016-04-20 Thread Dirk Hohndel
On Mon, Apr 18, 2016 at 12:59:59PM -0700, Dirk Hohndel wrote: > Apparently the attempts to be smart about synchronizing with the cloud can > cause crashes both on Android and iOS. This is such a massive pain. The > easiest solution I can come up with right now... how about I turn of the > whole

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
On Wed, Apr 20, 2016 at 06:07:50PM +0200, Robert Helling wrote: > Hi, > > > On 20.04.2016, at 17:39, Robert Helling wrote: > > > > But it is far from obvious how that would cause the problem. > > > I still have no idea what is going on. It is the hunk > > @@ -179,7

Re: 4.5.6 plans

2016-04-20 Thread Miika Turkia
My git sync is borken on the desktop application. Works just fine on mobile clients, but desktop just cannot open the cloud storage. I am trying to debug it, and might make sense to wait a bit for the release to see if this is something that others might run into as well. miika

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Tomaz Canabrava
On Wed, Apr 20, 2016 at 11:52 AM, Dirk Hohndel wrote: > > On Apr 20, 2016, at 7:49 AM, Tomaz Canabrava wrote: > > > > On Wed, Apr 20, 2016 at 11:44 AM, Dirk Hohndel wrote: > >> So this is code that many of you know... could someone try to

Re: TestFlight feedback for Subsurface-mobile.

2016-04-20 Thread Dirk Hohndel
> On Apr 19, 2016, at 10:41 PM, Benjamin Nauck wrote: > > Synchronizing with (empty?) cloud removes dive log. > > 1. Add Dive manually > > 2. Hit save > 3. Manually sync with cloud > > 4. Wait for it to sync > 5. The log is now removed > Hmm. We try to prevent

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
> On Apr 20, 2016, at 7:49 AM, Tomaz Canabrava wrote: > > > > On Wed, Apr 20, 2016 at 11:44 AM, Dirk Hohndel > wrote: > So this is code that many of you know... could someone try to figure out > why those depth values

Re: What happened to the depth being shown on profile?

2016-04-20 Thread Tomaz Canabrava
On Wed, Apr 20, 2016 at 11:44 AM, Dirk Hohndel wrote: > So this is code that many of you know... could someone try to figure out > why those depth values disappeared? > Strange that nobody touched that in quite a while. I'll bisect it today.

Fwd: What happened to the depth being shown on profile?

2016-04-20 Thread Dirk Hohndel
So this is code that many of you know... could someone try to figure out why those depth values disappeared? /D > Begin forwarded message: > > From: Dirk Hohndel > Subject: Re: What happened to the depth being shown on profile? > Date: April 19, 2016 at 10:38:03 PM PDT > To:

Re: 4.5.6 plans

2016-04-20 Thread Rick Walsh
On 20 April 2016 at 17:30, Steve wrote: > > > On Apr 19, 2016, at 4:40 PM, Steve > wrote: > > > > Just tested with both the Petrel and OSTC3+ with the Bluetooth > > download > mode with this build. > > Petrel worked fine. > >

RE: 4.5.6 plans

2016-04-20 Thread Steve
> On Apr 19, 2016, at 4:40 PM, Steve wrote: > > Just tested with both the Petrel and OSTC3+ with the Bluetooth > download mode with this build. > Petrel worked fine. > Ostc3+ (firmware 2.03) still crashes subsurface. Please re-download (sorry, same version

RE: 4.5.6 plans

2016-04-20 Thread Steve
> On Apr 19, 2016, at 4:40 PM, Steve wrote: > > Just tested with both the Petrel and OSTC3+ with the Bluetooth download mode with this build. > Petrel worked fine. > Ostc3+ (firmware 2.03) still crashes subsurface. Please re-download (sorry, same version number