On sexta-feira, 1 de julho de 2016 11:04:32 PDT Robert Helling wrote:
> Hi,
>
> > Am 23.06.2016 um 06:21 schrieb Robert C. Helling
> > :
> >
> > Thanks for those comments. Will send an updated patch.
>
> here is the updated patch.
Everything looks right, thanks
On 30/06/2016 21:53, Anton Lundin wrote:
You're not on latest master.
You're missing 2c60e87b09f8bbef8031622cf3537b954809a829
//Anton
Thanks, that was very useful. The build process gets much further along
than previously.
However, there is still an error with the latest master. Looks for
Hi,Am 23.06.2016 um 06:21 schrieb Robert C. Helling :Thanks for those comments. Will send an updated patch. here is the updated patch.From 01eb7dc4e15750a8f8b36f54f8aaadc5ee1a49b2 Mon Sep 17 00:00:00 2001
From: "Robert C. Helling"
Date: Wed, 22 Jun
Add option to calculate the best mix portion of O2 and He for the dive's max
depth if the user enters * in the MOD and MND cylinder fields. Gas portions
are automatically recalculated if the max depth of the dive changes.
Signed-off-by: Rick Walsh
---
core/dive.h
Adds fields to the planner cylinder model for maximum operating depth (MOD)
for a bottom mix gas, and maximum narcotic depth (MND). Fields are read/write,
so changing MOD changes %O2 and vice-versa. Changing MND changes %He and
vice-versa.
When setting MOD directly, the %O2 is truncated (rounded
Signed-off-by: Rick Walsh
---
desktop-widgets/diveplanner.cpp | 3 +++
qt-models/cylindermodel.cpp | 7 ---
qt-models/cylindermodel.h | 2 +-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/desktop-widgets/diveplanner.cpp
Signed-off-by: Rick Walsh
---
core/dive.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/core/dive.h b/core/dive.h
index 5988990..6910eb2 100644
--- a/core/dive.h
+++ b/core/dive.h
@@ -481,6 +481,17 @@ static inline depth_t gas_mod(struct gasmix *mix,
We can't have >100% O2
Signed-off-by: Rick Walsh
---
core/dive.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/core/dive.c b/core/dive.c
index 29198af..58c5266 100644
--- a/core/dive.c
+++ b/core/dive.c
@@ -3653,6 +3653,9 @@ fraction_t best_o2(depth_t depth,
This patch series implements Robert's suggestion for best mix calculations. It
builds on what I did previously and is in master now.
He said it best in his email in May
http://lists.subsurface-divelog.org/pipermail/subsurface/2016-May/025699.html
Maybe that is the best option: Add two columns