Re: Default tank size

2017-07-27 Thread Joakim Bygdell
On 27 Jul 2017 11:55 p.m., "John Griffiths" wrote: That is my issue. I'd like for the default to be my HP120. You could use the metric variant of your cylinder as default, 15L 232bar. Sent from my android device. -Original Message- From: Joakim Bygdell

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
Dirk, Thank you. Good to know about the Git repository. And I do think Subsurface is a superior project. John Sent from my android device. -Original Message- From: Dirk Hohndel To: John Griffiths Cc: Subsurface Mailing List

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 6:23 PM, Dirk Hohndel wrote: >> >> I will consider my options. If I can store locally as well as syncing to >> your server, then I will probably do so. > > Yes it does. The way our remote storage works is that it keeps all of the > data in a git

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 6:14 PM, John Griffiths wrote: > > Dirk, > > I appreciate all you have written. And yes, I know Internet privacy is a > total illusion. I also appreciate that you wrote most, if not all, of the > code. I have written my share of this code,

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 28 July 2017 at 04:07, Dirk Hohndel wrote: > > I have done a somewhat coarse review of the code. A few minuscule complaints, > mostly about commit message formatting and random white space and coding > style things, but nothing of substance that I noticed reading the code. >

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
Dirk, I appreciate all you have written. And yes, I know Internet privacy is a total illusion. I also appreciate that you wrote most, if not all, of the code. I was in IT for 30 plus years. Java programmer and C and C++ before that. Oracle DBA, sql, etc, etc. I know what you have written is

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
I have done a somewhat coarse review of the code. A few minuscule complaints, mostly about commit message formatting and random white space and coding style things, but nothing of substance that I noticed reading the code. I think I'll pull this today (just waiting for a note from Lubomir that

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
The cloud data is not mined, there is no cost, there are no ads, no one has access to your data with the exception of me, and I have never accessed any of those data without first getting explicit invitation to look by the owner (which usually happens when I'm trying to help someone recover

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
True. I have not. So the gist is the web service and the cloud server are independent. In order to use Subsurface-mobile, I have upload all my dive data to a server. Or I can continue to use local storage and the companion app. I know there is no such thing as privacy anymore, but I like to

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
On the desktop you need to actually store your dives to the cloud server. Obviously our server cannot see the files that are stored locally on your computer. Enter the cloud credentials in the preferences and use File->Save to cloud storage /D > On Jul 27, 2017, at 4:40 PM, John Griffiths

Re: Subsurface-mobile

2017-07-27 Thread Miika Turkia
Have you saved the dives to cloud from subsurface desktop? Sounds like you might ne saving to local file only. > On 27 Jul 2017, at 16.40, John Griffiths wrote: > > I use Subsurface desktop to store my dives. > > When I log in following the link using the email and

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 4:07 PM, Lubomir I. Ivanov wrote: > > On 28 July 2017 at 01:54, Dirk Hohndel wrote: >>> >>> The best thing about this map widget is that it can be used for both >>> the mobile and desktop versions. The mobile version support is not

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
I use Subsurface desktop to store my dives. When I log in following the link using the email and password, I get: Not Found The requested URL /user/stuff.jr...@grifent.com/dives.html was not found on this server. Apache/2.4.25 (Ubuntu) Server at cloud.subsurface-divelog.org Port 443 John

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 28 July 2017 at 02:12, Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 4:03 PM, Lubomir I. Ivanov > wrote: >> >> it does this in a similar way to the Marble Globe class ATM. >> if zoomed out enough, it calculates a "small-circle" and many

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
The Subsurface Storage Server and the webservice are completely unrelated. How are you storing the dives on your desktop? Can you see them when you log into https://cloud.subsurface-divelog.org ? /D > On Jul 27, 2017, at 4:11 PM, John Griffiths wrote: > > Help. > > I

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 3:56 PM, Dirk Hohndel wrote: > > >> On Jul 27, 2017, at 2:09 PM, Linus Torvalds >> wrote: >> >> On Thu, Jul 27, 2017 at 1:18 PM, Dirk Hohndel wrote: >>> >>> Please just resend it with the commit

Re: QtLocation map updates

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 4:03 PM, Lubomir I. Ivanov wrote: > > it does this in a similar way to the Marble Globe class ATM. > if zoomed out enough, it calculates a "small-circle" and many dives > can be selected by a single click over a single one of them. Yeah, the approach

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
Help. I installed Subsurface-mobile. It asked for my email and password and then sent me a PIN. Problem is none of my dives are populated. When I first started using Subsurface, I got a user name / password and a user ID. The user ID still works and retrieves my dives. I read the user manual

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 28 July 2017 at 02:07, Dirk Hohndel wrote: > >> On Jul 27, 2017, at 3:59 PM, Lubomir I. Ivanov wrote: >> >> it seems to commonly happen near the 2 higher zoom levels (18,19): >> - minimum is 1.7 (whole globe visible) >> - maximum is 19 >> >> so maybe a

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 3:59 PM, Lubomir I. Ivanov wrote: > > it seems to commonly happen near the 2 higher zoom levels (18,19): > - minimum is 1.7 (whole globe visible) > - maximum is 19 > > so maybe a maximum zoom clamp of 17 is a good idea, but this way the > 18,19 levels

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 28 July 2017 at 01:56, Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 3:47 PM, Linus Torvalds > wrote: >> >> Talking about zooming - is there a setting to just move quickly from one >> dive site >> to another without the

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 28 July 2017 at 01:47, Linus Torvalds wrote: > > I tried it out. > > Looks fine to me. I did notice one issue: when you zoom in far enough, the > satellite data goes away, and it says "map data not available". > > > I suspect it might depend on location - some

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 3:56 PM, Linus Torvalds > wrote: > > On Thu, Jul 27, 2017 at 3:47 PM, Linus Torvalds > wrote: >> >> Talking about zooming - is there a setting to just move quickly from one >> dive site >> to another without

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 2:09 PM, Linus Torvalds > wrote: > > On Thu, Jul 27, 2017 at 1:18 PM, Dirk Hohndel wrote: >> >> Please just resend it with the commit message of your choice >> and an SOB and I'll create new builds > > Done. Used mostly

Re: QtLocation map updates

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 3:47 PM, Linus Torvalds wrote: > > Talking about zooming - is there a setting to just move quickly from one dive > site > to another without the zoom-out-zoom-in? Side note, while on the subject of features that would be cool: - when

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 3:32 PM, Lubomir I. Ivanov wrote: > > On 27 July 2017 at 19:26, Lubomir I. Ivanov wrote: >> >> so, everything is pretty much in place including editing > > pull request made: >

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 27 July 2017 at 19:26, Lubomir I. Ivanov wrote: > > so, everything is pretty much in place including editing pull request made: https://github.com/Subsurface-divelog/subsurface/pull/516 --- This is a side-by-side implementation of the

Re: Default tank size

2017-07-27 Thread John Griffiths
That is my issue. I'd like for the default to be my HP120. Sent from my android device. -Original Message- From: Joakim Bygdell To: Dirk Hohndel Cc: John Griffiths , Subsurface Mailing List

Re: Testing cloud account creation

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 1:34 PM, Jan Mulder wrote: > > On 26-07-17 22:36, Jan Mulder wrote: >> On 26-07-17 20:35, Jan Mulder wrote: Mobile app session 2) - start a new mobile session - to my surprise, the credentials page is shown. Already filled in

[PATCH] Profile support for multiple concurrent pressure sensors

2017-07-27 Thread Linus Torvalds
From: Linus Torvalds Date: Thu, 27 Jul 2017 10:17:05 -0700 Subject: [PATCH] Profile support for multiple concurrent pressure sensors This finally handles multiple cylinder pressures, both overlapping and consecutive, and it seems to work on the nasty cases I've

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 1:18 PM, Dirk Hohndel wrote: > > Please just resend it with the commit message of your choice > and an SOB and I'll create new builds Done. Used mostly the explanation email with minor tweaks. Linus

Re: Testing cloud account creation

2017-07-27 Thread Jan Mulder
On 26-07-17 22:36, Jan Mulder wrote: On 26-07-17 20:35, Jan Mulder wrote: Mobile app session 2) - start a new mobile session - to my surprise, the credentials page is shown. Already filled in email/passwd and the "log shows loading dives from cache failed" - tried the save icon. Nothing

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 12:43 PM, Linus Torvalds > wrote: > > On Thu, Jul 27, 2017 at 11:31 AM, Dirk Hohndel wrote: >> >> So far I haven't seen any substantial feedback on your code changes, >> I'm hoping to get a few more people to actually

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 12:43 PM, Linus Torvalds wrote: > > Also, there are a few things that never worked and that I'd like to > make work, like just making the "Info window" show all the pressures > that we're tracking at that point. Right now it only shows the

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 11:31 AM, Dirk Hohndel wrote: > > So far I haven't seen any substantial feedback on your code changes, > I'm hoping to get a few more people to actually read through the patch... I'd like more people to look at it, but at the same time I suspect they

Re: Default tank size

2017-07-27 Thread Joakim Bygdell
On 27 July 2017 at 21:25, Dirk Hohndel wrote: > Yes, once any of your dives contain such a cylinder, so once you have > added a custom > cylinder for the first time, it will be available as an auto-complete item > in the drop down. > > /D > > When you edit a dive, yes. But it

Re: Default tank size

2017-07-27 Thread Dirk Hohndel
Yes, once any of your dives contain such a cylinder, so once you have added a custom cylinder for the first time, it will be available as an auto-complete item in the drop down. /D > On Jul 27, 2017, at 12:24 PM, John Griffiths wrote: > > Add it where? I don't see an

Re: Default tank size

2017-07-27 Thread John Griffiths
Add it where? I don't see an "add" except in the actual dive notes tab. Is that of where you are speaking? John On 07/27/2017 03:06 PM, Dirk Hohndel wrote: > Once you add it as a 15.3 liter tank (please do NOT add it as 120cuft tank as > that would > result in incorrect data) with HP120 as

Re: Default tank size

2017-07-27 Thread John Griffiths
That is true. but it is still not the default. John On 07/27/2017 03:08 PM, Joakim Bygdell wrote: > On 27 July 2017 at 21:06, Dirk Hohndel > wrote: > > Once you add it as a 15.3 liter tank (please do NOT add it as > 120cuft tank as that would

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 12:20 PM, John Griffiths wrote: > > But for those that got the companion app when it was the only app, there > is no reason to go back to Google to see the warning. Very good point. /D ___ subsurface

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 12:07 PM, Dirk Hohndel wrote: > > >> On Jul 27, 2017, at 12:03 PM, John Griffiths wrote: >> >> Ah. Thank you! >> >> I thought the app I got off of Google Play was the correct App. >> >> Sorry for the confusion. > > Frankly,

Re: Default tank size

2017-07-27 Thread Joakim Bygdell
On 27 July 2017 at 21:06, Dirk Hohndel wrote: > Once you add it as a 15.3 liter tank (please do NOT add it as 120cuft tank > as that would > result in incorrect data) with HP120 as name, the next time you start > Subsurface it SHOULD > offer that as one of the options in the

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 12:03 PM, John Griffiths wrote: > > Ah. Thank you! > > I thought the app I got off of Google Play was the correct App. > > Sorry for the confusion. Frankly, the confusion is my fault. When the companion app was first conceived I was convinced

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
Ah. Thank you! I thought the app I got off of Google Play was the correct App. Sorry for the confusion. John On 07/27/2017 02:58 PM, Dirk Hohndel wrote: >> On Jul 27, 2017, at 11:54 AM, John Griffiths wrote: >> >> I just dove yesterday. I added a dive using the

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 11:54 AM, John Griffiths wrote: > > I just dove yesterday. I added a dive using the Android app. I did not > have the correct name so since it was the first site we dove for lobster > season, I called it "lobster 1." Later, I found that we were

Re: Subsurface-mobile

2017-07-27 Thread John Griffiths
I just dove yesterday. I added a dive using the Android app. I did not have the correct name so since it was the first site we dove for lobster season, I called it "lobster 1." Later, I found that we were diving on Anglin Pier Reef. I checked my dives on the web site and saw the dive "lobster 1"

Re: QtLocation map updates

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 9:26 AM, Lubomir I. Ivanov wrote: > > On 23 July 2017 at 04:13, Lubomir I. Ivanov wrote: >> On 23 July 2017 at 03:58, Dirk Hohndel wrote: >>> I don't know if I asked before... can the flags be labeled? Dive site

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
> On Jul 27, 2017, at 10:22 AM, Linus Torvalds > wrote: > > On Thu, Jul 27, 2017 at 1:59 AM, Robert Helling wrote: >> >> do I understand you correctly that with multiple sensors, we would give up >> to try to determine which gas the diver is

Re: Subsurface-mobile

2017-07-27 Thread Dirk Hohndel
Hi John, I'm trying to understand your problem, but am not sure what exactly is going wrong. The cloud sync between desktop and mobile is indeed bidirectional. I have found one situation where this currently breaks (if you have automatic trips on the desktop and a matching dive on mobile that is

Re: Subsurface-mobile

2017-07-27 Thread Willem Ferguson
On 27/07/2017 19:36, John Griffiths wrote: I use the Subsurface mobile app for Android. There is an enhancement that would make it more useful in my opinion. Often, the name of the dive site is not given to or obtained by me until after the dive. I have to use some made up site name. It would

Subsurface-mobile

2017-07-27 Thread John Griffiths
I use the Subsurface mobile app for Android. There is an enhancement that would make it more useful in my opinion. Often, the name of the dive site is not given to or obtained by me until after the dive. I have to use some made up site name. It would be nice if a dive could be selected in the app

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Linus Torvalds
On Thu, Jul 27, 2017 at 1:59 AM, Robert Helling wrote: > > do I understand you correctly that with multiple sensors, we would give up > to try to determine which gas the diver is breathing (at a given time)? No, we can definitely do it, it's just that the C++ model that does

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 27 July 2017 at 19:26, Lubomir I. Ivanov wrote: > On 23 July 2017 at 04:13, Lubomir I. Ivanov wrote: >> On 23 July 2017 at 03:58, Dirk Hohndel wrote: >>> I don't know if I asked before... can the flags be labeled? Dive site name?

Re: QtLocation map updates

2017-07-27 Thread Lubomir I. Ivanov
On 23 July 2017 at 04:13, Lubomir I. Ivanov wrote: > On 23 July 2017 at 03:58, Dirk Hohndel wrote: >> I don't know if I asked before... can the flags be labeled? Dive site name? >> > > yes, i will add the labels soon. > so, everything is pretty much in

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
On Wed, Jul 26, 2017 at 09:57:27PM -0700, Linus Torvalds wrote: > Anyway, without further ado, here's the patch. No sign-off yet, because I > do think people should look and comment. But I think the patch is fine, > and I'll fix anythign that anybody can find, *except* for that TankItem > thing

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Dirk Hohndel
On Wed, Jul 26, 2017 at 09:57:27PM -0700, Linus Torvalds wrote: > > Ok, I've actually spent a fair amount of time on this patch, and it > actually seems to work. Always a plus. > It really handles multiple cylinder pressures, both overlapping and > consecutive, and it seems to work on the

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Linus Torvalds
On Jul 27, 2017 00:44, "Robert Helling" wrote: As I said, I haven’t looked at the code. But from what I would expect to see as the user would be that the TankItem for a given moment in time should report the gas whose pressure has most recently changed That doesn't work.

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Rick Walsh
On 27 July 2017 at 17:44, Robert Helling wrote: > Hi, > > a few quick comments from my side (without looking at the actual code): > > On 27. Jul 2017, at 06:57, Linus Torvalds > wrote: > > > So the only _known_ breakage is the "TankItem"

Re: Real support for multiple concurrent sensors..

2017-07-27 Thread Robert Helling
Hi, a few quick comments from my side (without looking at the actual code): > On 27. Jul 2017, at 06:57, Linus Torvalds > wrote: > > - actually make the "struct plot_info" have all the cylinder pressures > (so no "sensor index and pressure" - every cylinder