Re: [BUG]: stray dive-sites after parsing ssrf/xml

2017-11-07 Thread Willem Ferguson
On 07/11/2017 22:50, Lubomir I. Ivanov wrote: i need some decision making here: - should we discard these at the parsing stage? - should we discard this at the saving stage? - should the map widget *ignore* such dive sites that are not linked to dives and not create markers for them? - should

[BUG]: stray dive-sites after parsing ssrf/xml

2017-11-07 Thread Lubomir I. Ivanov
Dennis Hansen has reported a bug at the google groups forum and then reported the same issue at Github: https://github.com/Subsurface-divelog/subsurface/issues/786 the SSRF file he provided has some dive sites without names and no dives are using them: -- ...snip... ...

Re: AppImages and continuous integration

2017-11-07 Thread Dirk Hohndel
> On Nov 6, 2017, at 10:33 PM, Dirk Hohndel wrote: > > Version numbers are FUN with this one. I'm working on that. That part should be fixed now. The additional tag that we keep inserting and moving on GitHub in order to create the builds for the latest push/merge was

Re: AppImages and continuous integration

2017-11-07 Thread Dirk Hohndel
> On Nov 6, 2017, at 11:51 PM, Guillaume Gardet > wrote: >> I have now tested this and can confirm your observation :-( >> >> With a local build binary I get >> >> Requesting connect on the social network >> subsurface.facebook: Current url call >>