Re: [Subsurface-divelog/subsurface] Don't show cylinder pressure graph for wrong dc for merged dives (#815)

On Thu, Nov 16, 2017 at 6:05 PM, Linus Torvalds wrote: > > Something like the attached three patches? Or the github pull request I did. I tried to do the "mention" thing with Stefan too. Maybe I screwed something up. I don't ever really use github.

Re: [Subsurface-divelog/subsurface] Don't show cylinder pressure graph for wrong dc for merged dives (#815)

On Thu, Nov 16, 2017 at 6:05 PM, Linus Torvalds wrote: > > NOTE! Untested. And it's not smaller than your patch. I just think > it's a bit more explicit about what it does, and thus maybe clearer. By "untested" I mean that I have built it and have actually used it

Re: [Subsurface-divelog/subsurface] Don't show cylinder pressure graph for wrong dc for merged dives (#815)

On Thu, Nov 16, 2017 at 7:25 AM, Stefan Fuchs wrote: > > Hi Linus, hi everybody, Hmm. That code is a bit too confusing, and I think the proposed change isn't wrong, but it makes that "too confusing" part worse. For example, you do this: if (!has_gaschange_event(dive,

Re: Scubapro Aladin Square

On Thu, Nov 16, 2017 at 3:05 PM, Linus Torvalds wrote: > > Very good. I will try to come up with a better model for the whole USB > ID selection (because I suspect we'll have a few more models show up > eventually), but that should be trivial. I'll probably just

Re: Scubapro Aladin Square

On Thu, Nov 16, 2017 at 2:44 PM, vavincavent wrote: > > In my local files it's ok for downloading and analysing of the dives! > > You'll find attached the files i've change. Very good. I will try to come up with a better model for the whole USB ID selection (because I

Re: mobile: android splash screen (and issue 513) opacity weirdness

On 16 November 2017 at 23:06, Jan Mulder wrote: > While investigating issue #513 ([Bug] Mobile: Startup splash screens display > 2 different background color (Black then White) I found the commit that > introduces this splash screen stuff (04e994b57558ed9). First, let me reset

mobile: android splash screen (and issue 513) opacity weirdness

While investigating issue #513 ([Bug] Mobile: Startup splash screens display 2 different background color (Black then White) I found the commit that introduces this splash screen stuff (04e994b57558ed9). First, let me reset the complexity on GitHub from low to high :-) as the issue is related

Re: please test latest master

Rick, On 14-11-17 11:45, Jan Mulder wrote: On 14-11-17 11:34, Rick Walsh wrote:     Also, better icon size for the profile on Subsurface-mobile. I tested your 4.7.4.2-arm apk, but the gas switch icon is still as tiny as before. Is that the right binary? highly likely not the right APK ...

Re: Scubapro Aladin Square

On Wed, Nov 15, 2017 at 10:20 PM, vavincavent wrote: > > In libdivecomputer library, we have 2 branches (libdivecomputer and > libdc). One is with uwatec_g2.c and the other with scubapro_g2.c. > Can you explain me the difference and wich one is the better for me? The only

Re: [Subsurface-divelog/subsurface] Don't show cylinder pressure graph for wrong dc for merged dives (#815)

Hi Linus, hi everybody, Am 16.11.2017 um 16:21 schrieb Lubomir I. Ivanov: > > hi, @sfuchs79 can you please ping Linus > and the ML about this? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub >

Re: Scubapro Aladin Square

On Thu, Nov 16, 2017 at 07:20:40AM +0100, vavincavent wrote: > > In libdivecomputer library, we have 2 branches (libdivecomputer and > libdc). One is with uwatec_g2.c and the other with scubapro_g2.c. > Can you explain me the difference and wich one is the better for me? libdivecomputer at

Re: Documentation change "mechanics" at Github

On 16 November 2017 at 16:41, Lubomir I. Ivanov wrote: > hi, Willem and all. > > today we've added a 'needs-documentation-change' label at Github. > also, Pull Request will now have a "Documentation change" section > after this update is approved: >

Documentation change "mechanics" at Github

hi, Willem and all. today we've added a 'needs-documentation-change' label at Github. also, Pull Request will now have a "Documentation change" section after this update is approved: https://github.com/Subsurface-divelog/subsurface/pull/823 so basically, for those editing the docs you can browse

Re: Warning: Major construction work on planner ongoing

On Thu, Nov 16, 2017 at 3:00 PM, Robert Helling wrote: > Hi, > > I wish I wouldn’t have to write this message but could rather send a PR… > > I have started work to make the planner thread save so we could plan in > the background without holding up the UI. This of course means

Warning: Major construction work on planner ongoing

Hi, I wish I wouldn’t have to write this message but could rather send a PR… I have started work to make the planner thread save so we could plan in the background without holding up the UI. This of course means that it should not keep stuff in global variables but that each instance should

Could you add a new cylinder in the main cylinder list?

Could you please add a D7 200 bar to the main cylinder list? I know: I can add a new cylinder by myself and this will be there for future use... Actually I use always the same custom cylinder and I cannot exploit the "default cylinder" in user preferences menu. I filed an improvement request

Re: Problem accessing cloud behind a proxy

On 15 November 2017 at 17:12, Lubomir I. Ivanov wrote: > this is from: > >> rename of >> C:\Users\ddebenedictis\AppData\Roaming\Subsurface/cloudstorage/29fc20f013e9f1fb >> to >> "C:\\Users\\ddebenedictis\\AppData\\Roaming\\Subsurface/cloudstorage/29fc20f013e9f1fb.1" >>