Re: Any brave dive computer download testers out there?

2018-04-24 Thread Sébastien Dugué
On Mon, Apr 23, 2018 at 7:07 PM, Linus Torvalds wrote: > On Mon, Apr 23, 2018 at 12:56 AM, Sébastien Dugué > wrote: >> On Sun, Apr 22, 2018 at 10:09 PM, Linus Torvalds >> wrote: >>> >>> It still has the exact same problem it always had: it's random binary data >>> that we'd have to encode some w

Re: Any brave dive computer download testers out there?

2018-04-24 Thread Linus Torvalds
On Tue, Apr 24, 2018 at 5:27 AM, Sébastien Dugué wrote: > On Mon, Apr 23, 2018 at 7:07 PM, Linus Torvalds > wrote: >> >> On most dive computers, it's 4 bytes, on others it's 5-6, and on some >> it's 16 bytes of random binary data. > > My bad, I assumed that feature was only present in the Uwat

Re: Any brave dive computer download testers out there?

2018-04-24 Thread Willem Ferguson
I thought I should attach the log of my BT download from a Petrel 2. Initial handshaking took maybe 40s, showing error message in red bar at bottom of screen "Timeout" But, if not interrupted, the download proceeded perfectly shortly after the timeout message and download exited normally on

Re: Any brave dive computer download testers out there?

2018-04-24 Thread Linus Torvalds
On Tue, Apr 24, 2018 at 11:03 AM, Willem Ferguson wrote: > > Initial handshaking took maybe 40s, showing error message in red bar at > bottom of screen "Timeout" Hmm. It looks like it first tried to do a BLE download, and that failed (and this is what took a longish time). And then because of th

Re: Any brave dive computer download testers out there?

2018-04-24 Thread Willem Ferguson
On 24/04/2018 20:08, Linus Torvalds wrote: On Tue, Apr 24, 2018 at 11:03 AM, Willem Ferguson wrote: Initial handshaking took maybe 40s, showing error message in red bar at bottom of screen "Timeout" Hmm. It looks like it first tried to do a BLE download, and that failed (and this is what took

Fwd: Re: Any brave dive computer download testers out there?

2018-04-24 Thread Willem Ferguson
On 24/04/2018 20:08, Linus Torvalds wrote: On Tue, Apr 24, 2018 at 11:03 AM, Willem Ferguson wrote: Initial handshaking took maybe 40s, showing error message in red bar at bottom of screen "Timeout" Hmm. It looks like it first tried to do a BLE download, and that failed (and this is what too

Re: Any brave dive computer download testers out there?

2018-04-24 Thread Linus Torvalds
On Tue, Apr 24, 2018 at 11:25 AM, Willem Ferguson wrote: > > I did the same download by setting the dropdown option in the BT setup panel > to 'Force Classical'. The new code just ignores the classic/ble/auto setting right now. I'd rather do it using the "dc_transports" model that we now use for

Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Linus Torvalds
Ok, I finally got around to cleaning up my subsurface changes, and there is now a newly rebased libdivecomputer-NG branch at git://github.com/torvalds/subsurface-for-dirk.git libdivecomputer-NG that I think is in good enough shape to be pulled. That branch has the same requirement on the "Sub

Travis now build-checks iOS

2018-04-24 Thread Dirk Hohndel
This was the one missing platform, I finally beat it into submission. It’s only compiling for the simulator (because for insane reasons you have to have a signing key available in order to build for device), but that should be sufficient to ensure that we don’t break the build… /D __

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Dirk Hohndel
> On Apr 24, 2018, at 12:53 PM, Linus Torvalds > wrote: > > Ok, I finally got around to cleaning up my subsurface changes, and > there is now a newly rebased libdivecomputer-NG branch at > > git://github.com/torvalds/subsurface-for-dirk.git libdivecomputer-NG Excellent - I’ve been waiting f

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Linus Torvalds
On Tue, Apr 24, 2018 at 5:11 PM, Dirk Hohndel wrote: >> >> Dirk - up to you. And obviously, I don't know when you want to cut >> over to the new libdivecomputer world order. > > I’m happy to do it now - but for libdivecomputer I’m always a bit > gun shy, so I’d prefer that you did the rebasing and

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Dirk Hohndel
> On Apr 24, 2018, at 5:43 PM, Linus Torvalds > wrote: > > On Tue, Apr 24, 2018 at 5:11 PM, Dirk Hohndel wrote: >>> >>> Dirk - up to you. And obviously, I don't know when you want to cut >>> over to the new libdivecomputer world order. >> >> I’m happy to do it now - but for libdivecomputer I

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Linus Torvalds
On Tue, Apr 24, 2018 at 5:43 PM, Linus Torvalds wrote: > NOTE! I have *not* updated the 'libdivecomputer' subproject in the > subsurface repository to point to that version of libdivecomputer. I > still build them as separate projects, and particularly when I was > rebasing, I didn't want to tie t

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Dirk Hohndel
> On Apr 24, 2018, at 5:58 PM, Linus Torvalds > wrote: > > On Tue, Apr 24, 2018 at 5:43 PM, Linus Torvalds > wrote: >> NOTE! I have *not* updated the 'libdivecomputer' subproject in the >> subsurface repository to point to that version of libdivecomputer. I >> still build them as separate proj

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Dirk Hohndel
> On Apr 24, 2018, at 5:59 PM, Dirk Hohndel wrote: >> >> Oh, and I realized that I should also mention that I didn't apply your >> fixes. I (obviously) had no test coverage for them, but they all >> looked fine. >> >> So you'll need to cherry pick or rebase your transport patches and the >> And

Re: Cleaned up and rebased "libdivecomputer-NG" branch

2018-04-24 Thread Dirk Hohndel
> On Apr 24, 2018, at 6:04 PM, Dirk Hohndel wrote: > > >> On Apr 24, 2018, at 5:59 PM, Dirk Hohndel wrote: >>> >>> Oh, and I realized that I should also mention that I didn't apply your >>> fixes. I (obviously) had no test coverage for them, but they all >>> looked fine. >>> >>> So you'll ne

Re: Travis now build-checks iOS

2018-04-24 Thread Anton Lundin
On 24 April, 2018 - Dirk Hohndel wrote: > This was the one missing platform, I finally beat it into submission. > It’s only compiling for the simulator (because for insane reasons you have to > have a signing key available in order to build for device), but that should > be sufficient to ensure