Re: [PATCH] OSTCTools - Resource leaks

20, 2015 at 01:15:10PM -0300, Marcos Cardinot wrote: > > From 978e2f3281dbd846c61980c00732b1d1bdea932c Mon Sep 17 00:00:00 2001 > > From: Marcos CARDINOT > > Date: Mon, 20 Apr 2015 13:05:14 -0300 > > Subject: [PATCH] ostctools - resource leaks > > > > some reso

[PATCH] OSTCTools - Resource leaks

>From 978e2f3281dbd846c61980c00732b1d1bdea932c Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Mon, 20 Apr 2015 13:05:14 -0300 Subject: [PATCH] ostctools - resource leaks some resources are not being freed. Signed-off-by: Marcos CARDINOT --- ostctools.c | 3 +++ 1 file changed

Re: GSoC 2015 - Introduction

2015-03-26 11:55 GMT-03:00 Martin Long : > > >> Actually, the type/category stuff will be essential to make Subsurface >> aware when some specific field is required... eg. is it a camera? so, let's >> include a field to store the resolution (of course, it's just an example - >> I think that we sho

Re: GSoC 2015 - Introduction

2015-03-25 22:04 GMT-03:00 Long, Martin : > >>> That sounds good. The specification uses the word "groups", but I don't >>> really like this because groups seems to imply that an item belongs to a >>> single group. I prefer "sets". My Suunto dive computer, for example would >>> be part of both my

Re: Coding Style - C++ constructor initialization list

2015-03-25 21:20 GMT-03:00 Thiago Macieira : > On Monday 23 March 2015 05:51:26 Dirk Hohndel wrote: > > > *ClassName::ClassName() :* > > > *x(1),* > > > *y(2),* > > > *z(3)* > > > *{* > > > *}* > > > > This isn't readable for me. Possibly a mail formating issue. > > I thought it was just me... > >

Re: GSoC 2015 - Introduction

2015-03-25 5:24 GMT-03:00 Long, Martin : > >>> >> *MANY* thanks for your powerful explanation. =D >> > > You're welcome :) > > >> I have many ideas about how it should looks like and work... I'm doing >> some mockups and I will let you see it soon. >> > > Great, I'd love to see them. > > >> >> I'm

Re: [PATCH] initializing members

Hi 2015-03-24 13:44 GMT-03:00 Dirk Hohndel : > Sorry to be so slow to respond here. > > First, thanks Marcos, solid patches. And good work figuring out an easy > area to work on to get started. > > On Mon, Mar 23, 2015 at 01:47:01PM -0300, Marcos Cardinot wrote: > > Hi L

Re: GSoC 2015 - Introduction

Hi Martin, 2015-03-23 6:14 GMT-03:00 Long, Martin : > Hi Marcos, > > *- Asset Management* >> >> The main concept of this project is very clear[2], but as I'm not a >> diver, I really appreciate your help to better understand all the details >> expected for this project. In this way I would have m

Re: [PATCH] initializing members

ou want to apply them, I could send new patches fixing it (and join all changes in a single patch if you like)... 2015-03-23 12:31 GMT-03:00 Lubomir I. Ivanov : > On 23 March 2015 at 06:43, Marcos Cardinot wrote: > >> Hi, >> >> The attached patches initialize some members

[PATCH] initializing members

Hi, The attached patches initialize some members in several classes of the qt-ui package... All the best, Marcos From ce09cbd713d75b768ac396433fa357034ee5b67c Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Sun, 22 Mar 2015 23:14:12 -0300 Subject: [PATCH 1/8] Globe::doubleClick

Coding Style - C++ constructor initialization list

Hello folks, It is just a naive discussion about coding style... =D According to the CodingStyle.txt: *"- in a C++ constructor initialization list, the colon is on the same line and* * continuation lines are aligned as the rule above:* * ClassName::ClassName() : x(1), y(2),* * z(3)* * {* * }"*

[PATCH] missing braces around if statement

Hi, It's a simple issue, it seems that someone forgot the braces... please see attached patch. All the best, Marcos From 55c8ee5c663593ef573decc73e5df1848e97a697 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Sun, 22 Mar 2015 22:36:50 -0300 Subject: [PATCH] parse-xml::parse_dlf_b

[PATCH] missing break in switch

Hi, This is a smaller issue. Please see attached patches. All the best, Marcos From b4cd8716513a6448a84f144b76c33095b1aa0513 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Sun, 22 Mar 2015 22:53:16 -0300 Subject: [PATCH] load-git::walk_tree_file - missing break in switch Simple control

[PATCH] critical bug #858 - 'log' -> 're-plan dive' crashes subsurface

Hi, Regarding to the bug #858: http://trac.subsurface-divelog.org/ticket/858 Please, see attached patch... Question, should we print something in this case? All the best, Marcos From 8cf432d8fc7fba53df9d174f37e6de8673dad5a4 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Fri, 20 Mar 2015

Re: GSoC 2015 - Introduction

Oh, I forgot to mention - I'm 'cardinot' in #subsurface 2015-03-19 22:27 GMT-03:00 Marcos Cardinot : > Hi everyone, > > Firstly, I would like to introduce myself... > I'm a computer engineer and a physics student who wishes to apply for GSoC > this year. &g

GSoC 2015 - Introduction

s, it would be awesome to hear from the community which one would make more people happy! =D All the best, Marcos Cardinot [1] www.sikuli.org [2] http://trac.subsurface-divelog.org/wiki/Subsurface_GSOC_2015_Idea_List#Assetmanagement ___ subsurface

[PATCH] uemis-downloader - typo?

Hi, Please, see attached patch... Is there any reason to change the order of these arguments? typo? All the best, Marcos From b04b2a168c08002ddc7058da8b968a74dd73afdd Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Thu, 19 Mar 2015 17:20:03 -0300 Subject: [PATCH] uemis-downloader

[PATCH] uemis-downloader - resource leak

Hi, I noticed that some resources are not being freed in 'uemis-downloader.c' - please, see attached patch... All the best, Marcos From ec63d6c78c17f26220c5571fddf7c9c4e49b53e0 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Thu, 19 Mar 2015 16:32:31 -0300 Subject: [PATCH] uemis-

Re: [PATCH] TableView - improving the column width calculation

> Qt::Horizontal).toString(); > > + if (text.isEmpty()) { // it might be an icon > > + return metrics.rm_col_width; > > + } > > no need for the braces again. > could you resend, please? > > thanks > lubomir > -- > > From 017a1277d596ca55fdc38858e44f37f6

Re: [PATCH] NULL pointer dereference - segfault

sorry, I'have sent a wrong fix I'll have a look at the codestyle file - thanks =D 2015-03-17 21:24 GMT-03:00 Lubomir I. Ivanov : > On 18 March 2015 at 02:22, Marcos Cardinot wrote: > > 2015-03-17 21:16 GMT-03:00 Lubomir I. Ivanov : > > > >> On 18 March 201

Re: [PATCH] NULL pointer dereference - segfault

2015-03-17 21:16 GMT-03:00 Lubomir I. Ivanov : > On 18 March 2015 at 01:45, Marcos Cardinot wrote: > > > > Hello folks, > > > > The current code in RulerItem2::settingsChanged() is dereferencing the > null pointer 'profWidget'. > > It can cause a s

[PATCH] NULL pointer dereference - segfault

Hello folks, The current code in RulerItem2::settingsChanged() is dereferencing the null pointer 'profWidget'. It can cause a segmentation fault. All the best, Marcos From 7b9c36e93951b9202790dc700ca1240e70173f01 Mon Sep 17 00:00:00 2001 From: Marcos Cardinot Date: Tue, 17 Mar 201

[PATCH] TableView - improving the column width calculation

he best, Marcos From 612788ff510a7490b46bdef5866947110d86403c Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Tue, 17 Mar 2015 17:56:52 -0300 Subject: [PATCH] TableView - improving the column width calculation Even that most (or all) tables have the remove button at the section 0, the method defaultColumnWidth should not