Re: [PATCH] Detect location of `ldconfig' before use

2017-02-05 Thread Thiago Macieira
On domingo, 5 de fevereiro de 2017 12:53:38 PST Cristian Ionescu-Idbohrn wrote: > + _ldconfig=$(PATH=/usr/local/sbin:/usr/sbin:/sbin:$PATH command -v > ldconfig) || { + echo "can't find ldconfig" >&2 > + exit 1 > + } > + LIBGIT=$($_ldconfig -p | grep

Re: [PATCH] Detect location of ldconfig before use

2017-02-05 Thread Cristian Ionescu-Idbohrn
On Sun, 5 Feb 2017, Robert Helling wrote: > > On 05 Feb 2017, at 15:21, Cristian Ionescu-Idbohrn > > wrote: > > > > I have an idea ;) > > > > Why not error handle those the code that produces those "warnings" (as > > you call them) on that particular

Re: [PATCH] Detect location of `ldconfig' before use

2017-02-05 Thread Robert Helling
Hi, > On 05 Feb 2017, at 15:21, Cristian Ionescu-Idbohrn > wrote: > > I have an idea ;) > > Why not error handle those the code that produces those "warnings" (as > you call them) on that particular architecture, instead of > ignoring/hiding the errors (exit

Re: [PATCH] Detect location of `ldconfig' before use

2017-02-05 Thread Cristian Ionescu-Idbohrn
On Sun, 5 Feb 2017, Robert C. Helling wrote: > > Am 05.02.2017 um 12:53 schrieb Cristian Ionescu-Idbohrn > > : > > > > That's the reason shell option '-e' (errexit) was introduced. > > That option had been introduced before and then later been removed >

Re: [PATCH] Detect location of `ldconfig' before use

2017-02-05 Thread Robert C. Helling
Hi, > Am 05.02.2017 um 12:53 schrieb Cristian Ionescu-Idbohrn > : > > That's the reason shell option > '-e' (errexit) was introduced. That option had been introduced before and then later been removed again. The build on mac throws warnings about certain Qt

[PATCH] Detect location of `ldconfig' before use

2017-02-05 Thread Cristian Ionescu-Idbohrn
The unhandled error was: ./subsurface/scripts/build.sh: line 84: ldconfig: command not found On my box, the path is /sbin/ldconfig, and /sbin is not in common users' PATH. The script just continued to execute after that error, which can result in other odd bugs showing up later. That's