Re: [PATCH] Separate download code sharable between desktop & mobile

2016-01-31 Thread Dirk Hohndel
On Sun, Jan 31, 2016 at 10:27:01PM +0200, Willem Ferguson wrote: > The object here was just to get the desktop version to work normally, given > the removal of some code. > Filtering is certainly a priority, but probably implementing another method > of the same class. That seems like a sensible p

Fwd: Re: [PATCH] Separate download code sharable between desktop & mobile

2016-01-31 Thread Willem Ferguson
On 31/01/2016 20:36, Dirk Hohndel wrote: I'm not sure why you say that. The issue that I see is the filtering that's missing (i.e., just shoing the support DCs), but the models should work in QML with very little modification. These comments are very valuable to me. The object here was just

Re: [PATCH] Separate download code sharable between desktop & mobile

2016-01-31 Thread Dirk Hohndel
On Sun, Jan 31, 2016 at 07:47:40PM +0200, Willem Ferguson wrote: > [PATCH] Separate download code sharable between desktop & mobile > > This is a very first step that extracts code from > downloadfromdivecomputer into a separate class called > "download

[PATCH] Separate download code sharable between desktop & mobile

2016-01-31 Thread Willem Ferguson
[PATCH] Separate download code sharable between desktop & mobile This is a very first step that extracts code from downloadfromdivecomputer into a separate class called "downloadmanager". The purpose of this patch is to do some separation of sharable code wit