Re: [PATCH 2/2] Remove unused function SettingsObjectWrapper::sync()

2017-01-07 Thread Rick Walsh
On 8 January 2017 at 02:10, Dirk Hohndel wrote: > Actually, I found where sync() is used. In the tests. So NAK from here > > > That was silly of me. I was even looking in testpreferences.cpp to work out how the setSomething() functions were used. I'll wear the dunce's cap for

Re: [PATCH 2/2] Remove unused function SettingsObjectWrapper::sync()

2017-01-07 Thread Dirk Hohndel
Actually, I found where sync() is used. In the tests. So NAK from here /D > On Jan 6, 2017, at 11:53 PM, Tomaz Canabrava wrote: > > Ack > > They look same > > On Sat, 7 Jan 2017 at 04:25, Dirk Hohndel > wrote: > Tomaz, > >

Re: [PATCH 2/2] Remove unused function SettingsObjectWrapper::sync()

2017-01-06 Thread Dirk Hohndel
Tomaz, this looks good to me. Can I get an ACK for both patches from you? /D > On Jan 6, 2017, at 2:10 AM, Rick Walsh wrote: > > It was never called > > Signed-off-by: Rick Walsh > --- > > As pointed out by Robert > >

[PATCH 2/2] Remove unused function SettingsObjectWrapper::sync()

2017-01-06 Thread Rick Walsh
It was never called Signed-off-by: Rick Walsh --- As pointed out by Robert core/subsurface-qt/SettingsObjectWrapper.cpp | 29 core/subsurface-qt/SettingsObjectWrapper.h | 1 - 2 files changed, 30 deletions(-) diff --git