[PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Anton Lundin
This adds the QIODevice::Unbuffered flag to our rfcomm connections to bypass the buffering layer in QIODevice. This fixes so firmware upgrades work against the OSTC Sport. Signed-off-by: Anton Lundin --- I'm CC'ing Thiago and Claudiu here, so they can take a look and stop me if I've gone off by

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Thiago Macieira
On Tuesday 29 September 2015 21:12:55 Anton Lundin wrote: > This adds the QIODevice::Unbuffered flag to our rfcomm connections to > bypass the buffering layer in QIODevice. > > This fixes so firmware upgrades work against the OSTC Sport. Both patches look good. The unbuffered mode should not hav

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Anton Lundin
On 29 September, 2015 - Thiago Macieira wrote: > On Tuesday 29 September 2015 21:12:55 Anton Lundin wrote: > > This adds the QIODevice::Unbuffered flag to our rfcomm connections to > > bypass the buffering layer in QIODevice. > > > > This fixes so firmware upgrades work against the OSTC Sport. >

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Claudiu Olteanu
Hi there, I just tested the patches and all seems good. Thanks for making time to resolve this issue. I managed to update the firmware on my OSTC Sport device using our BTH implementation (from 10.18 to 10.20). I also have an OSTC 2 device with an old firmware (1.81) but it doesn't detect that th

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Thiago Macieira
On Tuesday 29 September 2015 21:59:31 Anton Lundin wrote: > - rc = device->socket->write((char *) data + nbytes, size - > nbytes); > + rc = device->socket->write((char *) data + nbytes, > size - nbytes > 16 ? 16 : size - nbytes); Yeah, that really shows the bug is prob

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-29 Thread Anton Lundin
On 29 September, 2015 - Thiago Macieira wrote: > On Tuesday 29 September 2015 21:59:31 Anton Lundin wrote: > > - rc = device->socket->write((char *) data + nbytes, size - > > nbytes); > > + rc = device->socket->write((char *) data + nbytes, > > size - nbytes > 16 ? 16

Re: [PATCH 2/2] qtserialbluetooth: use QIODevice::Unbuffered io

2015-09-30 Thread Jef Driesen
On 2015-09-29 23:54, Anton Lundin wrote: On 29 September, 2015 - Thiago Macieira wrote: On Tuesday 29 September 2015 21:59:31 Anton Lundin wrote: > - rc = device->socket->write((char *) data + nbytes, size - > nbytes); > + rc = device->socket->write((char *) data + n