Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-14 Thread Long, Martin
On 13 December 2014 at 23:33, Long, Martin mar...@longhome.co.uk wrote: I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. Am I missing something? I don't see a Subsurface-testing branch in libdivecomputer. I'm

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-14 Thread Dirk Hohndel
On December 14, 2014 1:41:48 PM Long, Martin mar...@longhome.co.uk wrote: On 13 December 2014 at 23:33, Long, Martin mar...@longhome.co.uk wrote: I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. Am I

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-13 Thread Long, Martin
On 13 December 2014 at 16:40, Dirk Hohndel d...@hohndel.org wrote: Well, there are divecomputer sections in each dive, but the nickname, serial, firmware, etc, should be stored in the settings at the beginning. And that has been true at least since Subsurface 3. Also, if the nickname is

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-13 Thread Dirk Hohndel
On Sat, Dec 13, 2014 at 04:44:19PM +, Long, Martin wrote: On 13 December 2014 at 16:40, Dirk Hohndel d...@hohndel.org wrote: Well, there are divecomputer sections in each dive, but the nickname, serial, firmware, etc, should be stored in the settings at the beginning. And that has

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-13 Thread Long, Martin
So, the info in every profile (for my Suunto) is: divecomputer model='Suunto Vyper Air' deviceid='cef51609' diveid='8ab03c43' And the details in the settings section, when I add a nickname: divecomputerid model='Suunto Vyper Air' deviceid='cef51609' nickname='nick'/ So, it looks like there

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-13 Thread Dirk Hohndel
On Sat, Dec 13, 2014 at 05:29:06PM +, Long, Martin wrote: So, the info in every profile (for my Suunto) is: divecomputer model='Suunto Vyper Air' deviceid='cef51609' diveid='8ab03c43' And the details in the settings section, when I add a nickname: divecomputerid model='Suunto

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-13 Thread Long, Martin
I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. ___ subsurface mailing list subsurface@subsurface-divelog.org

[PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-12 Thread Martin Long
XPath was incorrect for parsing divecomputers into the equipment section, meaning they dont get inserted. Signed-off-by: Martin Long mar...@longhome.co.uk --- xslt/uddf-export.xslt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xslt/uddf-export.xslt b/xslt/uddf-export.xslt

Re: [PATCH 4/7] Fix divecomputer part of UDDF export

2014-12-12 Thread Miika Turkia
On Sat, Dec 13, 2014 at 2:34 AM, Martin Long mar...@longhome.co.uk wrote: XPath was incorrect for parsing divecomputers into the equipment section, meaning they dont get inserted. Can you elaborate on this one as on my divelog all the dive computers are listed on the settings section and the