Hi Thiago,
Thanks for making time to look over the patches!
Subject: [PATCH 03/17] Use only the BTH address to check if the device was
already added
There are moments when the name of the device cannot be obtained.
Therefore we should use only the Bluetooth address to identify if
the
On Friday 14 August 2015 00:13:40 Claudiu Olteanu wrote:
Hi Claudiu
Great work, this is a very good contribution. Thank you for getting to it!
Most of my comments below are suggestions for learning and other requests for
clarification on my part. There are just two issues that need to be fixed
On Tuesday 18 August 2015 12:31:53 Claudiu Olteanu wrote:
Thank you for your detailed explanation! I didn't know about the difference
between the W functions on Windows instead of the A ones.
Since I will create a new set of patches I will try to add all the things
you suggested.
Hi Claudiu
On Tue, Aug 18, 2015 at 12:31:53PM +0300, Claudiu Olteanu wrote:
Thanks for making time to look over the patches!
Yes, let me repeat that. Excellent review, Thiago. Thank you.
[...]
Since I will create a new set of patches I will try to add all the things
you suggested.
Thank you. I look
Hi,
I did the modifications we discussed and I added two extra
improvements (patch number 4 and 19).
The modifications are available on *bth_windows* branch [1].
I thought that it would be easier for Thiago to review the new code
if I will create a separate branch.
Claudiu
[1] -
On Fri, Aug 14, 2015 at 12:13:40AM +0300, Claudiu Olteanu wrote:
These patches will add Bluetooth support for Windows platforms
and will fix some potential issues.
Since we cannot use the QtBluetooth framework I needed to
implement our custom Bluetooth device discovery agent.
I decided to
Can you explain this a bit more? Should we not prefer the deviceLabel IF
we can get it?
When I created that patch I thought that it would be better to use only
the device address to identify if the device is already in the list. This is
due the fact that currently the pattern of the
No I didn't do any copy and paste.
I will send you tomorrow the patches with the modification discussed (I
will clear the discovered devices list after each update) and I will update
the commit message for the
patch with the implementation of a device discovery agent.
Claudiu
On Sat, Aug 15, 2015 at 04:15:54PM +0300, Claudiu Olteanu wrote:
Can you explain this a bit more? Should we not prefer the deviceLabel IF
we can get it?
When I created that patch I thought that it would be better to use only
the device address to identify if the device is already in the
These patches will add Bluetooth support for Windows platforms
and will fix some potential issues.
Since we cannot use the QtBluetooth framework I needed to
implement our custom Bluetooth device discovery agent.
I decided to create a separated class and raise the same signals
as
10 matches
Mail list logo
