Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 12:11:30 Dirk Hohndel wrote: > > > private: > > > PluginManager(); > > > > > > - PluginManager(const PluginManager&) = delete; > > > - PluginManager& operator=(const PluginManager&) = delete; > > > + PluginManager(const PluginManager&){}; > > >

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 22:11, Dirk Hohndel wrote: > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: >> >> Fair enough, but you won't get away with that for long :-P >> >> Qt 5.6 will be the last release to support building in C++98 mode. Starting >> with Qt 5.7,

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 23:23, Tomaz Canabrava wrote: >> >> http://lists.qt-project.org/pipermail/development/2015-June/022090.html >> >> CopperSpice is Qt fork discussed in the above thread: >> https://www.youtube.com/watch?v=LIiwBNvTllk >> >> i'm quickly skipping trough it

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 19:33:55 Tomaz Canabrava wrote: > http://lists.qt-project.org/pipermail/development/2015-July/022219.html > > thiago's > > > > > answers made me stick with Qt side. > > > > links? is it in that same thread? That's a link to an email from Simon. I can't find my own

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 23:47, Thiago Macieira wrote: > On Monday 09 November 2015 19:33:55 Tomaz Canabrava wrote: >> http://lists.qt-project.org/pipermail/development/2015-July/022219.html > >> > thiago's >> > >> > > answers made me stick with Qt side. >> > >> > links? is it

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Dirk Hohndel
On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira wrote: > > > > > > Can you try adding the -stdlib option in the AppleClang branch to see what > > >

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira wrote: > > > > Can you try adding the -stdlib option in the AppleClang branch to see what > > happens? > > I have an odd question. > > Why? Well, for one thing,

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Lubomir I. Ivanov
On 9 November 2015 at 08:57, Dirk Hohndel wrote: > > What we have in master works. if something can't be written in plain old C++ then it's probably badly engineered, lazy or feature hungry. > > I have no interest in seeing Subsurface code made unreadable by C++11 > features -

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
On Mon, Nov 9, 2015 at 7:21 PM, Lubomir I. Ivanov wrote: > On 9 November 2015 at 22:11, Dirk Hohndel wrote: > > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > >> > >> Fair enough, but you won't get away with that for long :-P > >> > >>

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
On Mon, Nov 9, 2015 at 6:11 PM, Dirk Hohndel wrote: > On Mon, Nov 09, 2015 at 11:51:30AM -0800, Thiago Macieira wrote: > > On Sunday 08 November 2015 22:57:03 Dirk Hohndel wrote: > > > > On Nov 8, 2015, at 10:41 PM, Thiago Macieira > wrote: > > > > > > > >

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Tomaz Canabrava
http://lists.qt-project.org/pipermail/development/2015-July/022219.html On Mon, Nov 9, 2015 at 7:25 PM, Lubomir I. Ivanov wrote: > On 9 November 2015 at 23:23, Tomaz Canabrava wrote: > >> > >>

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Tuesday 10 November 2015 00:10:15 Lubomir I. Ivanov wrote: > constexpr specifically seems to have landed in msvc 2015 RTM. > http://blogs.msdn.com/b/vcblog/archive/2015/06/02/constexpr-complete-for-vs-> > 2015-rtm-c-11-compiler-c-17-stl.aspx Yeah, but it doesn't work. If you try Qt's

Re: [PATH] fix broken mac build on old clangs.

2015-11-09 Thread Thiago Macieira
On Monday 09 November 2015 19:22:23 Tomaz Canabrava wrote: > it deletes the Copy Constructor and the operator=, if you don't declare > them the compiler will declare one anyhow. the way one does that in pre > c++11 is to declare an empty copy constructor and equal operator on the > private area,

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Thiago Macieira
On Sunday 08 November 2015 22:12:19 Tomaz Canabrava wrote: > if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") > - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu11 ") > - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11") > + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ") >

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Dirk Hohndel
> On Nov 8, 2015, at 19:31, Thiago Macieira wrote: > >> On Sunday 08 November 2015 22:12:19 Tomaz Canabrava wrote: >> if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") >> - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu11 ") >> - set(CMAKE_CXX_FLAGS

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Thiago Macieira
On Sunday 08 November 2015 21:57:54 Tomaz Canabrava wrote: > They don't like c++11 They who? What's the error? Is that a build with the old GCC 4.2 instead of Clang? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

[PATH] fix broken mac build on old clangs.

2015-11-08 Thread Tomaz Canabrava
They don't like c++11 From b881e39ea03ab9a6e5d949d04f3fa690a5feeeb4 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Sun, 8 Nov 2015 21:50:12 -0200 Subject: [PATCH 7/7] Remove lambdas: they don't work on OSX 10.7 Signed-off-by: Tomaz Canabrava

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Tomaz Canabrava
and two more patches. On Sun, Nov 8, 2015 at 9:57 PM, Tomaz Canabrava wrote: > They don't like c++11 > > From be06d0f78281a4a7b96aa8a49ce1b94441aa47a8 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Sun, 8 Nov 2015 22:01:05 -0200 Subject:

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Dirk Hohndel
> On Nov 8, 2015, at 8:33 PM, Thiago Macieira wrote: > > On Sunday 08 November 2015 20:00:13 Dirk Hohndel wrote: >> Nope. Xcode 4 uses clang and throws up with c++11 >> >> And I need XCode 4 to build working binaries. We've been down this rat hole >> before. I'm not

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Thiago Macieira
On Sunday 08 November 2015 21:02:53 Dirk Hohndel wrote: > /Users/hohndel/Qt/5.5/clang_64/lib/QtCore.framework/Headers/qstring.h:739:5 > 5: error: no type named 'u16string' in namespace 'std' Option -stdlib=libc++ to clang should fix this. >

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Dirk Hohndel
> On Nov 8, 2015, at 10:41 PM, Thiago Macieira wrote: > > Can you try adding the -stdlib option in the AppleClang branch to see what > happens? I have an odd question. Why? What we have in master works. I have no interest in seeing Subsurface code made unreadable by

Re: [PATH] fix broken mac build on old clangs.

2015-11-08 Thread Thiago Macieira
On Sunday 08 November 2015 20:00:13 Dirk Hohndel wrote: > Nope. Xcode 4 uses clang and throws up with c++11 > > And I need XCode 4 to build working binaries. We've been down this rat hole > before. I'm not switching compilers. Xcode 4.6 comes with a Clang based on the 3.2 branch of LLVM and