Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 02:02:54PM -0700, Thiago Macieira wrote: > On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > > > That's slightly weird :-) > > > > I know that this is weird but there is no HostPoweredOn enu

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Oh yeah :). I don't know what was in my mind when I did that :)). On Tue, Jul 7, 2015 at 12:02 AM, Thiago Macieira wrote: > On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > > > That's slightly weird :-) > > > > I

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > That's slightly weird :-) > > I know that this is weird but there is no HostPoweredOn enum :-). It can be > either off, connectable, discoverable or discoverable limi

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Hi Thiago, > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > That's slightly weird :-) I know that this is weird but there is no HostPoweredOn enum :-). It can be either off, connectable, discoverable or discoverable limited inquiry. Therefore I choose to use !(mode == QB

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 17:42:00 Claudiu Olteanu wrote: [mostly cut] Hello Claudiiu The patches look good. They do what we had discussed previously. My comments are only nitpicks and suggestions for coding style in the future. There's no need to change anything now. > + bool on = !(mode =

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
> > Actually, here's one. The fake open function for the OSTC 2N. That could > have been its own commit, added before the next commit that adds all the > qtserialbluetooth stuff. That's a simple example, but maybe it illustrates > what I mean. > It is funny that in the beginning I did an isolated

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Dirk Hohndel
Hi CLaudiu On Mon, Jul 06, 2015 at 05:42:00PM +0300, Claudiu Olteanu wrote: > Hi there, > > I attached you some patches which add the QtBluetooth serial implementation. > The Bluetooth download mode is accessible from the DownloadFromDiveComputer > widget. > > In order to connect to a Bluetooth

[PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Hi there, I attached you some patches which add the QtBluetooth serial implementation. The Bluetooth download mode is accessible from the DownloadFromDiveComputer widget. In order to connect to a Bluetooth device I decided to remove the SDP discovery because it doesn't work for all devices. For t