Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Jan Darowski
No problem, but before that I want to check one place I suspect can be wrong... 2015-07-07 21:33 GMT+02:00 Dirk Hohndel : > On Tue, Jul 07, 2015 at 09:29:19PM +0200, Jan Darowski wrote: >> I think I will check all the units once again. But it's true that it's >> another mistake on the deepocean.ne

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 09:29:19PM +0200, Jan Darowski wrote: > I think I will check all the units once again. But it's true that it's > another mistake on the deepocean.net > The real values are 0.257 N/m and 0.0179 N/m (paper by Baker confirms) > but these constants are always (that's what I will

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Jan Darowski
I think I will check all the units once again. But it's true that it's another mistake on the deepocean.net The real values are 0.257 N/m and 0.0179 N/m (paper by Baker confirms) but these constants are always (that's what I will check again) in the context like: pressure + skin_compression / radiu

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 08:41:56PM +1000, Rick Walsh wrote: > Dirk, Jan, > > On 5 July 2015 at 23:56, Dirk Hohndel wrote: > > > On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: > > > Hi, > > > Here is another pull request. I hope now it's better. Everything was > > > reorganized fro

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-07 Thread Rick Walsh
Dirk, Jan, On 5 July 2015 at 23:56, Dirk Hohndel wrote: > On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: > > Hi, > > Here is another pull request. I hope now it's better. Everything was > > reorganized from scratch, the final code is almost the same. > > I like the patches much be

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-05 Thread Dirk Hohndel
On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: > Hi, > Here is another pull request. I hope now it's better. Everything was > reorganized from scratch, the final code is almost the same. I like the patches much better. I agree with Robert that you could have squashed a couple togeth

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Dirk Hohndel
On Sat, Jul 04, 2015 at 07:23:12PM +1000, Rick Walsh wrote: > I multiplied 7500 fsw by 0.304 (feet to metres) divided by 10 (metres salt > water to ata) and multipled by 1.01325 (ata to bar). > 7500 * 0.304 / 10 * 1.01353 = 231.021 bar > > It's close, but I think my conversion was very slightly ou

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Dirk Hohndel
On Sat, Jul 04, 2015 at 10:29:17AM +0200, Jan Darowski wrote: > Thanks for checking it. > > > But then I checked the configuration parameters adopted, and there are > > differences. I altered vpmb_config to match what was used in the Fortran > > code. > > critical radius of N2 was 0.6, changed to

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Rick Walsh
Hi Robert, On 4 July 2015 at 19:25, Robert C. Helling wrote: > > > What I am a bit puzzled about are the „conservatism“ factors some other > programs offer. I have no idea which parameters those affect but that is > another thing to investigate. > > > HHS Software (V-Planner/Multideco) have def

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Robert C. Helling
Hi, > On 04 Jul 2015, at 00:27, Jan Darowski wrote: > > Here is another pull request. I hope now it's better. Everything was > reorganized from scratch, the final code is almost the same. I expect I have some time tonight to review those. Best Robert signature.asc Description: Message signe

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Robert C. Helling
Hi, > On 04 Jul 2015, at 10:29, Jan Darowski wrote: > > I guess I need to implement Boyle's law as soon as possible and only > test against > the original fortran code... just a brief comment: Indeed testing against other code is quite essential (not only since our software might be giving lif

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Robert C. Helling
Hi, > On 04 Jul 2015, at 11:23, Rick Walsh wrote: > > I multiplied 7500 fsw by 0.304 (feet to metres) divided by 10 (metres salt > water to ata) and multipled by 1.01325 (ata to bar). > 7500 * 0.304 / 10 * 1.01353 = 231.021 bar > > It's close, but I think my conversion was very slightly out, a

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Rick Walsh
Hi, On 4 July 2015 at 18:29, Jan Darowski wrote: > > eh... from deepocean.net: "7500 fsw min = 250 bar min" > It's not the first mistake I found there. And it seems that the author > of existing > c code based his implementation on this site also. > > I multiplied 7500 fsw by 0.304 (feet to metr

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Jan Darowski
Thanks for checking it. > But then I checked the configuration parameters adopted, and there are > differences. I altered vpmb_config to match what was used in the Fortran > code. > critical radius of N2 was 0.6, changed to 0.8 microns > critical radius of He was 0.5, changed to 0.7 microns > cri

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-04 Thread Rick Walsh
Hi Jan, On 4 July 2015 at 08:27, Jan Darowski wrote: > Hi, > Here is another pull request. I hope now it's better. Everything was > reorganized from scratch, the final code is almost the same. > > I tried your VPM patch set. I haven't worked through the logic of the code or looked at individual

[PULL REQUEST] VPM-B Attempt 2.

2015-07-03 Thread Jan Darowski
Hi, Here is another pull request. I hope now it's better. Everything was reorganized from scratch, the final code is almost the same. The following changes since commit 5ae5aedab3b628ad04abc435ce3b06c3612d4d6c: Add FAQ item about creating a udev rule for Cobalt under Linux (2015-07-02 12:26:1