Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 08:20:19 Dirk Hohndel wrote: > Pull requests have advantages for GSoC purposes as they make it much > easier for me to ask the mentor to go through them, sign off on the > patches and then I can pull them. But as Lubomir said, that's optional. And I've just reviewed, but the

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 05:33:00PM +0300, Claudiu Olteanu wrote: > Hi, > > These patches create a generic way to represent any type of serial > communication. They are used to create a custom serial implementation > for HW_OSTC3 and SHEARWATER families. This looks good to me. I'll add these to o

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:17:02PM +0300, Claudiu Olteanu wrote: > Hi Lubomir, > > Thanks for the info! > > Yeah, probably I shouldn't named the thread "PULL REQUEST". > > Since these are the differences between my repository > and the Subsurface' one, I thought that the process is similar > wit

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:07:02PM +0300, Lubomir I. Ivanov wrote: > On 6 July 2015 at 17:33, Claudiu Olteanu > wrote: > > Hi, > > > > These patches create a generic way to represent any type of serial > > communication. They are used to create a custom serial implementation > > for HW_OSTC3 and

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Claudiu Olteanu
Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread "PULL REQUEST". Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull request. Also I knew that Dirk prefers patches instead of pull requests.

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Lubomir I. Ivanov
On 6 July 2015 at 17:33, Claudiu Olteanu wrote: > Hi, > > These patches create a generic way to represent any type of serial > communication. They are used to create a custom serial implementation > for HW_OSTC3 and SHEARWATER families. > hey, Claudiu. just to point out that if you attach the p

[PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Claudiu Olteanu
Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial implementation for HW_OSTC3 and SHEARWATER families. Claudiu From 05d830371f2bce35820bebb7419ed27946b3a658 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu Date: Sat, 27 J