Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-11 Thread Dirk Hohndel
> On Mar 11, 2017, at 8:30 AM, Stefan Fuchs wrote: > > Hi Dirk, > > > Am 11.03.2017 um 14:47 schrieb Stefan Fuchs: >> >> Pull request submitted. >> >> One important hint: Can happen that there will be a conflict with an still >> open pull request from Robert. Dirk, if you can't merge it aft

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-11 Thread Stefan Fuchs
Hi Dirk, Am 11.03.2017 um 14:47 schrieb Stefan Fuchs: > > Pull request submitted. > > One important hint: Can happen that there will be a conflict with an > still open pull request from Robert. Dirk, if you can't merge it after > merging Roberts changes, please tell me! I will then rebase it agai

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-11 Thread Stefan Fuchs
Hi All, Am 06.03.2017 um 06:41 schrieb Dirk Hohndel: >> >> How is this progressing? Since I have started to pull new features >> maybe this should get merged as well? >> Or is it still too early for that? >> >> > Status update: Implementation and review: Code unchanged since a few days. No known i

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-06 Thread Rick Walsh
On 6 March 2017 at 17:32, Stefan Fuchs wrote: > Hallo Dirk, > Am 06.03.2017 um 06:41 schrieb Dirk Hohndel: > > How is this progressing? Since I have started to pull new features maybe > this should get merged as well? > Or is it still too early for that? > > This is the status: > Implementation a

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-06 Thread Willem Ferguson
Stefan, just include any screenshots that you think are required from whatever environment you work in. I will redo them in Fedora /KDE. I have done this many times. Kind regards, willem On 06 Mar 2017 23:08, "Stefan Fuchs" wrote: > Hi All, hi Dirk, > > Am 06.03.2017 um 15:42 schrieb Dirk Hohnde

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-06 Thread Stefan Fuchs
Hi All, hi Dirk, Am 06.03.2017 um 15:42 schrieb Dirk Hohndel: > > Maybe post about it again on the mailing list, asking for feedback. > But it may be that I have to pull this before you'll get broader testing. > Yes, a paragraph for the user manual would be good. > And tests. I love things that co

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

2017-03-05 Thread Stefan Fuchs
Hallo Dirk, Am 06.03.2017 um 06:41 schrieb Dirk Hohndel: > > How is this progressing? Since I have started to pull new features > maybe this should get merged as well? > Or is it still too early for that? > > This is the status: Implementation and review: Code unchanged since a few days. No known