Downloader

2020-12-18 Thread Salvador Cuñat via subsurface
Hallo Robert. I think there is a typo in subsurface-downloader-main.cpp: 14 #inclide "core/libdivecomputer.h" ^ Best regards. Salva. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.o

Re: Subsurface-downloader

2020-12-04 Thread Robert Helling via subsurface
IrDA dive downoads which is slowly disappearing from most > OSs. With a downloader one could maintain an IrDA stack, although it might > have an effect on the kernel version used. that’s an excellent point. Regarding specs I have to answer I don’t know, but the requirements should be pret

Re: Subsurface-downloader

2020-12-04 Thread Willem Ferguson via subsurface
Hallo Robert, Excellent work! What is the minimum specs required for the Pi? There are many Pi models available these days. One of the issues I am concerned with is the availability of IrDA dive downoads which is slowly disappearing from most OSs. With a downloader one could maintain an IrDA stack

Subsurface-downloader

2020-12-04 Thread Robert Helling via subsurface
Hi, yesterday, we merged the Subsurface downloader branch and I would like to hear peoples comments and suggestions for improvement. So what is it? Subsurface downloader is a command line version of Subsurface that can read a local git repository, download dives from a dive computer and add

Re: [PATCH 2/2] uemis downloader: start downloading using the correct dive IDavoid NULL pointer dereference

2015-09-21 Thread Dirk Hohndel
On Mon, Sep 21, 2015 at 04:50:16PM +0300, Guido Lerch wrote: > Tested this today. Works with my 240 dives I have by now on the Uemis. Good. > Also the blindly strstr was obvious and an overlook on my side. > > The initial object id wasn't from me :-) > > So I am happy with my newbie contributio

Re: [PATCH 2/2] uemis downloader: start downloading using the correct dive IDavoid NULL pointer dereference

2015-09-21 Thread Guido Lerch
ge. I suppose you don't want this for 4.5. G. Lerch Sonntag, 20. September 2015 06:14 +0200 von Linus Torvalds : > >From: Linus Torvalds < torva...@linux-foundation.org > >Date: Sat, 19 Sep 2015 21:09:58 -0700 >Subject: [PATCH 2/2] uemis downloader: start downloading

[PATCH 2/2] uemis downloader: start downloading using the correct dive IDavoid NULL pointer dereference

2015-09-19 Thread Linus Torvalds
From: Linus Torvalds Date: Sat, 19 Sep 2015 21:09:58 -0700 Subject: [PATCH 2/2] uemis downloader: start downloading using the correct dive ID The logic to pick the initial dive ID for the uemis downloader was very confused, and did not work at all when restarting a download when the Uemis

[PATCH 1/2] uemis downloader: avoid NULL pointer dereference

2015-09-19 Thread Linus Torvalds
From: Linus Torvalds Date: Sat, 19 Sep 2015 21:08:03 -0700 Subject: [PATCH 1/2] uemis downloader: avoid NULL pointer dereference The uemis downloader blindly just did a strstr on 'nds->name', even if there wasn't necessarily a dive location at all. Add the proper NULL point

[PATCH 4/6] Fix memory leak on uemis downloader

2015-09-09 Thread Miika Turkia
Signed-off-by: Miika Turkia --- uemis-downloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index 0cb0f9f..d17f67d 100644 --- a/uemis-downloader.c +++ b/uemis-downloader.c @@ -960,7 +960,7 @@ static bool do_dump_buffer_to_file(cha

Re: [PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-09 Thread Dirk Hohndel
On Wed, Sep 09, 2015 at 12:21:57AM +0300, Guido Lerch wrote: > > Dirk. > If I stash my current changes and get the new master would I pickup Lubomir's > changes?  Yes. Are you developing on master? Not a good idea. It would be much better if you worked on a branch... /D ___

Re: Re[2]: [PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-08 Thread Lubomir I. Ivanov
On 9 September 2015 at 00:08, Guido Lerch wrote: > What is the problem here, I had no issues with this during my testing. > u_int32_t can compile on some targets, but we should use the one from the C standard - uint32_t. lubomir -- ___ subsurface maili

Re: [PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-08 Thread Guido Lerch
Dirk. If I stash my current changes and get the new master would I pickup Lubomir's changes?  G. Lerch Dienstag, 8. September 2015 19:04 +0200 von Lubomir I. Ivanov : >From: "Lubomir I. Ivanov" < neolit...@gmail.com > > >Signed-off-by: Lubomir I. Ivanov < neolit...@gmail.com > >--- > uemis-d

Re[2]: [PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-08 Thread Guido Lerch
What is the problem here, I had no issues with this during my testing. Also, how would I apply this patch? I don't want to get a new master as I am fixing some issues with the dive spots currently. G. Lerch Dienstag, 8. September 2015 19:09 +0200 von Dirk Hohndel : >Crap, I had fixed this ea

Re: [PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-08 Thread Dirk Hohndel
Crap, I had fixed this earlier and it snuck through again. I wonder why it sometimes doesn't cause my test builds to fail. Thanks, Lubomir. /D On Tue, Sep 08, 2015 at 08:04:41PM +0300, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > Signed-off-by: Lubomir I. Ivanov > --- > uemis-dow

[PATCH] uemis-downloader: don't use unknown type u_int32_t

2015-09-08 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- uemis-downloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index 0cb0f9f..2fe91e4 100644 --- a/uemis-downloader.c +++ b/uemis-downloader.c @@ -135,7 +135,7 @@ stati

Re: [PATCH] uemis-downloader - typo?

2015-03-19 Thread Dirk Hohndel
:00:00 2001 > From: Marcos CARDINOT > Date: Thu, 19 Mar 2015 17:20:03 -0300 > Subject: [PATCH] uemis-downloader - arguments in wrong order > > method's signature: void uemis_set_divelocation(int divespot, char *text, > double longitude, double latitude) > >

[PATCH] uemis-downloader - typo?

2015-03-19 Thread Marcos Cardinot
Hi, Please, see attached patch... Is there any reason to change the order of these arguments? typo? All the best, Marcos From b04b2a168c08002ddc7058da8b968a74dd73afdd Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Thu, 19 Mar 2015 17:20:03 -0300 Subject: [PATCH] uemis-downloader

[PATCH] uemis-downloader - resource leak

2015-03-19 Thread Marcos Cardinot
Hi, I noticed that some resources are not being freed in 'uemis-downloader.c' - please, see attached patch... All the best, Marcos From ec63d6c78c17f26220c5571fddf7c9c4e49b53e0 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Thu, 19 Mar 2015 16:32:31 -0300 Subject: [PATCH] uemis-

[PATCH 2/2] Teach uemis downloader about downloading into private trips

2014-10-12 Thread Linus Torvalds
From: Linus Torvalds Date: Sun, 12 Oct 2014 07:11:34 -0400 Subject: [PATCH 2/2] Teach uemis downloader about downloading into private trips Now that we pass in the full device_data_t information, we can look at the "create_private_dive" flag and decide just how to record newly downlo

[PATCH 1/2] Pass the whole 'device_data_t' to the uemis downloader

2014-10-12 Thread Linus Torvalds
From: Linus Torvalds Date: Sun, 12 Oct 2014 06:57:32 -0400 Subject: [PATCH 1/2] Pass the whole 'device_data_t' to the uemis downloader Not only does it make it look more like the libdivecomputer downloaders, but the uemis downloader needs it in order to support all the flags we have