Re: FIY: libzip and UTF-8 on Win32

2015-02-24 Thread Lubomir I. Ivanov
On 24 February 2015 at 15:31, Dirk Hohndel wrote: > On Mon, Feb 23, 2015 at 02:26:52PM +0200, Lubomir I. Ivanov wrote: >> On 22 February 2015 at 23:39, Lubomir I. Ivanov wrote: >> > the patch to fix that is pending to be pushed... >> > >> >> patch is up: >> http://hg.nih.at/libzip/ >> >> tested S

Re: FIY: libzip and UTF-8 on Win32

2015-02-24 Thread Dirk Hohndel
On Mon, Feb 23, 2015 at 02:26:52PM +0200, Lubomir I. Ivanov wrote: > On 22 February 2015 at 23:39, Lubomir I. Ivanov wrote: > > the patch to fix that is pending to be pushed... > > > > patch is up: > http://hg.nih.at/libzip/ > > tested Subsurface and the divelogs.de download works for me after >

Re: FIY: libzip and UTF-8 on Win32

2015-02-23 Thread Dirk Hohndel
On Mon, Feb 23, 2015 at 02:26:52PM +0200, Lubomir I. Ivanov wrote: > On 22 February 2015 at 23:39, Lubomir I. Ivanov wrote: > > the patch to fix that is pending to be pushed... > > > > patch is up: > http://hg.nih.at/libzip/ > > tested Subsurface and the divelogs.de download works for me after >

Re: FIY: libzip and UTF-8 on Win32

2015-02-23 Thread Lubomir I. Ivanov
On 22 February 2015 at 23:39, Lubomir I. Ivanov wrote: > the patch to fix that is pending to be pushed... > patch is up: http://hg.nih.at/libzip/ tested Subsurface and the divelogs.de download works for me after compiling the latest libzip.dll. unicode paths also work, but it would be best for t

Re: FIY: libzip and UTF-8 on Win32

2015-02-22 Thread Lubomir I. Ivanov
On 22 February 2015 at 23:17, Thiago Macieira wrote: > On Sunday 22 February 2015 03:56:16 Lubomir I. Ivanov wrote: >> after checking both the source code of QTemporaryFile and libzip in >> terms of Win32 API and doing more testing, i would say this is more of >> a libzip corner case in how shared

Re: FIY: libzip and UTF-8 on Win32

2015-02-22 Thread Thiago Macieira
On Sunday 22 February 2015 03:56:16 Lubomir I. Ivanov wrote: > after checking both the source code of QTemporaryFile and libzip in > terms of Win32 API and doing more testing, i would say this is more of > a libzip corner case in how shared access is obtained on file handles. Does libzip try to ob

Re: FIY: libzip and UTF-8 on Win32

2015-02-22 Thread Thiago Macieira
On Saturday 21 February 2015 01:14:00 Lubomir I. Ivanov wrote: > On 20 February 2015 at 22:13, Lubomir I. Ivanov wrote: > > but...after building Subsurface with the new libzip it gives me > > "Archive cannot be opened. Bad file descriptor" when download from > > divelogs.de. > > i need to investig

Re: FIY: libzip and UTF-8 on Win32

2015-02-21 Thread Lubomir I. Ivanov
On 21 February 2015 at 01:29, Lubomir I. Ivanov wrote: > after this test, i would consider this a Qt issue and not a libzip one. > so the above statement is wrong, after checking both the source code of QTemporaryFile and libzip in terms of Win32 API and doing more testing, i would say this is m

Re: FIY: libzip and UTF-8 on Win32

2015-02-20 Thread Lubomir I. Ivanov
On 21 February 2015 at 01:14, Lubomir I. Ivanov wrote: > > the new libzip itself works. but i also sent an email to the libzip > ML, as this could be on their end for > some odd reason. > doing a: FILE *f = fopen(QFile::encodeName(zipFile.fileName()), "rb"); (with or without zipFile.close() befor

Re: FIY: libzip and UTF-8 on Win32

2015-02-20 Thread Lubomir I. Ivanov
On 20 February 2015 at 22:13, Lubomir I. Ivanov wrote: > but...after building Subsurface with the new libzip it gives me > "Archive cannot be opened. Bad file descriptor" when download from > divelogs.de. > i need to investigate. > spent a couple of hours on this one. CCing Thiago - the QTempora

Re: FIY: libzip and UTF-8 on Win32

2015-02-20 Thread Lubomir I. Ivanov
On 20 February 2015 at 22:05, Lubomir I. Ivanov wrote: > On 19 February 2015 at 18:49, Dirk Hohndel wrote: >> On Thu, Feb 19, 2015 at 06:45:09PM +0200, Lubomir I. Ivanov wrote: >>> i'm now subscribed to the libzip ML, so i will ping when an update is >>> pushed. >>> at least there is development

Re: FIY: libzip and UTF-8 on Win32

2015-02-20 Thread Lubomir I. Ivanov
On 19 February 2015 at 18:49, Dirk Hohndel wrote: > On Thu, Feb 19, 2015 at 06:45:09PM +0200, Lubomir I. Ivanov wrote: >> i'm now subscribed to the libzip ML, so i will ping when an update is pushed. >> at least there is development in the area. > > Thanks. Much appreciated. > a couple of patches

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Dirk Hohndel
On Thu, Feb 19, 2015 at 06:45:09PM +0200, Lubomir I. Ivanov wrote: > On 19 February 2015 at 18:38, Dirk Hohndel wrote: > > > > Thanks. The user who reported the issue still can't get things to work. > > I simply know too little about how all the encoding works on a Windows > > box. > > > > His use

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Lubomir I. Ivanov
On 19 February 2015 at 18:38, Dirk Hohndel wrote: > > Thanks. The user who reported the issue still can't get things to work. > I simply know too little about how all the encoding works on a Windows > box. > > His user name is something like "Große Krähe" (no, that's of course not his > user name,

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Dirk Hohndel
On Thu, Feb 19, 2015 at 01:13:55PM +0200, Lubomir I. Ivanov wrote: > On 19 February 2015 at 08:40, Dirk Hohndel wrote: > > On Thu, Feb 19, 2015 at 01:03:12AM +0200, Lubomir I. Ivanov wrote: > >> > >> nothing bad should happen to my knowledge as they seem to have only > >> changed their backend. >

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Lubomir I. Ivanov
On 19 February 2015 at 08:40, Dirk Hohndel wrote: > On Thu, Feb 19, 2015 at 01:03:12AM +0200, Lubomir I. Ivanov wrote: >> >> nothing bad should happen to my knowledge as they seem to have only >> changed their backend. >> hopefully it doesn't break anything... > > Hmmm. > >> from what i just saw t

Re: FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Dirk Hohndel
On Thu, Feb 19, 2015 at 01:03:12AM +0200, Lubomir I. Ivanov wrote: > > nothing bad should happen to my knowledge as they seem to have only > changed their backend. > hopefully it doesn't break anything... Hmmm. > from what i just saw their cmake setup is quite clean, i just > downloaded the tar

Re: FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Lubomir I. Ivanov
On 19 February 2015 at 01:03, Lubomir I. Ivanov wrote: > but here is the patch that i sent to the ML that fixes a compile bug > for me (attached). > On 19 February 2015 at 02:15, Thomas Klausner wrote: > Hi Lubomir! > > On Thu, Feb 19, 2015 at 12:56:41AM +0200, Lubomir I. Ivanov wrote: >> here i

Re: FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Lubomir I. Ivanov
On 19 February 2015 at 00:53, Dirk Hohndel wrote: > On Thu, Feb 19, 2015 at 12:46:34AM +0200, Lubomir I. Ivanov wrote: >> so, i've been bringing this annoying topic multiple times now, >> >> if Subsurface is built with older libzip, when targeting Win32 there >> was this problem where zip_open() f

Re: FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Dirk Hohndel
On Thu, Feb 19, 2015 at 12:46:34AM +0200, Lubomir I. Ivanov wrote: > so, i've been bringing this annoying topic multiple times now, > > if Subsurface is built with older libzip, when targeting Win32 there > was this problem where zip_open() from libzip doesn't work with weird > UTF-16 encoded path

FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Lubomir I. Ivanov
so, i've been bringing this annoying topic multiple times now, if Subsurface is built with older libzip, when targeting Win32 there was this problem where zip_open() from libzip doesn't work with weird UTF-16 encoded paths...etc... so i've just downloaded the tip from their mercurial: http://hg.n