Re: road to 4.9

2019-07-18 Thread Linus Torvalds
On Wed, Jul 17, 2019 at 10:36 PM Berthold Stoeger wrote: > > Would you mind if I make a PR out of your patch? I'm not sure how to handle > authorship, though. Go right ahead. And honestly, while I think authorship credit matters a lot, _my_ authorship is one of the exceptions. I get to much cre

Re: road to 4.9

2019-07-17 Thread Berthold Stoeger
On Wednesday, 17 July 2019 23:20:29 CEST Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 9:53 PM Steve wrote: > > Applied the patach and got: Unknown cylinder use string 'Freedive' > > Ok, that should never be valid, and shouldn't be a possible value. It > does sound like there's been corruption

Re: road to 4.9

2019-07-17 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 9:53 PM Steve wrote: > > Applied the patach and got: Unknown cylinder use string 'Freedive' Ok, that should never be valid, and shouldn't be a possible value. It does sound like there's been corruption at some point, although I can't see how _that_ kind of corruption ever

Re: [Fwd: Re: road to 4.9]

2019-07-15 Thread Steve
> subsurface@subsurface-divelog.org > , Dirk Hohndel < > d...@hohndel.org > > > Subject: Re: road to 4.9 > Date: Mon, 15 Jul 2019 14:55:36 +1000 > > On Mon, 2019-07-15 at 00:11 +0200, Berthold Stoeger wrote: > > Hi Steve, > > > > > Cheers, outpu

[Fwd: Re: road to 4.9]

2019-07-14 Thread Steve
Forwarded Message From: Steve Reply-To: stevewilli...@internode.on.net To: Berthold Stoeger Cc: subsurface@subsurface-divelog.org, Dirk Hohndel Subject: Re: road to 4.9 Date: Mon, 15 Jul 2019 14:55:36 +1000 On Mon, 2019-07-15 at 00:11 +0200, Berthold Stoeger wrote: > Hi St

Re: road to 4.9

2019-07-14 Thread Steve
On Mon, 2019-07-15 at 00:11 +0200, Berthold Stoeger wrote: > Hi Steve, > > > > > Cheers, output below: > > > > Many thanks. Just for my peace of mind, would you please provide the > output of the following gdb commands after it hits the crash: > > > > (gdb) print i > (gdb) print nr > (g

Re: road to 4.9

2019-07-14 Thread Steve
On Sun, 2019-07-14 at 16:51 -0700, Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 3:57 PM Steve < > stevewilli...@internode.on.net > > wrote: > > Yes I am in Adelaide Australia, I haven't played with the local on > > purpose but if anything if there is no en_au then I would have > > choose > > en

Re: road to 4.9

2019-07-14 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 3:57 PM Steve wrote: > > Yes I am in Adelaide Australia, I haven't played with the local on > purpose but if anything if there is no en_au then I would have choose > en_gb. I tried to look through our history. I don't think we've ever localized the cylinder usage strings

Re: road to 4.9

2019-07-14 Thread Steve
On Sun, 2019-07-14 at 10:18 -0700, Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 6:16 AM Steve < > stevewilli...@internode.on.net > > wrote: > > (gdb) where > > #0 0x00708fcd in save_cylinder_info (dive=0xc34f240, > > b=0x7fffc2c0) at /home/steve/src/subsurface/core/save-xml.c:193 >

Re: road to 4.9

2019-07-14 Thread Steve
On Sun, 2019-07-14 at 10:56 -0700, Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 10:40 AM Linus Torvalds > < > torva...@linux-foundation.org > > wrote: > > Better version here - this does the save-git case too, and > > simplifies > > things by using 'show_utf8()' that already checks for NULL > >

Re: road to 4.9

2019-07-14 Thread Berthold Stoeger
Hi Steve, > Cheers, output below: Many thanks. Just for my peace of mind, would you please provide the output of the following gdb commands after it hits the crash: (gdb) print i (gdb) print nr (gdb) print cylinder (gdb) print *cylinder (gdb) print dive->cylinder (gdb) print &dive->cylinder B

Re: road to 4.9

2019-07-14 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 10:40 AM Linus Torvalds wrote: > > Better version here - this does the save-git case too, and simplifies > things by using 'show_utf8()' that already checks for NULL internally. I've created a pull request, and while testing it I found another (pretty harmless) bug in xml

Re: road to 4.9

2019-07-14 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 10:18 AM Linus Torvalds wrote: > > Maybe a patch like the attached? Better version here - this does the save-git case too, and simplifies things by using 'show_utf8()' that already checks for NULL internally. Linus core/dive.c | 2 +- core/dive.h |

Re: road to 4.9

2019-07-14 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 6:16 AM Steve wrote: > > (gdb) where > #0 0x00708fcd in save_cylinder_info (dive=0xc34f240, > b=0x7fffc2c0) at /home/steve/src/subsurface/core/save-xml.c:193 Interesting. It looks like you likely have an odd cylinder "use" string that you load, resulting in c

Re: road to 4.9

2019-07-14 Thread Steve
On Sun, 2019-07-14 at 10:03 +0200, Berthold Stoeger wrote: > Hi Steve, > > > > On Sunday, 14 July 2019 08:00:44 CEST Steve wrote: > > > I had a quick chance today to setup a build environment, I also > found > > > something that consistently caused it to crash which was loading > from > > >

Re: road to 4.9

2019-07-14 Thread Berthold Stoeger
Hi Steve, On Sunday, 14 July 2019 08:00:44 CEST Steve wrote: > I had a quick chance today to setup a build environment, I also found > something that consistently caused it to crash which was loading from > cloud and then trying to save to a local file.eg: load from cloud, then > file save as choo

Re: road to 4.9

2019-07-13 Thread Steve
On Mon, 2019-06-24 at 12:50 +0800, Dirk Hohndel wrote: > Hi Steve, > Thanks for the testing and reports (and update to old reports on > GitHub). > This is so incredibly useful to me > > > On Jun 24, 2019, at 11:42 AM, Steve > > wrote: > > > > When editing a dive date the date chooser is jumping

Re: road to 4.9

2019-07-06 Thread Benjamin
Hebrew translation is updated. Unless more strings have been added in the last 24 hours... Benjamin On Thu, 4 Jul 2019 at 04:56, Dirk Hohndel wrote: > I don't see any show stoppers listed. I'm trying to track down a few small > things, but overall I think we are getting close. > Let's aim for a

Re: road to 4.9

2019-07-03 Thread Dirk Hohndel
I don't see any show stoppers listed. I'm trying to track down a few small things, but overall I think we are getting close. Let's aim for a release in about a week or so? That means we need the missing pieces to the user manual (and I can help edit that), we need the missing translations, and w

Re: road to 4.9

2019-06-25 Thread Robert Helling
Hi, > On 22. Jun 2019, at 20:45, Dirk Hohndel wrote: > > I will be traveling the next two weeks and should as part of this have > plenty of opportunity to test Subsurface (Linux and Mac) and > Subsurface-mobile (Android). Hopefully that will help me get a better idea > how close we are to being

Re: road to 4.9

2019-06-25 Thread Miika Turkia
On Tue, Jun 25, 2019 at 9:56 AM Dirk Hohndel wrote: > > > On Jun 18, 2019, at 11:20 PM, Dirk Hohndel wrote: > > > > What we need are translations, documentation, and testing. A lot of > testing. > > The reproducible problems around the undo code have been fixed (thanks > Berthold - and actually

Re: road to 4.9

2019-06-24 Thread Dirk Hohndel
> On Jun 18, 2019, at 11:20 PM, Dirk Hohndel wrote: > > What we need are translations, documentation, and testing. A lot of testing. We are starting to see more testing. THANK YOU for that. I pushed the latest strings and we see the first translations coming in - also, THANK YOU. The reproduc

Re: road to 4.9

2019-06-23 Thread Dirk Hohndel
Hi Steve, Thanks for the testing and reports (and update to old reports on GitHub). This is so incredibly useful to me > On Jun 24, 2019, at 11:42 AM, Steve wrote: > > When editing a dive date the date chooser is jumping all over the place > and not choosing the correct dates. This one I belie

RE: road to 4.9

2019-06-23 Thread Steve
Subject: Re: road to 4.9 On Sat, Jun 22, 2019 at 12:11:31PM -0700, Doug Junkins wrote: > Laurie and I have been testing the latest master, but unfortunately > work > has been getting in the way of me doing much development work. I have > had > a couple of opportunities to us

Re: road to 4.9

2019-06-22 Thread Dirk Hohndel
On Sat, Jun 22, 2019 at 12:11:31PM -0700, Doug Junkins wrote: > > Laurie and I have been testing the latest master, but unfortunately work has > been getting in the way of me doing much development work. I have had a > couple of opportunities to use the dive site export and import functions to

Re: road to 4.9

2019-06-22 Thread Doug Junkins
Dirk, Laurie and I have been testing the latest master, but unfortunately work has been getting in the way of me doing much development work. I have had a couple of opportunities to use the dive site export and import functions to share sites with Laurie and have not run into any issues. I ho

Re: road to 4.9

2019-06-22 Thread Dirk Hohndel
I feel a bit like I'm talking to myself here. Willem responded privately about the user manual and also reported a bug. Is anyone else testing? I did see several of the translators worked on the new strings that I pushed - my heartfelt thanks for this. I will be traveling the next two weeks and s