Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-16 Thread Monty Taylor
On 4/14/19 2:38 PM, Doug Junkins wrote: On Apr 14, 2019, at 7:03 AM, Dirk Hohndel wrote: On Apr 14, 2019, at 1:50 AM, Willem Ferguson wrote: For those that have strong feelings about dive sites, one would like to have an option of: c) Create a dive site I can see the logic in that

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-16 Thread Monty Taylor
On 4/13/19 4:27 PM, Dirk Hohndel wrote: While I still haven't announced 4.8.6 (I'm on the plane back home - I think I'll announce it later today), I wanted to start the conversation about 4.9. We just merged a massive PR from Berthold that brings something that Henrik and others have asked

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Willem Ferguson
On 2019/04/14 16:03, Dirk Hohndel wrote: On Apr 14, 2019, at 1:50 AM, Willem Ferguson wrote: 1) The dive site panel makes huge strides towards a robust but flexible interface for working with dive sites. The current actions are: a) Edit a dive site b) Delete a dive site For those that have

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Doug Junkins
> On Apr 14, 2019, at 7:03 AM, Dirk Hohndel wrote: > > >> On Apr 14, 2019, at 1:50 AM, Willem Ferguson >> wrote: >> >> For those that have strong feelings about dive sites, one would like to have >> an option of: >> >> c) Create a dive site > > I can see the logic in that. I'd be unlikel

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Dirk Hohndel
> On Apr 14, 2019, at 1:50 AM, Willem Ferguson > wrote: > > 1) The dive site panel makes huge strides towards a robust but flexible > interface for working with dive sites. The current actions are: > > a) Edit a dive site > > b) Delete a dive site > > For those that have strong feelings abo

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Willem Ferguson
Thanks so much, Berthold. Wf On Sun, 14 Apr 2019, 11:57 Berthold Stoeger Hi Willem, > > On Sonntag, 14. April 2019 10:50:50 CEST Willem Ferguson wrote: > > > d) Merge dive sites > > > > As was apparent in the discussions on this topic I also have many > > duplicate dive sites and they definitely

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Berthold Stoeger
Hi Willem, On Sonntag, 14. April 2019 10:50:50 CEST Willem Ferguson wrote: > d) Merge dive sites > > As was apparent in the discussions on this topic I also have many > duplicate dive sites and they definitely need reorganisation. If the dive sites have coordinates, you can do this in current m

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-14 Thread Willem Ferguson
Question: 1) The dive site panel makes huge strides towards a robust but flexible interface for working with dive sites. The current actions are: a) Edit a dive site b) Delete a dive site For those that have strong feelings about dive sites, one would like to have an option of: c) Create

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Dirk Hohndel
> On Apr 13, 2019, at 2:06 PM, Salvador Cuñat wrote: > Forget the issue, it has gone after blowing away the build directory > and making a clean build. > Sorry for the noise. Don't worry about it. While cmake has been MUCH better for me lately, I still have the occasional build failure that mag

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Salvador Cuñat
Hi again Berthold. On Sat, Apr 13, 2019 at 10:53:00PM +0200, Salvador Cuñat wrote: > Hi Berthold > > On Sat, Apr 13, 2019 at 09:25:32PM +0200, Berthold Stoeger wrote: > > > > On Linux this should be fixed with commit b98ac90c43. On Mac Dirk still > > sees > > the problem if I understood correc

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Salvador Cuñat
Hi Berthold On Sat, Apr 13, 2019 at 09:25:32PM +0200, Berthold Stoeger wrote: > > On Linux this should be fixed with commit b98ac90c43. On Mac Dirk still sees > the problem if I understood correctly. > Well, it is not for me. I'm currently at 5966a74 which should include b98ac90c, on debian sid

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Dirk Hohndel
> On Apr 13, 2019, at 1:19 PM, Doug Junkins wrote: >> On Samstag, 13. April 2019 21:19:00 CEST Salvador Cuñat wrote: >> >>> In a first try, the only thing I've noticed to fail is autocompletion >>> in "Dive Master", "Buddy" and "Tags", while it works fine in "suit" >>> and in "Divesite". >> >>

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Doug Junkins
> On Apr 13, 2019, at 12:25 PM, Berthold Stoeger > wrote: > > Hi Salva, > > On Samstag, 13. April 2019 21:19:00 CEST Salvador Cuñat wrote: > >> In a first try, the only thing I've noticed to fail is autocompletion >> in "Dive Master", "Buddy" and "Tags", while it works fine in "suit" >> and i

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Berthold Stoeger
Hi Salva, On Samstag, 13. April 2019 21:19:00 CEST Salvador Cuñat wrote: > In a first try, the only thing I've noticed to fail is autocompletion > in "Dive Master", "Buddy" and "Tags", while it works fine in "suit" > and in "Divesite". On Linux this should be fixed with commit b98ac90c43. On Mac

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Salvador Cuñat
Good night. On Sat, Apr 13, 2019 at 09:27:30AM -0700, Dirk Hohndel wrote: > > There are a couple of exceptions: tanks, weights, and editing the dive points > of a manually added dives by dragging things around in the profile. Those > still use the old accept / reject concept (which creates a ra

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Doug Junkins
> On Apr 13, 2019, at 9:54 AM, Dirk Hohndel wrote: > > >> On Apr 13, 2019, at 9:50 AM, Doug Junkins wrote: >> >> Dirk, >> >> One thing I have been contemplating now that dive sites can be managed >> independent of dives is that it should be possible to create a dive site on >> the mobile

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Dirk Hohndel
> On Apr 13, 2019, at 9:50 AM, Doug Junkins wrote: > > Dirk, > > One thing I have been contemplating now that dive sites can be managed > independent of dives is that it should be possible to create a dive site on > the mobile app (either from the current location or from a saved GPS fix) >

Re: dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Doug Junkins
Dirk, One thing I have been contemplating now that dive sites can be managed independent of dives is that it should be possible to create a dive site on the mobile app (either from the current location or from a saved GPS fix) that can later be used when a dive is imported from a dive computer

dive sites, edit undo, and the major steps towards 4.9

2019-04-13 Thread Dirk Hohndel
While I still haven't announced 4.8.6 (I'm on the plane back home - I think I'll announce it later today), I wanted to start the conversation about 4.9. We just merged a massive PR from Berthold that brings something that Henrik and others have asked for for a very long time. Dive sites are bec