Re: great progress on dive site handling

2015-06-29 Thread Thiago Macieira
On Monday 29 June 2015 11:07:08 Dirk Hohndel wrote: > Thanks Thiago for taking a look. It confused me that this would thrown a > SIGSEGV in the pixel() function and not when dereferencing m_title to get > to the pixel member function... It wouldn't because pixel() is not a virtual function. A non

Re: great progress on dive site handling

2015-06-29 Thread Dirk Hohndel
On Mon, Jun 29, 2015 at 10:58:57AM -0700, Thiago Macieira wrote: > On Monday 29 June 2015 06:59:55 Dirk Hohndel wrote: > > > >> (gdb) bt > > > >> #0 Marble::StackedTile::pixel (this=0x0, x=36, y=30) at > > > >> /home/mturkia/source/static/test/marble-source/src/lib/marble/StackedT > > > >> ile.cpp

Re: great progress on dive site handling

2015-06-29 Thread Thiago Macieira
On Monday 29 June 2015 06:59:55 Dirk Hohndel wrote: > > >> (gdb) bt > > >> #0 Marble::StackedTile::pixel (this=0x0, x=36, y=30) at > > >> /home/mturkia/source/static/test/marble-source/src/lib/marble/StackedT > > >> ile.cpp:85> > > > > Hmm. this=0x0 - that would explain the crash when accessing a

Re: great progress on dive site handling

2015-06-29 Thread Dirk Hohndel
On Mon, Jun 29, 2015 at 05:09:23PM +0800, Miika Turkia wrote: > >> This sounds like sane logic to me. However, I do also see your concern > >> about this if one only records the site name on that field. I still > >> type the locations like "Indonesia - Lembeh Strait - Hairball" so I am > >> not goi

Re: great progress on dive site handling

2015-06-29 Thread Miika Turkia
On Mon, Jun 29, 2015 at 12:05 AM, Dirk Hohndel wrote: > On Sun, Jun 28, 2015 at 05:27:16PM +0800, Miika Turkia wrote: >> > >> > With the commit I just pushed the following happens. >> > >> > IFF you have a dive site that was downloaded from the companion app and >> > IFF you either type in a new n

Re: great progress on dive site handling

2015-06-28 Thread Miika Turkia
On Mon, Jun 29, 2015 at 12:06 AM, Dirk Hohndel wrote: > On Sun, Jun 28, 2015 at 06:21:59PM +0800, Miika Turkia wrote: >> Well, seems that the recent changes prevent me from accessing the dive >> site management. ("Log - Manage dive sites" does nothing for me.) > > Yep, that's temporarily disabled.

Re: great progress on dive site handling

2015-06-28 Thread Dirk Hohndel
On Sun, Jun 28, 2015 at 06:21:59PM +0800, Miika Turkia wrote: > Well, seems that the recent changes prevent me from accessing the dive > site management. ("Log - Manage dive sites" does nothing for me.) Yep, that's temporarily disabled. > I also got incorrect GPS fix for a dive, but deleting the

Re: great progress on dive site handling

2015-06-28 Thread Dirk Hohndel
On Sun, Jun 28, 2015 at 05:27:16PM +0800, Miika Turkia wrote: > > > > With the commit I just pushed the following happens. > > > > IFF you have a dive site that was downloaded from the companion app and > > IFF you either type in a new name or you type in an existing dive site > > name that has no

Re: great progress on dive site handling

2015-06-28 Thread Miika Turkia
Well, seems that the recent changes prevent me from accessing the dive site management. ("Log - Manage dive sites" does nothing for me.) I also got incorrect GPS fix for a dive, but deleting the site manually and re-syncing GPS fixed that. I have no idea how that happened. Or could it be that the

Re: great progress on dive site handling

2015-06-28 Thread Miika Turkia
On Sun, Jun 28, 2015 at 2:27 PM, Dirk Hohndel wrote: > On Sun, Jun 28, 2015 at 06:35:25AM +0800, Miika Turkia wrote: >> >> I had the site on my log with only a name, no coordinates. Now I dove >> there again with companion app. Synced the GPS data and then selected >> the name of the dive site. Th

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sun, Jun 28, 2015 at 06:35:25AM +0800, Miika Turkia wrote: > > I had the site on my log with only a name, no coordinates. Now I dove > there again with companion app. Synced the GPS data and then selected > the name of the dive site. This replaced all info from the old dive > site, overwriting

Re: great progress on dive site handling

2015-06-27 Thread Tomaz Canabrava
On Sat, Jun 27, 2015 at 10:51 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > On Sat, Jun 27, 2015 at 6:32 PM, Dirk Hohndel wrote: > > > > I guess we simply and fundamentally disagree on what a reasonable > workflow > > would be. And you would never, ever, EVER think that what you pr

Re: great progress on dive site handling

2015-06-27 Thread Linus Torvalds
On Sat, Jun 27, 2015 at 6:32 PM, Dirk Hohndel wrote: > > I guess we simply and fundamentally disagree on what a reasonable workflow > would be. And you would never, ever, EVER think that what you propose was > reasonable in this scenario: > > You have a dive site named Fishbowl, but you don't have

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
> On Jun 27, 2015, at 6:39 PM, Linus Torvalds > wrote: > > On Sat, Jun 27, 2015 at 6:32 PM, Dirk Hohndel wrote: >> >> Why would you do such a thing. You download your dives from your dive >> computer. You enter the names of the dive sites. Then you download the GPS >> data. What is the semant

Re: great progress on dive site handling

2015-06-27 Thread Linus Torvalds
On Sat, Jun 27, 2015 at 6:32 PM, Dirk Hohndel wrote: > > Why would you do such a thing. You download your dives from your dive > computer. You enter the names of the dive sites. Then you download the GPS > data. What is the semantic of loading GPS data for sites that don't have > names? You never

Re: great progress on dive site handling

2015-06-27 Thread Tomaz Canabrava
People, maybe we could add something to state that you are changing divesites when you change the divesite on the dive info tool? Linus, I think I can manage to create an interface that state correctly what`s happening, will try to sketch it up tomorrow. toamz ___

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sat, Jun 27, 2015 at 05:42:13PM -0700, Linus Torvalds wrote: > On Sat, Jun 27, 2015 at 5:01 PM, Dirk Hohndel wrote: > > > > This has been rewritten since last week. > > Dirk, I have tried the new thing. The "obvious thing" is as broken as > it ever was. > > The sane and natural thing DOES NOT

Re: great progress on dive site handling

2015-06-27 Thread Linus Torvalds
On Sat, Jun 27, 2015 at 5:01 PM, Dirk Hohndel wrote: > > This has been rewritten since last week. Dirk, I have tried the new thing. The "obvious thing" is as broken as it ever was. The sane and natural thing DOES NOT WORK. What you need to do right now is insane. Let me walk you through it.

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sat, Jun 27, 2015 at 04:27:04PM -0700, Linus Torvalds wrote: > On Jun 27, 2015 4:13 PM, "Dirk Hohndel" wrote: > > > > Yes. You basically switched to an existing dive site. If you had done it > > the way ${DEITY} intended (i.e., FIRST set the dive site and THEN imported > > the GPS data), everyt

Re: great progress on dive site handling

2015-06-27 Thread Linus Torvalds
On Jun 27, 2015 4:27 PM, "Linus Torvalds" wrote: > > I did this last week, and Miika is right, and you are wrong. GPS first, then naming the dive site. The location you see on the map is what often reminds you what the site *was*. BTW, what I ended up doing once, because it was so broken, was to

Re: great progress on dive site handling

2015-06-27 Thread Linus Torvalds
On Jun 27, 2015 4:13 PM, "Dirk Hohndel" wrote: > > Yes. You basically switched to an existing dive site. If you had done it > the way ${DEITY} intended (i.e., FIRST set the dive site and THEN imported > the GPS data), everything would have worked. Dirk, I don't think you've actually used it, beca

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sun, Jun 28, 2015 at 06:35:25AM +0800, Miika Turkia wrote: > >> > >> Here is something from a very quick test: > >> > >> - Not able to zoom into the map when in edit location mode. Have to > >> get rid of the popup to pick a site. After discussing this a bit I came to the conclusion that I wa

Re: great progress on dive site handling

2015-06-27 Thread Miika Turkia
> On 27 Jun 2015, at 20:49, Dirk Hohndel wrote: > >> On Sat, Jun 27, 2015 at 01:47:08PM +0800, Miika Turkia wrote: >>> On Sat, Jun 27, 2015 at 1:27 PM, Dirk Hohndel wrote: >>> >>> >>> On Jun 26, 2015, at 22:19, Davide DB wrote: >>> >>> Thank you Tomaz and Dirk. >>> I'm diving now, I will

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sat, Jun 27, 2015 at 05:49:52AM -0700, Dirk Hohndel wrote: > > > - Dive site name edit goes to edit mode when focus is lost, not while > > editing > > Also noticed that. Easy to fix That one is fixed /D ___ subsurface mailing list subsurface@subsu

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sat, Jun 27, 2015 at 08:52:46AM +0200, Joakim Bygdell wrote: > > > On 27 Jun 2015, at 5:53, Dirk Hohndel wrote: > > > > Thanks to Tomaz for continuing to work on this. > > > > The poor guy did two complete implementations that we ended up rejecting, > > now he's started the third rewrite. An

Re: great progress on dive site handling

2015-06-27 Thread Dirk Hohndel
On Sat, Jun 27, 2015 at 01:47:08PM +0800, Miika Turkia wrote: > On Sat, Jun 27, 2015 at 1:27 PM, Dirk Hohndel wrote: > > > > > > On Jun 26, 2015, at 22:19, Davide DB wrote: > > > > Thank you Tomaz and Dirk. > > I'm diving now, I will test it as I come back home. > > > > > > Thank you for taking t

Re: great progress on dive site handling

2015-06-26 Thread Joakim Bygdell
> On 27 Jun 2015, at 5:53, Dirk Hohndel wrote: > > Thanks to Tomaz for continuing to work on this. > > The poor guy did two complete implementations that we ended up rejecting, > now he's started the third rewrite. And I think this one is promising. > Davide, this is not a departure from what y

Re: great progress on dive site handling

2015-06-26 Thread Miika Turkia
On Sat, Jun 27, 2015 at 1:27 PM, Dirk Hohndel wrote: > > > On Jun 26, 2015, at 22:19, Davide DB wrote: > > Thank you Tomaz and Dirk. > I'm diving now, I will test it as I come back home. > > > Thank you for taking the time to collect data to use in testing Subsurface. > You and Miika both are rol

Re: great progress on dive site handling

2015-06-26 Thread Dirk Hohndel
> On Jun 26, 2015, at 22:19, Davide DB wrote: > > Thank you Tomaz and Dirk. > I'm diving now, I will test it as I come back home. > Thank you for taking the time to collect data to use in testing Subsurface. You and Miika both are role models. I need to do that more often. Oh wait, I was div

Re: great progress on dive site handling

2015-06-26 Thread Davide DB
Thank you Tomaz and Dirk. I'm diving now, I will test it as I come back home. davide@mobile ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

great progress on dive site handling

2015-06-26 Thread Dirk Hohndel
Thanks to Tomaz for continuing to work on this. The poor guy did two complete implementations that we ended up rejecting, now he's started the third rewrite. And I think this one is promising. Davide, this is not a departure from what you suggested but a small addition - something that was doable