Re: manual edit of depth and time when adding / editing dives

2017-03-05 Thread Dirk Hohndel
On Sun, Mar 05, 2017 at 03:12:56PM +0100, Stefan Fuchs wrote: > Hello Dirk, > > Am 05.03.2017 um 07:42 schrieb Dirk Hohndel: > > On Sat, Mar 04, 2017 at 07:59:57AM +0100, Stefan Fuchs wrote: > >> Good morning, > >> > >> Update, still no real debug built but GDB also with this exe gives some > >>

Re: manual edit of depth and time when adding / editing dives

2017-03-05 Thread Stefan Fuchs
Hello Dirk, Am 05.03.2017 um 07:42 schrieb Dirk Hohndel: > On Sat, Mar 04, 2017 at 07:59:57AM +0100, Stefan Fuchs wrote: >> Good morning, >> >> Update, still no real debug built but GDB also with this exe gives some >> hints :-) > I believe that I may have figured out what was causing the crashes

Re: manual edit of depth and time when adding / editing dives

2017-03-04 Thread Dirk Hohndel
On Sat, Mar 04, 2017 at 07:59:57AM +0100, Stefan Fuchs wrote: > Good morning, > > Update, still no real debug built but GDB also with this exe gives some > hints :-) I believe that I may have figured out what was causing the crashes for you. Can you test the latest master (I merged this into

Re: manual edit of depth and time when adding / editing dives

2017-03-03 Thread Stefan Fuchs
Good morning, Update, still no real debug built but GDB also with this exe gives some hints :-) Am 03.03.2017 um 21:11 schrieb Stefan Fuchs: > > Hallo Dirk, > > Am 26.02.2017 um 22:57 schrieb Dirk Hohndel: >> On Sun, Feb 26, 2017 at 08:43:40AM -0800, Dirk Hohndel wrote: >>> >>> I still don't

Re: manual edit of depth and time when adding / editing dives

2017-03-03 Thread Stefan Fuchs
Hallo Dirk, Am 26.02.2017 um 22:57 schrieb Dirk Hohndel: > On Sun, Feb 26, 2017 at 08:43:40AM -0800, Dirk Hohndel wrote: >> >> I still don't feel comfortable adding this to 4.6.3 right now, but maybe >> that will get delayed? I'll need to check progress on the translations, I >> guess. >> >> If a

Re: manual edit of depth and time when adding / editing dives

2017-02-26 Thread Dirk Hohndel
On Sun, Feb 26, 2017 at 08:43:40AM -0800, Dirk Hohndel wrote: > On Sun, Feb 26, 2017 at 02:29:12PM +0100, Robert Helling wrote: > > Dirk, > > > > > On 26 Feb 2017, at 06:22, Dirk Hohndel wrote: > > > > > > Please let me know what you think... > > > > except for dereferencing

Re: manual edit of depth and time when adding / editing dives

2017-02-26 Thread Dirk Hohndel
On Sun, Feb 26, 2017 at 02:29:12PM +0100, Robert Helling wrote: > Dirk, > > > On 26 Feb 2017, at 06:22, Dirk Hohndel wrote: > > > > Please let me know what you think... > > except for dereferencing a potentially NULL current_dive (see my comment on > github) this looks good

Re: manual edit of depth and time when adding / editing dives

2017-02-26 Thread Robert Helling
Dirk, > On 26 Feb 2017, at 06:22, Dirk Hohndel wrote: > > Please let me know what you think... except for dereferencing a potentially NULL current_dive (see my comment on github) this looks good and safe to me. Best Robert signature.asc Description: Message signed with

manual edit of depth and time when adding / editing dives

2017-02-25 Thread Dirk Hohndel
We had quite a few requests for this feature, so I worked on this off and on over the past month or so. Given that I really want to cut 4.6.3 once the translators had a chance to finish things up, I haven't pushed this to master, but instead pushed the manualDepthTime branch to GitHub. It's