Re: subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
icons. On Sat, Mar 5, 2016 at 8:19 PM, Tomaz Canabrava wrote: > forget this last patch, it breaks deployment for some reason. > > On Sat, Mar 5, 2016 at 3:57 PM, Tomaz Canabrava > wrote: > >> this cleans the CMakeLists file (it reverts to master) and removes some >> noise on the dumb project fo

Re: subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
forget this last patch, it breaks deployment for some reason. On Sat, Mar 5, 2016 at 3:57 PM, Tomaz Canabrava wrote: > this cleans the CMakeLists file (it reverts to master) and removes some > noise on the dumb project for iOS. > > > On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava > wrote: > >>

Re: subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
this cleans the CMakeLists file (it reverts to master) and removes some noise on the dumb project for iOS. On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava wrote: > > > On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel wrote: > >> Sadly the patches are base64 encoded (typical Mac issue) and I can't

Re: subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel wrote: > Sadly the patches are base64 encoded (typical Mac issue) and I can't > easily quote them in there. > > A few comments: > > If you don't use cmake, why patches to the CMakeLists.txt file? That seems > to make no sense (oh, and it's whitespace d

Re: subsurface-ios first patches

2016-03-05 Thread Dirk Hohndel
Sadly the patches are base64 encoded (typical Mac issue) and I can't easily quote them in there. A few comments: If you don't use cmake, why patches to the CMakeLists.txt file? That seems to make no sense (oh, and it's whitespace damaged, too) There are also changes to the CMakeLists.txt files in

Re: subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
On Sat, Mar 5, 2016 at 1:43 PM, Dirk Hohndel wrote: > On Sat, Mar 05, 2016 at 01:27:44PM -0300, Tomaz Canabrava wrote: > > people: > > > > This will work only with Qt 5.6 for now, so don't even try with 5.5 > > the prerequisites should be build for x86_64 bits, and qt 5.5 is build > for > > 32 bi

Re: subsurface-ios first patches

2016-03-05 Thread Dirk Hohndel
On Sat, Mar 05, 2016 at 01:27:44PM -0300, Tomaz Canabrava wrote: > people: > > This will work only with Qt 5.6 for now, so don't even try with 5.5 > the prerequisites should be build for x86_64 bits, and qt 5.5 is build for > 32 bits, giving tons of erros. > > I tested the desktop build, it works

subsurface-ios first patches

2016-03-05 Thread Tomaz Canabrava
people: This will work only with Qt 5.6 for now, so don't even try with 5.5 the prerequisites should be build for x86_64 bits, and qt 5.5 is build for 32 bits, giving tons of erros. I tested the desktop build, it works android build also works, ios builds are currently "meh", they open but don't