On Thu, Oct 28, 2010 at 03:44:37PM -0300, Gonzalo Odiard wrote:
I think the problem is the code is rendering the svg icon every time
the color is changed.
Indeed. As James Cameron pointed out, we're setting the stroke and
fill in rapid succession, resulting in two calls to render().
There
On Fri, Oct 29, 2010 at 10:56:25AM +1100, James Cameron wrote:
On Thu, Oct 28, 2010 at 03:44:37PM -0300, Gonzalo Odiard wrote:
I think the problem is the code is rendering the svg icon every time
the color is changed. There are not cache or cairo operation used to
avoid this.
I agree.
On Thu, Oct 28, 2010 at 10:19:37PM -0400, Bernie Innocenti wrote:
[cc += fgrose,m_stone]
On Wed, 2010-10-27 at 06:19 +0100, Martin Dengler wrote:
On Wed, Oct 27, 2010 at 06:05:58AM +0530, Manusheel Gupta wrote:
Are we ready to commit this patch?
Well, it's only a year after there
On Fri, Oct 29, 2010 at 09:47:33AM +0100, Martin Dengler wrote:
On Fri, Oct 29, 2010 at 10:56:25AM +1100, James Cameron wrote:
On Thu, Oct 28, 2010 at 03:44:37PM -0300, Gonzalo Odiard wrote:
I think the problem is the code is rendering the svg icon every time
the color is changed. There
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Caught by PEP8. This is important for Sugar because the XO has a small screen
where long lines would make the code hard to understand (because you need to
constantly scroll horizontally).
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
has_key() has been deprecated for quite some time now.
[...]
diff --git a/src/sugar/graphics/style.py b/src/sugar/graphics/style.py
index 2828b7f..d5f82ff 100644
--- a/src/sugar/graphics/style.py
+++ b/src/sugar/graphics/style.py
@@ -35,12 +35,11 @@
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py
index 3f5188e..2b01366 100644
--- a/src/sugar/datastore/datastore.py
+++
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Caught by pep8.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/examples/radiopalette.py b/examples/radiopalette.py
index 85b43ce..f8336bd 100644
--- a/examples/radiopalette.py
+++
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
I've left the powers as-is because IMO they should directly follow the base,
unlike other operators.
Hmmm, I see your argument, however I think it is not worth to make an
exception here.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
pep8 wants inline comments to be prefixed by at least two spaces. Let's just
move them to a separate line as that's easier to read anyway.
In the second case in this patch I think having them in the same line is
easier to read. Might be taste. A
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 0094693..e3654d8 100644
--- a/src/sugar/activity/activity.py
+++
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/graphics/style.py b/src/sugar/graphics/style.py
index d5f82ff..7f48d9a 100644
--- a/src/sugar/graphics/style.py
+++
Reviewed-by: Simon Schampijer si...@laptop.org
Yes, we should set on one and mark this in our coding style document.
Btw, we should update that as well.
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Most of the code uses , so adjust the few deviations.
Signed-off-by: Sascha
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Tomeu prefers ' for strings, so let's use it wherever we don't have a good
reason to use .
Reviewed-by: Simon Schampijer si...@laptop.org
We just have to set on one and make a note in the Sugar coding style
document.
Signed-off-by: Sascha
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Adapt to upstream format change.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/activity/activityfactory.py
b/src/sugar/activity/activityfactory.py
index 6bd661f..a206d15 100644
Reviewed-by: Simon Schampijer si...@laptop.org
CONNECTION is just not used I guess?
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/presence/connectionmanager.py
b/src/sugar/presence/connectionmanager.py
index
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
logging.exception() handles exceptions nicely for us, no need to explicitly
use traceback.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/util.py b/src/sugar/util.py
index
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 64bc840..7229096 100644
--- a/src/sugar/activity/activity.py
+++
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
This avoids the overhead from the string formatting on production systems.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index eaa196e..00c6fd0 100644
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics/palettewindow.py
index fcdc2e3..81540e3 100644
---
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
Caught by pylint. I wonder if we need this piece of code as nobody every
triggered it.
Hmm, or triggered without knowing. Let's just fix it.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/graphics/palettewindow.py
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
format is the name of a parameter of the function we are wrapping, so we
shouldn't change it.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
pylint isn't smart enough to figure out the return type of Popen.communicate(),
so squelch the warning.
Signed-off-by: Sascha Silbesascha-...@silbe.org
diff --git a/src/sugar/activity/bundlebuilder.py
Reviewed-by: Simon Schampijer si...@laptop.org
On 10/15/2010 11:01 PM, Sascha Silbe wrote:
We know that our code is correct and column should always be assigned, but it
never hurts to act defensively and guard against bugs in other pieces of the
code (or other components like GTK).
On Fri, Oct 29, 2010 at 09:47:33AM +0100, Martin Dengler wrote:
+N = 10.0
+self._level = round((math.sin(self._phase) + 1) / 2, 3)
...and I didn't see much change with my test program[1]:
Ah, right. Sorry I missed that. round(x, 3) will get you 1000 unique
images. Perhaps
Commited, thanks.
Gonzalo
On Thu, Oct 28, 2010 at 5:17 PM, Ayush Goyal ay...@seeta.in wrote:
Added fixed aspect ratio mode for line,ellipse and rectangle tool using
Shift
key as mask or using a keep aspect ratio checkbox from palette.This allows
drawing of straight lines 45 degree lines
Activity Homepage:
http://activities.sugarlabs.org/addon/4264
Sugar Platform:
0.82 - 0.90
Download Now:
http://activities.sugarlabs.org/downloads/file/27088/distance-21.xo
Release notes:
This release contains a change from Gonzalo Odiard that is designed to improve
functionality on the XO-1.5
On 29 Oct 2010, at 09:12, Martin Dengler mar...@martindengler.com wrote:
On Thu, Oct 28, 2010 at 03:44:37PM -0300, Gonzalo Odiard wrote:
I think the problem is the code is rendering the svg icon every time
the color is changed.
Indeed. As James Cameron pointed out, we're setting the stroke
On 29 Oct 2010, at 10:02, Martin Dengler mar...@martindengler.com wrote:
On Thu, Oct 28, 2010 at 10:19:37PM -0400, Bernie Innocenti wrote:
[cc += fgrose,m_stone]
On Wed, 2010-10-27 at 06:19 +0100, Martin Dengler wrote:
On Wed, Oct 27, 2010 at 06:05:58AM +0530, Manusheel Gupta wrote:
Are
-- Forwarded message --
From: lucas matias camaño lmrock...@gmail.com
Date: 2010/10/29
Subject: [Sur] una duda
To: olpc-...@lists.laptop.org
Hola a todos!!
mi nombre es Lucas y trabajo en la Secretaría de Prevención de
Adicciones de La Rioja Argentina.
mi inquietud es la
On Thu, Oct 28, 2010 at 1:42 PM, Martin Dengler
mar...@martindengler.com wrote:
There is a better way: use cProfile and gprof2dot.py. You will get
graphs (and of course the raw data) like this:
http://www.martindengler.com/tmp/sl.o-2080/pulsingicon.py-stats-graph.png
Excellent graph.
But
We have summed up our recent work on feature requests and bug fixing at
http://wiki.sugarlabs.org/go/Dextrose/BugBashing.
It would be great if patches on SL #305 (Checkbox outline changed when
activated) and #2201 (Clipboard menu offscreen) could be reviewed.
Regards,
Manu
On Sat, 2010-10-30 at 04:07 +0530, Manusheel Gupta wrote:
We have summed up our recent work on feature requests and bug fixing
at http://wiki.sugarlabs.org/go/Dextrose/BugBashing.
This summary is *neat*!
It would be great if patches on SL #305 (Checkbox outline changed when
activated)
This
Hi all,
While answering to Michael's questions (though questions are still not
fully answered but restructured, since the right question is 51% of an
answer), I've composed a document which is a result of my, 2y, being
a FOSS contributor and sugar participant:
34 matches
Mail list logo
