Re: [Sugar-devel] [PATCH sugar v2 00/21] style cleanup series

2010-11-24 Thread Simon Schampijer
On 11/24/2010 09:38 PM, Sascha Silbe wrote: Excerpts from Sascha Silbe's message of Fri Nov 19 22:13:08 +0100 2010: This is the sugar part of the style cleanups I've wanted to land at least two releases ago, but kept missing the window. Series reviewed by Simon on #sugar and pushed. Sascha

[Sugar-devel] Sugar SURVEY reminder -- Please take!

2010-11-24 Thread Julie Lein
Hi Sugar Community, Just a reminder to PLEASE take the survey to help our team learn about Sugar: https://survey.qualtrics.com/SE/?SID=SV_eD8yvVjHSnPhxek THANK YOU! Alex Fallow (afal...@mit.edu) Laura Guaglianone (lguag...@mit.edu) Julie Lein (j2u...@mit.edu) Parul Singh (pa...@mit.edu) _

Re: [Sugar-devel] [PATCH] Apply new version scheme as well to content bundles #2425

2010-11-24 Thread James Cameron
Reviewed-by: James Cameron -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] sugar 0.84 activity registry

2010-11-24 Thread James Cameron
On Wed, Nov 24, 2010 at 02:51:03PM +0200, Tony Anderson wrote: > I am trying the DataManager activity on 0.84. The activity.registry > seems to have been deleted or changed. > > from sugar.activity import registry This line fails from 0.84 onwards, yes. > Is this an oversight or is this function

[Sugar-devel] [PATCH sugar] test patch for Patchwork, please ignore

2010-11-24 Thread Sascha Silbe
Testing prefix stripping for Patchwork, please ignore. Signed-off-by: Sascha Silbe --- bin/sugar.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bin/sugar.in b/bin/sugar.in index 12098db..24378cf 100644 --- a/bin/sugar.in +++ b/bin/sugar.in @@ -1,6 +1,7 @@ #!/bin/sh

[Sugar-devel] [PATCH sugar] about my computer, check wlan0 before eth0

2010-11-24 Thread James Cameron
On recent Fedora distributions, wireless ethernet devices appear as wlan0 instead of eth0. This causes "About my Computer" to not show wireless firmware version. Affects XO-1 and XO-1.5 with Fedora 14. Patch tested on XO-1.5 with Fedora 11. http://dev.laptop.org/ticket/10478 --- extensions/cpse

[Sugar-devel] [PATCH] Apply new version scheme as well to content bundles #2425

2010-11-24 Thread Simon Schampijer
--- src/sugar/bundle/contentbundle.py | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/sugar/bundle/contentbundle.py b/src/sugar/bundle/contentbundle.py index 5411a0f..7e6be37 100644 --- a/src/sugar/bundle/contentbundle.py +++ b/src/sugar/bundle/contentbundle.

Re: [Sugar-devel] [PATCH] bundlebuilder does not install mimetypes.xml and associated icon #2262

2010-11-24 Thread Simon Schampijer
Thanks for the review! On 11/23/2010 07:53 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Mon Nov 22 18:42:32 +0100 2010: bundlebuilder does not install mimetypes.xml and associated icon #2262 I'd prefer describing the new, correct behaviour: bundlebuilder: install mime

Re: [Sugar-devel] [PATCH sugar v2 00/21] style cleanup series

2010-11-24 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Fri Nov 19 22:13:08 +0100 2010: > This is the sugar part of the style cleanups I've wanted to land at > least two releases ago, but kept missing the window. Series reviewed by Simon on #sugar and pushed. Sascha -- http://sascha.silbe.org/ http://www.infra

Re: [Sugar-devel] [PATCH sugar v2 06/21] PEP8 cleanup: ensure lines are shorter than 80 characters

2010-11-24 Thread Simon Schampijer
On 11/24/2010 08:30 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Wed Nov 24 19:24:40 +0100 2010: [src/jarabe/journal/model.py] -PROPERTIES = ['uid', 'title', 'mtime', 'timestamp', 'creation_time', 'filesize', - 'keep', 'buddies', 'icon-color', 'mime_type', '

Re: [Sugar-devel] [PATCH sugar v2 18/21] pylint cleanup: fix indentation

2010-11-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Nov 24 19:19:52 +0100 2010: [src/jarabe/desktop/activitieslist.py] > > if not os.access(activity_info.get_path(), os.W_OK) or \ > > -registry.is_activity_protected(self._bundle_id): > > -menu_item.props.sensitive

Re: [Sugar-devel] [PATCH sugar v2 06/21] PEP8 cleanup: ensure lines are shorter than 80 characters

2010-11-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Nov 24 19:24:40 +0100 2010: [src/jarabe/journal/model.py] > > -PROPERTIES = ['uid', 'title', 'mtime', 'timestamp', 'creation_time', > > 'filesize', > > - 'keep', 'buddies', 'icon-color', 'mime_type', 'progress', > > - 'acti

Re: [Sugar-devel] [ANNOUNCE] New Sugar Web chat

2010-11-24 Thread C. Scott Ananian
On Wed, Nov 24, 2010 at 8:19 AM, Aleksey Lim wrote: > Also, not sure if https should dramatically increase amount of traffic, > anyway could be check both instances: > >    http://chat.sugarlabs.org:9090/ >    https://chat.sugarlabs.org:9091/ It's not traffic, it's the number of round trips. Acc

Re: [Sugar-devel] [PATCH sugar v2 06/21] PEP8 cleanup: ensure lines are shorter than 80 characters

2010-11-24 Thread Simon Schampijer
On 11/19/2010 10:13 PM, Sascha Silbe wrote: This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --

Re: [Sugar-devel] [PATCH sugar v2 21/21] pylint cleanup: disable warnings for reasonable catch-all exception handlers

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/model/bundleregistry.py b/src/jarabe/model/bundleregistry.py index 71124a4..00d1106 100644 --- a/src/jarabe/model/bundleregis

Re: [Sugar-devel] [PATCH sugar v2 20/21] pylint cleanup: don't override variables from outer scope

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: If two different entities have the same name, things get messy. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py

Re: [Sugar-devel] [PATCH sugar v2 19/21] jarabe.desktop.schoolserver: mark helper functions and classes as private

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Only register_laptop and RegisterError are meant to be public API. Proper marking of private / public makes it easier to see which code changes break API (or not). Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by:

Re: [Sugar-devel] [PATCH sugar v2 18/21] pylint cleanup: fix indentation

2010-11-24 Thread Simon Schampijer
On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py index be60c4c..c25e523 100644 --- a/src/jarabe/desktop/activitieslist.py +++ b/src/jarabe/d

Re: [Sugar-devel] [PATCH sugar v2 17/21] pylint cleanup: don't override built-in objects

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index c9aee50..887c1c2 100644 --- a/extensions/deviceicon/network.py

Re: [Sugar-devel] [PATCH sugar v2 16/21] ignore incorrect pylint error E1101

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: pylint isn't smart enough to figure out the contents of ParseResult and gtk.Invisible, so squelch the warning. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/frame/clipboar

Re: [Sugar-devel] [PATCH sugar v2 15/21] CurrentActivityPalette: remove dead code

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: __active_window_changed_cb() is not referenced anywhere and contains broken code. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/view/palettes.py b/src/jarabe/view/palettes

Re: [Sugar-devel] [PATCH sugar v2 13/21] pylint cleanup: mark some variables as unused

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Follow the convention of marking known-unused (but required for de-marshalling purposes) variables by postfixing them with an underscore. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git

Re: [Sugar-devel] [PATCH sugar v2 12/21] use logging.exception() instead of logging.error(traceback.format_exc())

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/updater/backends/aslo.p

Re: [Sugar-devel] [PATCH sugar v2 11/21] pylint cleanup: remove unused imports

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index 33b9eac..c9aee50 100644 --- a/extensions/deviceicon/network.py

Re: [Sugar-devel] [PATCH sugar v2 10/21] pylint cleanup: replace disable-msg with disable

2010-11-24 Thread Simon Schampijer
On 11/19/2010 10:13 PM, Sascha Silbe wrote: Adapt to upstream format change. Reviewed-by: Simon Schampijer Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/config.py.in b/src/jarabe/config.py.in index 6c418e9..d22ee9a 100644 --- a/src/jarabe/con

Re: [Sugar-devel] [PATCH sugar v2 08/21] style cleanup: use """ everywhere

2010-11-24 Thread Simon Schampijer
On 11/19/2010 10:13 PM, Sascha Silbe wrote: Most of the code uses """, so adjust the few deviations. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/docs/release_howto.txt b/docs/release_howto.txt index db877e0..841809a 100644 --- a/docs/release_howto.txt +++

Re: [Sugar-devel] [PATCH sugar v2 07/21] PEP8 cleanup: don't use has_key()

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar v2 05/21] PEP8 cleanup: fix inline comment spacing

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/keyboard/model.py b/extensions/cpsection/keyboard/model.py index b7186e2..82456d3 100644 --- a/extensions/cpsection

[Sugar-devel] GTK3 rendered in a browser

2010-11-24 Thread Sameer Verma
Saw this and instantly thought of Sugar being rendered in a browser. http://blogs.gnome.org/alexl/2010/11/23/gtk3-vs-html5/ cheers, Sameer -- Dr. Sameer Verma, Ph.D. Associate Professor, Information Systems Director, Campus Business Solutions San Francisco State University http://verma.sfsu.edu/

Re: [Sugar-devel] [PATCH sugar v2 02/21] style cleanup: move globals before class and method definitions

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: This only touches the globals that were flagged by pep8 due to white space issues or contain "instance" in their name (singleton pattern). I've also left the sunflower layout variables alone. AFAICT this layout is current

Re: [Sugar-devel] [PATCH sugar v2 01/21] fix EOL spaces

2010-11-24 Thread Simon Schampijer
Reviewed-by: Simon Schampijer On 11/19/2010 10:13 PM, Sascha Silbe wrote: Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/aboutcomputer/model.py b/extensions/cpsection/aboutcomputer/model.py index 898d79c..77d3b86 100644 --- a/extensions

[Sugar-devel] Group name for our FLOSS Manuals

2010-11-24 Thread James Simmons
FLOSS Manuals is going to migrate the manuals to new software called Booki. In that software related books are put into Groups. The question is, what Group name should be used for our FLOSS Manuals? I would be happy with "One Laptop Per Child" myself, but I'm not the only author so we should try

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread C. Scott Ananian
I've said all I need to say, time to hear from other people. We'll know we've been successful when the new updated version of the Sugar HIG comes out. Until then, I guess just keep on pounding that big red button at 6 month intervals. --scott --                          ( http://cscott.net/ )

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread Michael Stone
On Wed, 24 Nov 2010 at 10:43:24 -0500, C. Scott wrote: On Wed, Nov 24, 2010 at 1:37 AM, Michael Stone wrote: That reduces time commitment without diluting buck-stopping responsibility. A committee-of-three with people like Gary, Martin, and Walter on it will have adequate buck-stopping capaci

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread C. Scott Ananian
[more thoughts, again apologies for not making these shorter] Failing a good candidate, I think "do no harm" should be the motto -- concentrate on the (many!) design-related tasks which *don't* involve making design decisions. Briefly: organizing/maintaining the specs, collecting/collating issues

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread C. Scott Ananian
On Wed, Nov 24, 2010 at 1:37 AM, Michael Stone wrote: > A committee-of-three with people like Gary, Martin, and Walter on it [...] [Another orthogonal issue:] I like and respect Gary, Martin, and Walter, and I think I'd have no trouble convincing them of any UI change I'd wish to make. AFAICT t

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread C. Scott Ananian
On Wed, Nov 24, 2010 at 10:43 AM, C. Scott Ananian wrote: > I'm suggesting that you work on reducing the time commitment, rather > than dilute the responsibility. (Christoph's suggestion seems a useful step in that direction.) --scott --                          ( http://cscott.net/ ) ___

Re: [Sugar-devel] Sugar UI Dictator

2010-11-24 Thread C. Scott Ananian
On Wed, Nov 24, 2010 at 1:37 AM, Michael Stone wrote: >> That reduces time commitment without diluting buck-stopping >> responsibility. > > A committee-of-three with people like Gary, Martin, and Walter on it will > have adequate buck-stopping capacity, no? I think that it is possible that a comm

Re: [Sugar-devel] how to use sugar cursors not in gdk cursor?

2010-11-24 Thread Sascha Silbe
Excerpts from Erik Blankinship's message of Sun Nov 21 04:52:46 +0100 2010: [Cursor hand_open from sugar-artwork] > How do I use that sugar cursor in a python activity? Try: gtk.gdk.cursor_new_from_name(gtk.gdk.display_get_default(), 'hand_open') Sascha -- http://sascha.silbe.org/ http://www.i

Re: [Sugar-devel] [Dextrose] Sugar UI Dictator

2010-11-24 Thread Christoph Derndorfer
On Wed, Nov 24, 2010 at 7:37 AM, Michael Stone wrote: > Maybe it would be help to identify a single dictator and lieutenants >> > > Lieutenants are a good idea regardless. On the topic of lieutenants I'd also like to add that it might make sense to try and get people working in deployments to p

Re: [Sugar-devel] [ANNOUNCE] New Sugar Web chat

2010-11-24 Thread Aleksey Lim
On Wed, Nov 24, 2010 at 12:08:38PM +1100, James Cameron wrote: > On Tue, Nov 23, 2010 at 05:52:48PM +, Aleksey Lim wrote: > > New web chat[1] (qwebirc[2]) client is in production mode on: > > https://chat.sugarlabs.org > > The difference with previous chat.sugarlabs.org are: > > * https for

[Sugar-devel] sugar 0.84 activity registry

2010-11-24 Thread Tony Anderson
Hi, I am trying the DataManager activity on 0.84. The activity.registry seems to have been deleted or changed. from sugar.activity import registry ... #Retrieve and ActivityRegistry Object ar = registry.get_registry() # use get_activities() to get a list of ActivityInf

Re: [Sugar-devel] how to use sugar cursors not in gdk cursor?

2010-11-24 Thread Gonzalo Odiard
The last two parameters set the hotspot, but i don't know how to query it. Gonzalo On Tue, Nov 23, 2010 at 7:26 PM, Erik Blankinship wrote: > Thank you for this snippet. > > Is there no mechanism to query the system for the hotspots? > > On Tue, Nov 23, 2010 at 8:26 AM, Gonzalo Odiard wrote: >

[Sugar-devel] CAcert inclusion in Browse (was: Re: [ANNOUNCE] New Sugar Web chat)

2010-11-24 Thread Sascha Silbe
Excerpts from James Cameron's message of Wed Nov 24 02:18:29 +0100 2010: [chat.sl.o uses CAcert certificate which isn't shipped by some distros] > Browse-108 on XO-1.5 10.1.2 os852 also complains. This is unfortunate. > Couldn't the activity at least be packaged in a state that will accept > this