Re: [Sugar-devel] [PATCH] Display build number at Name Page

2011-07-06 Thread James Cameron
On Fri, Jun 24, 2011 at 07:08:36PM +0200, Simon Schampijer wrote: > I have been thinking about it some more - I am not a big fan of > putting build information into the naming screen. This takes focus > from it's purpose, people might not know what it means etc. I don't think this will take focus,

Re: [Sugar-devel] [SPAM?]: Re: [PATCH sugar-toolkit] Remove incomplete MANIFEST support

2011-07-06 Thread James Cameron
On Wed, Jul 06, 2011 at 10:45:18AM +0200, Simon Schampijer wrote: > I did test installing a bundle with no MANIFEST file on 0.84.x > (10.1.3) and I did get warnings about the missing MANIFEST but that's > it. Installed fine and runs fine. AFAIK 802 is 0.84 based as well, so > I presume this should

[Sugar-devel] [PATCH] adding /home/walter/Documents to volume toolbar

2011-07-06 Thread Walter Bender
From: Walter Bender This patch adds $HOME/Documents to the volume toolbar in the Journal view. The rationale is to make it easier for people to move files in and out of the data store from the file system -- a feature oft requested by teachers. It also means that Sugar activities can more readily

[Sugar-devel] [ASLO] Release Read-90

2011-07-06 Thread Sugar Labs Activities
Activity Homepage: http://activities.sugarlabs.org/addon/4028 Sugar Platform: 0.90 - 0.92 Download Now: http://activities.sugarlabs.org/downloads/file/27464/read-90.xo Release notes: Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-d

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-07-06 Thread Sascha Silbe
Excerpts from Walter Bender's message of Thu May 19 13:56:51 +0200 2011: > Also attached is a new version of the patch to volumestoolbar.py since > Gary's icon has a different name than the one I had been using. Please send patches inline for easier review and to see them on Patchwork, making sur

Re: [Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-07-06 Thread Gonzalo Odiard
Refactoring is ok and the change and is coherent with work in #10978 Review-by: Gonzalo Odiard ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-07-06 Thread Gonzalo Odiard
I have tested it, and works ok. Tested-by: Gonzalo Odiard ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Sugar-toolkit: Initialize window title with bundle name - OLPC #11037

2011-07-06 Thread Simon Schampijer
On 07/06/2011 03:50 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiard The activity tray palette compares the title with the bundle name to check if a secondary text will be displayed. Signed-off-by: Gonzalo Odiard Thanks Gonzalo for the patch. Reviewed and tested - looks good to me. Acke

Re: [Sugar-devel] [PATCH] Sugar:Do not cache the activity tray palette - OLPC #10978

2011-07-06 Thread Simon Schampijer
On 07/06/2011 03:31 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiard Needed to update the secondary text if the title in the activity changes. Signed-off-by: Gonzalo Odiard Thanks Gonzalo for the patch. Reviewed and tested - looks good to me. Acked-By: Simon Schampijer Regards, Sim

Re: [Sugar-devel] [PATCH] Update window title when the activity title changes - OLPC #10978

2011-07-06 Thread Simon Schampijer
On 07/06/2011 03:24 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiard The patch updates the window title when the user changes the title in the toolbar or in the Journal. Signed-of-by: Gonzalo Odiard Thanks Gonzalo for this patch. Review and testing I have done and we have gone through s

Re: [Sugar-devel] Reviews of activities in sugarlabs

2011-07-06 Thread Rodrigo PĂ©rez Fulloni
Yes, I think so. Anonymous reviews would be great, the people is in general honest, is the main idea of the IMDB and the wiki collaborations systems, nobody will vote for an activity he didn't use. Perhaps don't allow review and only allow star the activities anonymously. I think this is easy to do

[Sugar-devel] [PATCH] Sugar-toolkit: Initialize window title with bundle name - OLPC #11037

2011-07-06 Thread godiard
From: Gonzalo Odiard The activity tray palette compares the title with the bundle name to check if a secondary text will be displayed. Signed-off-by: Gonzalo Odiard --- src/sugar/activity/activity.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sugar/activity/a

[Sugar-devel] [PATCH] Sugar:Do not cache the activity tray palette - OLPC #10978

2011-07-06 Thread godiard
From: Gonzalo Odiard Needed to update the secondary text if the title in the activity changes. Signed-off-by: Gonzalo Odiard --- src/jarabe/frame/activitiestray.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/jarabe/frame/activitiestray.py b/src/jarabe/frame/ac

[Sugar-devel] [PATCH] Update window title when the activity title changes - OLPC #10978

2011-07-06 Thread godiard
From: Gonzalo Odiard The patch updates the window title when the user changes the title in the toolbar or in the Journal. Signed-of-by: Gonzalo Odiard --- src/sugar/activity/activity.py | 10 +- src/sugar/activity/widgets.py |2 ++ 2 files changed, 11 insertions(+), 1 deletions(

Re: [Sugar-devel] [SPAM?]: Re: [PATCH sugar-toolkit] Remove incomplete MANIFEST support

2011-07-06 Thread Simon Schampijer
On 07/05/2011 03:44 PM, Gary Martin wrote: On 5 Jul 2011, at 10:22, Simon Schampijer wrote: On 07/03/2011 05:54 PM, Sascha Silbe wrote: From: Bernie Innocenti This incomplete feature contributes to confuse new activity authors and slightly complicates our bundle installation logic. The day

Re: [Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-07-06 Thread Simon Schampijer
On 06/07/2011 09:57 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Mon May 30 15:57:26 +0200 2011: Looks nice and simple but seems to be more complicated in practice: We don't follow changes to the activity title because the palette gets created just once in ActivityView.__

[Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-07-06 Thread Simon Schampijer
The patch does display the activity name as primary text and the session title as secondary text. This is coherent with the palette of an activity in the frame. To make this work properly we need to refactor the code a bit and make the palette on demand. Signed-off-by: Simon Schampijer --- src/

Re: [Sugar-devel] [PATCH sugar] Gabble: do not add ourself to the model twice OLPC #10965

2011-07-06 Thread Simon Schampijer
On 07/05/2011 07:57 PM, Simon Schampijer wrote: On 07/05/2011 06:34 PM, Martin Langhoff wrote: On Mon, Jul 4, 2011 at 10:23 AM, Simon Schampijer wrote: Thanks Martin for the information. Do you have a specific ticket about it? More info on the ejabber version? did some digging on this. The fi