Re: [Sugar-devel] API policy

2013-06-19 Thread Gonzalo Odiard
Reworked the proposal to keep the method for background compatibility. Gonzalo On Wed, Jun 19, 2013 at 8:48 PM, Gonzalo Odiard wrote: > Good point, etoys use the object chooser. > I don't know id dbus signature can do a parameter optative, > or how do it backwards conpatible > > Gonzalo > > >

Re: [Sugar-devel] API policy

2013-06-19 Thread Gonzalo Odiard
Good point, etoys use the object chooser. I don't know id dbus signature can do a parameter optative, or how do it backwards conpatible Gonzalo On Wed, Jun 19, 2013 at 8:28 PM, Daniel Narvaez wrote: > What about non-python activities? > > > On Thursday, 20 June 2013, Gonzalo Odiard wrote: > >>

Re: [Sugar-devel] API policy

2013-06-19 Thread Daniel Narvaez
What about non-python activities? On Thursday, 20 June 2013, Gonzalo Odiard wrote: > In this case, the activities don't use the dbus API, but the object > defined in sugar-toolkit-gtk3. > > Gonzalo > > > On Wed, Jun 19, 2013 at 7:55 PM, Daniel Narvaez > > > wrote: > >> Hello, >> >> when reviewi

Re: [Sugar-devel] API policy

2013-06-19 Thread Gonzalo Odiard
In this case, the activities don't use the dbus API, but the object defined in sugar-toolkit-gtk3. Gonzalo On Wed, Jun 19, 2013 at 7:55 PM, Daniel Narvaez wrote: > Hello, > > when reviewing patches I'm always unsure what to do about AP breaks, both > in python and in dbus interfaces. Do we hav

[Sugar-devel] API policy

2013-06-19 Thread Daniel Narvaez
Hello, when reviewing patches I'm always unsure what to do about AP breaks, both in python and in dbus interfaces. Do we have any kind of policy we should follow? The last case I run into is adding a parameter to the ObjectChooser dbus API. Is that a break we should make? Should we add a new meth

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Daniel Narvaez
On 19 June 2013 23:57, Daniel Narvaez wrote: > On 19 June 2013 23:49, Alan Jhonn Aguiar Schwyn wrote: > >> I just reinstall my Ubuntu, and clone the sugar-build again. >> When you try run the .osbuild you get: >> >> alan@alan-pc:~/Documentos/GIT/sugar-build$ ./osbuild >> = Setup the build system

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Daniel Narvaez
On 19 June 2013 23:49, Alan Jhonn Aguiar Schwyn wrote: > I just reinstall my Ubuntu, and clone the sugar-build again. > When you try run the .osbuild you get: > > alan@alan-pc:~/Documentos/GIT/sugar-build$ ./osbuild > = Setup the build system = > > * Create the python virtualenv > * Install osbui

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Walter Bender
On Wed, Jun 19, 2013 at 5:49 PM, Alan Jhonn Aguiar Schwyn wrote: > I just reinstall my Ubuntu, and clone the sugar-build again. > When you try run the .osbuild you get: > > alan@alan-pc:~/Documentos/GIT/sugar-build$ ./osbuild > = Setup the build system = > > * Create the python virtualenv > * Inst

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Alan Jhonn Aguiar Schwyn
I just reinstall my Ubuntu, and clone the sugar-build again.When you try run the .osbuild you get: alan@alan-pc:~/Documentos/GIT/sugar-build$ ./osbuild = Setup the build system = * Create the python virtualenv* Install osbuild packageCommand /home/alan/Documentos/GIT/sugar-build/build/out/sandbox

Re: [Sugar-devel] Commits notification on IRC

2013-06-19 Thread Ignacio Rodríguez
+1 maybe create one channel: #sugar-commits To show all commits in github (repo of sugar) and git.sugarlabs.org (all repos) 2013/6/19 Gonzalo Odiard > +1 > > > On Wed, Jun 19, 2013 at 5:05 PM, Daniel Narvaez wrote: > >> Hello, >> >> it might be nice to have commit notifications in the #sugar i

Re: [Sugar-devel] Commits notification on IRC

2013-06-19 Thread Gonzalo Odiard
+1 On Wed, Jun 19, 2013 at 5:05 PM, Daniel Narvaez wrote: > Hello, > > it might be nice to have commit notifications in the #sugar irc channel > for the core modules. If we want it, it's pretty easy to setup with github. > > Thoughts? > > -- > Daniel Narvaez > >

[Sugar-devel] Commits notification on IRC

2013-06-19 Thread Daniel Narvaez
Hello, it might be nice to have commit notifications in the #sugar irc channel for the core modules. If we want it, it's pretty easy to setup with github. Thoughts? -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://

[Sugar-devel] [ASLO] Release Hablar-47

2013-06-19 Thread Sugar Labs Activities
Activity Homepage: http://activities.sugarlabs.org/addon/4038 Sugar Platform: 0.96 - 0.100 Download Now: http://activities.sugarlabs.org/downloads/file/28656/speak-47.xo Release notes: Brains compiled with the latest changes Modifications in bot logic (Walter Bender) Fix error saving at exit - S

Re: [Sugar-devel] Your help is needed!

2013-06-19 Thread Daniel Narvaez
On 19 June 2013 20:28, Daniel Narvaez wrote: > > It would be great if you could get github to send a message to the >> pootle-commits list when a commit is made by Poolte: >> >> http://lists.sugarlabs.org/listinfo/pootle-commits >> > It's easy to send email for every commit, but I don't see a way

Re: [Sugar-devel] Your help is needed!

2013-06-19 Thread Daniel Narvaez
On 19 June 2013 03:15, Chris Leonard wrote: > Ok, I can see that commits from the Glucose project in Pootle appear to be > landing, or at least not generating errors. I would need to look into > github to make sure they actually landed. Have you seen some commits of PO > files today? > > Yes, t

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Daniel Narvaez
Actually gtk supports on the fly changes, so in theory that's possible (will likely require sugar fixes). I'm not too sure if that works well when an icon inside a theme changes rather than the whole theme though. I suspect finding the best solution will involve reading gtk icon themes code here :

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Gonzalo Odiard
Hmm, that will be a file monitor for every activity running too, if I am not wrong, that is implemented polling, may be is better check datetime modification when one icon is needed. Gonzalo On Wed, Jun 19, 2013 at 12:05 PM, Daniel Narvaez wrote: > Oh yes, you will need to invalidate both cache

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Daniel Narvaez
If inotify is available it will use that I think. Checking time is an option for the sugar cache (file content) but not for the gtk one (file path). Perhaps it's fine if the change is picked up on activity restart? It will probably not auto apply anyway, only newly created icons will change even i

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Daniel Narvaez
Oh yes, you will need to invalidate both caches. I guess the shell can keep a file monitor on the icons dir and invalidate when it changes. On Wednesday, 19 June 2013, Walter Bender wrote: > On Wed, Jun 19, 2013 at 10:53 AM, Daniel Narvaez > > > wrote: > > About the cache, did you try > > > > >

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Daniel Narvaez
About the cache, did you try https://developer.gnome.org/gtk3/stable/GtkIconTheme.html#gtk-icon-theme-rescan-if-needed On Wednesday, 19 June 2013, Walter Bender wrote: > Here are some thoughts about the custom icon patch: > > (1) if we prepend ~/.sugar/icons to the theme icon path, then anything

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Gonzalo Odiard
On Wed, Jun 19, 2013 at 11:53 AM, Daniel Narvaez wrote: > About the cache, did you try > > > https://developer.gnome.org/gtk3/stable/GtkIconTheme.html#gtk-icon-theme-rescan-if-needed > > I think the cache involved is in icon.py _SVGLoader. Right now, does not check if the file was modified. Gonza

Re: [Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Walter Bender
On Wed, Jun 19, 2013 at 10:53 AM, Daniel Narvaez wrote: > About the cache, did you try > > https://developer.gnome.org/gtk3/stable/GtkIconTheme.html#gtk-icon-theme-rescan-if-needed Tried that. Sugar seems to cache its icons separately from GTK. There used to be a cache file, but now I think it is

[Sugar-devel] rethinking your icon customization patch

2013-06-19 Thread Walter Bender
Here are some thoughts about the custom icon patch: (1) if we prepend ~/.sugar/icons to the theme icon path, then anything in that path will be used (as long as we flush the cache) as per dnarvaez's comment on the patch (2) if we have a sugar activity for selecting svg files (from the journal and

Re: [Sugar-devel] About customization of xo icon

2013-06-19 Thread Gonzalo Odiard
> I we have a collection of defined icons, is just send the name of the >> selected icon. We are sending the colors now. >> > > That would assume everyone has the icon (I haven't looked into the > implementation closely but I thought you could also use your own icon for > example). > > Yes. Where

[Sugar-devel] About customization of xo icon

2013-06-19 Thread Daniel Narvaez
On Wednesday, 19 June 2013, Gonzalo Odiard wrote: > > On Wed, Jun 19, 2013 at 6:09 AM, Daniel Narvaez wrote: > >> On 19 June 2013 09:19, Simon Schampijer wrote: >> >>> I agree with the possible confusion if we allow changing the outlines of >>> the user icon easily: imagine the situation in the N

Re: [Sugar-devel] About customization of xo icon

2013-06-19 Thread Gonzalo Odiard
On Wed, Jun 19, 2013 at 6:09 AM, Daniel Narvaez wrote: > On 19 June 2013 09:19, Simon Schampijer wrote: > >> I agree with the possible confusion if we allow changing the outlines of >> the user icon easily: imagine the situation in the Neighborhood view. At >> the moment you can identify more or

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Daniel Narvaez
Should be fixed now. On 19 June 2013 09:51, Daniel Narvaez wrote: > Not just your problem, getting the same on buildbot. Not on a keyboard but > I will fix it ASAP. > > Not sure why it didn't fail yesterday when I pushed, maybe it happens only > with a clean build. > > > On Wednesday, 19 June 2

Re: [Sugar-devel] About customization of xo icon

2013-06-19 Thread Daniel Narvaez
On 19 June 2013 09:19, Simon Schampijer wrote: > I agree with the possible confusion if we allow changing the outlines of > the user icon easily: imagine the situation in the Neighborhood view. At > the moment you can identify more or less easily what is a user, what an > Access point and what a

Re: [Sugar-devel] Sugar build break

2013-06-19 Thread Daniel Narvaez
Not just your problem, getting the same on buildbot. Not on a keyboard but I will fix it ASAP. Not sure why it didn't fail yesterday when I pushed, maybe it happens only with a clean build. On Wednesday, 19 June 2013, Alan Jhonn Aguiar Schwyn wrote: > Well, now have this: > > * Building sugar-do

Re: [Sugar-devel] About customization of xo icon

2013-06-19 Thread Simon Schampijer
On 06/16/2013 07:19 AM, Gonzalo Odiard wrote: I think we should decide if changing the xo icon is a feature we _really_ want include in sugar. I am not sure if add too much value, but probably can add confusion, more if is applied in all the places where the xo icons is used , like the actual im