[Sugar-devel] [Music Blocks] Re-review of changes made w.r.t. issue #2192 (let there be let)

2020-05-07 Thread Anindya Kundu
I was just going through the recently posted issues. I came across Collapsing Scale Degree (Note Value) is Broken #2236 . I looked into the code and found a trivial scope error originating due to replacing var with let. I've previously too come

[Sugar-devel] Sugarizer GSoC Slack

2020-05-07 Thread Lionel Laské
Hi all, During the GSoC we're going to use Slack to discuss about Sugarizer projects. The Slack workspace is here: https://sugarizer-workspace.slack.com All mentors and students are already there but if some of you are interested to join discussion, you're welcome to join. Just send me an e-mail

[Sugar-devel] First Sugarizer Knowledge Activity Pack meeting

2020-05-07 Thread Dhruv Misra
Hey there, I and my mentor Lionel had our first Sugarizer Knowledge Activity Pack meeting at 12H UTC today i.e. 7 May. We discussed the logistics, future plans and had a conversation on the Vue.js activity template which will be a reusable template ready to create activities in the future. We

Re: [Sugar-devel] Relevant code related to key change in Music Blocks

2020-05-07 Thread Anindya Kundu
One correction: it is defined as movable and not moveable, in the getNote(...) function definition. *Anindya Kundu* On Thu, 7 May 2020 at 13:23, Aviral Gangwar wrote: > Hello > Could you please guide me to the relevant files which handle a key change? > E.g From C Major to G Major. Where do

Re: [Sugar-devel] Relevant code related to key change in Music Blocks

2020-05-07 Thread Anindya Kundu
Key changes happen if solfege is moveable, i.e. moveableDo returns true. >From logo.js, I got references to getNote() function in utils/musicutils.js. I think you should be looking for the (three) "if (moveable)" blocks inside getNote() in musicutils.js. Also, the first of the said if blocks refe

[Sugar-devel] Relevant code related to key change in Music Blocks

2020-05-07 Thread Aviral Gangwar
Hello Could you please guide me to the relevant files which handle a key change? E.g From C Major to G Major. Where do we do the calculations regarding this shift? I guess one place to look would be _playPitch() inside PitchBlock.js. Thank You ___ Sugar