Re: [Sugar-devel] [PATCH sugar 1/2] ModalAlert ported to Gtk3

2012-09-17 Thread Simon Schampijer
Thanks, pushed as: 8c661997e6c54139cf98dc7149749388c91d757f There was as well the window.window - window.get_window() missing, found with my little test: from gi.repository import Gtk from jarabe.journal.modalalert import ModalAlert def _destroy_cb(widget, data=None): Gtk.main_quit()

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Style the palette menu header - SL #3879 #3836

2012-09-13 Thread Simon Schampijer
Excellent, thanks for looking into this! On 09/13/2012 06:26 AM, Manuel Quiñones wrote: - Make the first item of the menu a custom class, to make the children widget allocate using all the available space. And so it can be styled in the theme. - Remove the set_sensitive(False) from

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Style the palette menu header - SL #3879 #3836

2012-09-13 Thread Simon Schampijer
On 09/13/2012 01:42 PM, Gonzalo Odiard wrote: On Thu, Sep 13, 2012 at 4:53 AM, Simon Schampijer si...@schampijer.dewrote: Excellent, thanks for looking into this! On 09/13/2012 06:26 AM, Manuel Quiñones wrote: - Make the first item of the menu a custom class, to make the children widget

[Sugar-devel] [PATCH toolkit-gtk3 1/2] Add new PaletteMenuItem widget for usage in mixed content Palettes

2012-09-13 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org As Palettes can either include a Gtk.Menu or a Gtk.Window we have to use a false menu when we want to have both functionality in a Palette. This is a new class PaletteMenuItem for those use cases. Code highly based on the work from Gonzalo Odiard. The API

[Sugar-devel] [PATCH shell 3/3] Keydialog: various fixups

2012-09-13 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org - set_has_separator has been deprecated [1] - if we pass a model to the GtkCombobox we need to name the argument [2] - pack_start: the convert script got confused here [1] http://www.pygtk.org/docs/pygtk/class-gtkdialog.html#method-gtkdialog--set-has

Re: [Sugar-devel] [PATCH toolkit-gtk3 1/2] Add new PaletteMenuItem widget for usage in mixed content Palettes

2012-09-13 Thread Simon Schampijer
On 09/13/2012 05:40 PM, Manuel Quiñones wrote: Thanks a lot Simon. Yes I think this is the right approach. The only things I see are: - a trailing whitespace that gives a warning when applied. - add Sugar prefix to the type name of PaletteMenuItem Fixed up and pushed. We can pretty the

[Sugar-devel] [RELEASE] sugar-toolkit-gtk3-0.97.2

2012-09-13 Thread Simon Schampijer
The I go never out without my Palette release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit-gtk3/sugar-toolkit-gtk3-0.97.2.tar.bz2 == News == * Release 0.97.2 (Simon Schampijer) * Add new PaletteMenuItem widget for usage in mixed content Palettes (Simon

[Sugar-devel] [RELEASE] sugar-0.97.3

2012-09-13 Thread Simon Schampijer
The I am a GTK+ 3 shell release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar/sugar-0.97.3.tar.bz2 == News == * Release 0.97.3 (Simon Schampijer) * Update Sucrose version for upcoming 0.97.3 (Simon Schampijer) * Keydialog: various fixups (Simon Schampijer) * Port

[Sugar-devel] [PATCH] ActivityListPalette: fix displaying of Palette

2012-09-12 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org - uncommented some code that was commented by mistake - listen to the destroy signal of the menu for doing the cleanup: the structure of Palettes has changed. The Palette is either a Gtk.Menu or a Gtk.Window which is encapsulated in the Palette class

[Sugar-devel] [PATCH toolkit-gtk3] CellRendererInvoker: various fixups

2012-09-12 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org - the GtkCellRenderer (which our CellRenderer derives from) is not a GtkWidget and therefor the 'get_display' method does not exist, we fallback to the default display in that case [1] - the get_rect method should return a Gdk.Rectangle now, see other

[Sugar-devel] [PATCH toolkit-gtk3] Frame Device icons: Palette is not drawn at the correct position

2012-09-12 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org We are adding the x value twice (from the allocation and from the origin) in get_rect of the WidgetInvoker which we derive from in the FrameInvoker. In the toolkit-gtk2 code [1] we did add the allocation.x value when the widget does not provide its own

[Sugar-devel] [PATCH shell] Replace cairo.RectangleInt with Gdk.Rectangle

2012-09-12 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org The Gdk.Rectangle is basically a cairo.RectangleInt but that way we do not need to import the dynamic cairo bindings explicitly. Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/desktop/favoriteslayout.py | 15 +++ src/jarabe

Re: [Sugar-devel] gestures + event controller patch series

2012-09-10 Thread Simon Schampijer
On 09/05/2012 02:04 PM, Carlos Garnacho wrote: Hey, I'm sending an updated patch set. There was a missing header in the previous set, and now there's code to show UI feedback on long press Carlos Hi Carlos, all in all a very nice work, I have a few comments on the API: ==Long press==

Re: [Sugar-devel] [PATCH sugar-artwork 1/4] Fix Makefile to install the proper CSS in sugar 100% theme

2012-09-10 Thread Simon Schampijer
Good catch, please push! As you said, this reveals a few issues we need to fix, a short note in the commit message is maybe good, nothing fancy needed though. Simon On 09/04/2012 05:50 AM, Manuel Quiñones wrote: Signed-off-by: Manuel Quiñones ma...@laptop.org --- gtk3/theme/Makefile.am | 2

Re: [Sugar-devel] sugar-build broken

2012-09-10 Thread Simon Schampijer
On 09/11/2012 03:25 AM, Agustin Zubiaga Sanchez wrote: Hello everybody, Today, I have compiled sugar-build again and it finished successful, but when I opened sugar (make run), appeared only the home toolbar and in some seconds, it has closed. I send my shell.log in the attachment. Regards,

Re: [Sugar-devel] shell-port status

2012-09-07 Thread Simon Schampijer
On 09/07/2012 08:34 AM, Manuel Quiñones wrote: 2012/9/6 Simon Schampijer si...@schampijer.de: On 09/06/2012 09:31 AM, Simon Schampijer wrote: On 09/05/2012 07:29 PM, Simon Schampijer wrote: On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week

Re: [Sugar-devel] shell-port status

2012-09-07 Thread Simon Schampijer
On 09/06/2012 09:31 AM, Simon Schampijer wrote: On 09/05/2012 07:29 PM, Simon Schampijer wrote: On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging

[Sugar-devel] [PATCH sugar-toolkit-gtk3] Icon: Gdk.CairoContext does not exist

2012-09-06 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org First of all 'Gdk.CairoContext' does not exist, this has been made up by the conversion script in 820efa56b9876bb418bc51d30de959775930e35c We do not need the previous gtk.gdk.CairoContext here anymore, we do only want to set the background of the context

Re: [Sugar-devel] shell-port status

2012-09-06 Thread Simon Schampijer
On 09/05/2012 07:29 PM, Simon Schampijer wrote: On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging and keep on working on the master branches. I

Re: [Sugar-devel] shell-port status

2012-09-06 Thread Simon Schampijer
On 09/06/2012 09:31 AM, Simon Schampijer wrote: On 09/05/2012 07:29 PM, Simon Schampijer wrote: On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging

Re: [Sugar-devel] shell-port status

2012-09-06 Thread Simon Schampijer
On 09/06/2012 02:42 PM, Peter Robinson wrote: The ported code does use GStreamer through introspection. So we will depend on GStreamer 1.0 (old GStreamer does not have full introspection support). I just checked availability of GStreamer 1.0 in the distros. In Fedora it has been built now [1]

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3 2/2] Fix the badge position at the icon attach point - SL #3835

2012-09-06 Thread Simon Schampijer
On 09/06/2012 06:05 PM, Manuel Quiñones wrote: The convert script pygi-convert.sh commented out the call to info.get_attach_points() in commit 820efa56 Signed-off-by: Manuel Quiñones ma...@laptop.org --- src/sugar3/graphics/icon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Icon: Gdk.CairoContext does not exist

2012-09-06 Thread Simon Schampijer
Thanks, pushed. On 09/06/2012 02:35 PM, Manuel Quiñones wrote: Good catch, we were not receiving errors in the logs for that. Acked. 2012/9/6 Simon Schampijer si...@schampijer.de: From: Simon Schampijer si...@laptop.org First of all 'Gdk.CairoContext' does not exist, this has been made up

Re: [Sugar-devel] [PATCH sugar] Remove unneeded call in Journal toolbar, left from old toolbar

2012-09-06 Thread Simon Schampijer
On 09/04/2012 08:03 PM, Simon Schampijer wrote: On 09/04/2012 07:40 PM, Manuel Quiñones wrote: Is giving AttributeError. Was left by accident in commit f1590970b884a4dab44bbdabc885f883bbc8bae0 . Signed-off-by: Manuel Quiñones ma...@laptop.org Ok, I can merge it into the shell-port series

Re: [Sugar-devel] shell-port status

2012-09-06 Thread Simon Schampijer
On 09/06/2012 09:31 AM, Simon Schampijer wrote: On 09/05/2012 07:29 PM, Simon Schampijer wrote: On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging

Re: [Sugar-devel] gestures + event controller patch series

2012-09-05 Thread Simon Schampijer
On 09/05/2012 02:04 PM, Carlos Garnacho wrote: Hey, I'm sending an updated patch set. There was a missing header in the previous set, and now there's code to show UI feedback on long press Carlos Hey Carlos, awesome work, looking really good already. While spinning an rpm for testing

Re: [Sugar-devel] shell-port status

2012-09-05 Thread Simon Schampijer
On 09/03/2012 11:29 PM, Simon Schampijer wrote: Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging and keep on working on the master branches. I uploaded the current patches at [1], the rest coming

Re: [Sugar-devel] [PATCH sugar] Remove unneeded call in Journal toolbar, left from old toolbar

2012-09-04 Thread Simon Schampijer
On 09/04/2012 07:40 PM, Manuel Quiñones wrote: Is giving AttributeError. Was left by accident in commit f1590970b884a4dab44bbdabc885f883bbc8bae0 . Signed-off-by: Manuel Quiñones ma...@laptop.org Ok, I can merge it into the shell-port series. Simon

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Finish the port of the CellRendererIcon

2012-09-03 Thread Simon Schampijer
On 08/24/2012 03:13 PM, Manuel Quiñones wrote: 2012/8/24 Simon Schampijer si...@schampijer.de: On 08/23/2012 08:16 PM, Manuel Quiñones wrote: In pygtk custom cellrenderers were done inheriting gtk.GenericCellRenderer, and overriding the on_* methods. Now we inherit Gtk.CellRenderer

[Sugar-devel] shell-port status

2012-09-03 Thread Simon Schampijer
Hi, we made quite some good progress last week with the port. Most of the open items have been fixed. I do rebase now on master to start merging and keep on working on the master branches. I uploaded the current patches at [1], the rest coming. Feel free to start commenting while going.

[Sugar-devel] [PATCH] GtkLabel: make the background transparent

2012-08-29 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org The GtkLabel does respect background css properties now [1][2]. Drawing them transparent by default gives us the same behavior us before. Signed-off-by: Simon Schampijer si...@laptop.org [1] http://git.gnome.org/browse/gtk+/commit/?id

Re: [Sugar-devel] [DESIGN] Views: search behavior (was Re: [PATCH sugar] Views: move the ViewToolbar to the HomeWindow instead of having one in each View)

2012-08-29 Thread Simon Schampijer
On 08/28/2012 05:53 PM, Gary Martin wrote: Hi Simon, On 28 Aug 2012, at 14:12, Simon Schampijer si...@schampijer.de wrote: On 08/28/2012 02:14 PM, Manuel Quiñones wrote: So now the filtering is shared between the three views. I think this is worth noting in the commit message. Thanks

[Sugar-devel] [PATCH sugar] Views: move the ViewToolbar to the HomeWindow instead of having one in each View

2012-08-28 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org This patch moves the ViewToolbar to the HomeWindow and removes it from the Views respectively. This ease the transition between the Views and simplifies the code. The toolbar is passed as an argument at initialization of the View in order to connect

Re: [Sugar-devel] [PATCH sugar] Add toolbar to the TransitionBox

2012-08-28 Thread Simon Schampijer
On 08/28/2012 07:24 AM, Simon Schampijer wrote: On 08/27/2012 04:29 PM, Manuel Quiñones wrote: With the new frame behaviour the toolbar was appearing and disappearing while the transition took place. this patch adds a toolbar in the transition box with a fake search entry, that is set editable

Re: [Sugar-devel] [PATCH sugar] Use the new toolbars in the Journal

2012-08-28 Thread Simon Schampijer
Great, looking good! Thanks Gonzalo and Manuel. For the description, maybe: Sugar has switched to a new toolbar design in 0.86 [1]. In sugar-toolkit-gtk3 support for the old deprecated toolbar has been removed in 0.96 [2]. Prior to the shell port we have to use the new style toolbar in the

Re: [Sugar-devel] [DESIGN] Proposal: Multi-Selection and Batch Operations on Journal entries

2012-08-28 Thread Simon Schampijer
On 08/19/2012 10:05 PM, Ajay Garg wrote: Hi all. Just saw Simon's patch at http://patchwork.sugarlabs.org/patch/1670/ Thereby, it's a gentle request :: * to get this multi-select feature approved (with all the latest feedback-changes/bug-fixes). * to get

Re: [Sugar-devel] [PATCH sugar-artwork] Remove radius between the two sides of the GtkScale trough

2012-08-28 Thread Simon Schampijer
On 08/27/2012 05:35 PM, Manuel Quiñones wrote: We had a radius set for all the corners of the trough, and that was making the bar rounded at the two sides of the slider. This was partially hidden below the slider. Also remove the hardcoded number for the radius. The GtkScale still needs love.

[Sugar-devel] [DESIGN] Frame, new behavior for revealing/hiding the Frame with the mouse

2012-08-28 Thread Simon Schampijer
Hi, in 238338d4b5d6a065eb81bd118a8c0b7ca83717bf (will be in 0.97.2) we modified the Frame hide/show with a mouse behavior to some extent: - you can reveal the Frame by going with the cursor in one of the hot corners - you can hide the Frame by going with the cursor in one of

[Sugar-devel] [DESIGN] Views: search behavior (was Re: [PATCH sugar] Views: move the ViewToolbar to the HomeWindow instead of having one in each View)

2012-08-28 Thread Simon Schampijer
On 08/28/2012 02:14 PM, Manuel Quiñones wrote: So now the filtering is shared between the three views. I think this is worth noting in the commit message. Thanks for the review and catching this! I did note it in the commit message before pushing. Gary, we did discuss the following: There

[Sugar-devel] [RELEASE] sugar-0.97.2

2012-08-28 Thread Simon Schampijer
The we like Toolbars - but don't forget the Frame release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar/sugar-0.97.2.tar.bz2 == News == * Release 0.97.2 (Simon Schampijer) * Add src/jarabe/desktop/viewtoolbar.py to POTFILES.in (Simon Schampijer) * Update Sucrose

[Sugar-devel] 0.98 status, today's developer meeting

2012-08-28 Thread Simon Schampijer
Hi, I want to skip today's developer meeting as I have been busy with getting 0.97.2 out of the door [1] and have a few more items on my plate I can not skip. Let's do the reporting of the status async. ===touch=== 0.97.2 is a milestone release with the changes discussed in [2] in regards

[Sugar-devel] [PATCH sugar] Group View: add search toolbar

2012-08-27 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org This adds a search toolbar to the Group View. The toolbar in the Neighborhood View has been outsourced to be usable in both Views. Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/desktop/Makefile.am| 3 +- src/jarabe/desktop

Re: [Sugar-devel] [PATCH sugar] Drop support for XdndDirectSave

2012-08-27 Thread Simon Schampijer
On 08/24/2012 02:12 PM, Daniel Narvaez wrote: From: Daniel Narvaez dwnarv...@gmail.com It was added to allow dragging images from the old mozilla based web browser to the frame. The mozilla side of the patch was never upstreamed and anyway the new webkit based browser doesn't support the

Re: [Sugar-devel] [PATCH v3 sugar-toolkit-gtk3] Fix the drawing of ColorToolButton, RadioToolButton and ToggleToolButton

2012-08-27 Thread Simon Schampijer
On 08/24/2012 02:13 AM, Manuel Quiñones wrote: Draw a black background in the buttons when the palette is up, as commit 01a06943 did with the ToolButton. As the comment for that commit states, we can change the prelight background color in the theme, but not when the mouse moves over the

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Add testcase for Gtk buttons

2012-08-27 Thread Simon Schampijer
On 08/27/2012 07:41 PM, Manuel Quiñones wrote: Signed-off-by: Manuel Quiñones ma...@laptop.org --- tests/graphics/buttons.py | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/graphics/buttons.py Looks good, pushed as:

Re: [Sugar-devel] [PATCH sugar-artwork] Remove colors, borders and paddings set for all the widgets, fix Button borders

2012-08-27 Thread Simon Schampijer
On 08/27/2012 08:12 PM, Manuel Quiñones wrote: The * {} and *:active {} CSS rules apply to all the widgets so they have to be overriden many times. We should do that for each widget when needed instead. Also fix the border for the GtkButton. We have a white outline in its focused state. This

Re: [Sugar-devel] [PATCH sugar-toolkit] Don't cache window size in palettewindow invoker

2012-08-27 Thread Simon Schampijer
On 08/23/2012 04:55 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiard godi...@gmail.com The screen size can change, by example when the screen rotate, and the stored values are not useful anymore. Without this patch the device icons palettes in the Journal or in the frame are not displayed

Re: [Sugar-devel] [PATCH sugar] Group View: add search toolbar

2012-08-27 Thread Simon Schampijer
On 08/27/2012 02:01 PM, Manuel Quiñones wrote: Great Simon, the only thing I see is that we should focus the search entry, like in the other views: --- a/src/jarabe/desktop/homewindow.py +++ b/src/jarabe/desktop/homewindow.py @@ -182,6 +182,7 @@ class HomeWindow(gtk.Window): elif

[Sugar-devel] [PATCH sugar] HomeToolbar: reuse the new ViewToolbar implementation

2012-08-27 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org In the HomeToolbar we can resue the ViewToolbar implementation that has been introduced in 13844c18b225f46b1636fc1201e020af53c60fcd. Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/desktop/homebox.py | 56

Re: [Sugar-devel] [PATCH sugar] Add toolbar to the TransitionBox

2012-08-27 Thread Simon Schampijer
On 08/27/2012 04:29 PM, Manuel Quiñones wrote: With the new frame behaviour the toolbar was appearing and disappearing while the transition took place. this patch adds a toolbar in the transition box with a fake search entry, that is set editable=False to prevent issues. Signed-off-by: Manuel

[Sugar-devel] [DESIGN] search toolbar in Group view

2012-08-26 Thread Simon Schampijer
Hi, to have the same functionality in the Views, I would like to add a search toolbar to the Group View. That is trivial in the first place and code can be shared from the Mesh and the Group View. One thing that is a bit tricky to handle is that we use already grey icons to show that a

Re: [Sugar-devel] [PATCH sugar] Launcher: set the standard SPLASHSCREEN hint instead of our own _SUGAR_WINDOW_TYPE hint

2012-08-24 Thread Simon Schampijer
On 08/23/2012 10:34 PM, Manuel Quiñones wrote: 2012/8/23 Simon Schampijer si...@schampijer.de: From: Simon Schampijer si...@laptop.org --- a/src/jarabe/view/launcher.py +++ b/src/jarabe/view/launcher.py @@ -32,7 +32,7 @@ class LaunchWindow(gtk.Window): def __init__(self, activity_id

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Finish the port of the CellRendererIcon

2012-08-24 Thread Simon Schampijer
On 08/23/2012 08:16 PM, Manuel Quiñones wrote: In pygtk custom cellrenderers were done inheriting gtk.GenericCellRenderer, and overriding the on_* methods. Now we inherit Gtk.CellRenderer and the methods to override changed to do_* . The destroy signal was moved to Gtk.Widget [1] so the

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Use the Sugar Theme in the testsuite

2012-08-24 Thread Simon Schampijer
On 08/24/2012 01:04 AM, Manuel Quiñones wrote: To make useful tests for the Sugar widgets, the theme must be the same. Signed-off-by: Manuel Quiñones ma...@laptop.org Great, thanks a step forward for our test-suite. Please push. Simon ___

Re: [Sugar-devel] [PATCH sugar] Remove _MouseListener from the frame and cleanup, v2, SL #3820

2012-08-23 Thread Simon Schampijer
On 08/23/2012 07:23 AM, Manuel Quiñones wrote: Yes! This complies with the behavior we agreed in the other thread. Please commit. Great, pushed as: 3e28f565b219c9c2b3744204e1e58b48ab76285b 2012/8/22 Simon Schampijer si...@schampijer.de: Move the code of mouse_enter() method into the client

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3 2/2] Fix the drawing of ColorToolButton, RadioToolButton and ToggleToolButton

2012-08-23 Thread Simon Schampijer
On 08/23/2012 07:12 AM, Manuel Quiñones wrote: gtk_paint_box is deprecated [1] and now we can use the CSS to change the style of the button's prelight state. To test the buttons, I provide a patch for HelloWorld activity [2]. They are added in the main toolbar. We should really make sure we

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3 1/2] Fix the drawing method of _IconWidget, used by IconTray

2012-08-23 Thread Simon Schampijer
Looks correct, please go ahead. Thanks, Simon On 08/23/2012 07:12 AM, Manuel Quiñones wrote: Invoker draw_rectangle() now receives a Cairo context, as can be seen in [1] The testcase is also fixed by this commit. Signed-off-by: Manuel Quiñones ma...@laptop.org [1]

Re: [Sugar-devel] Dist_xo of bundlebuilder

2012-08-23 Thread Simon Schampijer
On 08/23/2012 12:06 PM, Gonzalo Odiard wrote: Use git to get the list of files was done after deprecate the MANIFEST files And.. Why this patch was not applied?? http://lists.sugarlabs.org/archive/sugar-devel/2011-November/034196.html Good question. Gonzalo Thanks, this one got

[Sugar-devel] [PATCH sugar] Launcher: set the standard SPLASHSCREEN hint instead of our own _SUGAR_WINDOW_TYPE hint

2012-08-23 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org Currently we have issues with introspecting gdk_property_get and we already have a wrapper around gdk_property_change [1]. We discussed reimplementing the toolkit wm module in C, and provide the following functions: get_activity_id get_bundle_id

[Sugar-devel] [PATCH sugar-toolkit-gtk3] Key grabber: make grab_keys introspectable

2012-08-22 Thread Simon Schampijer
on how to test this is at [3]. The 'a' keystroke is grabbed by the key grabber. Signed-off-by: Simon Schampijer si...@laptop.org [1] https://live.gnome.org/PyGObject/IntrospectionPorting#Passing_arrays [2] https://live.gnome.org/GObjectIntrospection/Annotations#Default_Basic_Types [3] http

[Sugar-devel] [PATCH sugar] Journal: add alert to confirm before erasing an entry

2012-08-22 Thread Simon Schampijer
with Gary yesterday. Signed-off-by: Simon Schampijer si...@laptop.org [1] http://wiki.sugarlabs.org/go/Features/Touch/Development#Journal --- src/jarabe/journal/journaltoolbox.py | 31 +-- src/jarabe/journal/palettes.py | 22 +- 2 files changed, 46

Re: [Sugar-devel] [PATCH sugar] Remove _MouseListener from the frame - SL #3820

2012-08-22 Thread Simon Schampijer
On 08/21/2012 02:50 PM, Manuel Quiñones wrote: - Move the code of mouse_enter() method to a oneliner in the client class, so a class is not needed anymore. - Fix calls to non existant mouse_leave() method from commit 238338d4 . Signed-off-by: Manuel Quiñones ma...@laptop.org Thanks Manuel

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Key grabber: make grab_keys introspectable

2012-08-22 Thread Simon Schampijer
On 08/22/2012 01:58 PM, Manuel Quiñones wrote: Great Simon,I tested it in the shell port branch and the keystrokes for changing the zoom level and showing/hiding the frame are back. 2012/8/22 Simon Schampijer si...@schampijer.de: To the grab_keys function we pass a list of strings the key

[Sugar-devel] [PATCH sugar] Remove _MouseListener from the frame and cleanup, v2, SL #3820

2012-08-22 Thread Simon Schampijer
Move the code of mouse_enter() method into the client class, so a class is not needed anymore. Fix calls to non existent mouse_leave() method from commit 238338d4. Cleanup of unused leave methods due to the new behavior. Signed-off-by: Manuel Quiñones ma...@laptop.org Signed-off-by: Simon

Re: [Sugar-devel] [PATCH sugar] Remove _MouseListener from the frame - SL #3820

2012-08-22 Thread Simon Schampijer
On 08/22/2012 04:40 PM, Manuel Quiñones wrote: 2012/8/22 Simon Schampijer si...@schampijer.de: On 08/21/2012 02:50 PM, Manuel Quiñones wrote: - Move the code of mouse_enter() method to a oneliner in the client class, so a class is not needed anymore. - Fix calls to non existant

[Sugar-devel] [PATCH sugar] Clipboard, dragdrop: keep notification icon up-to-date, SL #3818

2012-08-21 Thread Simon Schampijer
/master/src/jarabe/frame/clipboardicon.py#line137 [3] http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardicon.py#line123 Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/frame/clipboardicon.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src

Re: [Sugar-devel] [PATCH sugar] Fix drag and drop to the clipboard - SL #3811

2012-08-21 Thread Simon Schampijer
...@laptop.org Acked-by: Simon Schampijer si...@laptop.org While testing your patch I came across #3818, #3819, #3820 :) Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [DESIGN] unfocus search entries in Views and the Journal

2012-08-21 Thread Simon Schampijer
On 08/21/2012 11:10 AM, Sascha Silbe wrote: Simon Schampijer si...@schampijer.de writes: I would suggest the following new behavior: - the entry is unfocused by default, the canvas is focused - the entry contains a hint (e.g. Search in your Journal...), adding a placeholder text is available

Re: [Sugar-devel] [PATCH sugar] Frame: reveal Palette on left click for device, friends and clipboard items v2

2012-08-21 Thread Simon Schampijer
On 08/21/2012 11:15 AM, Sascha Silbe wrote: Simon Schampijer si...@schampijer.de writes: As well the clipboard icons will reveal now the Palette on left click. This is also true when selecting a clipboard item. Technically we have to listen to the 'button-release-event' of the child widget

[Sugar-devel] [REMINDER] Development team meeting --- 21 August 2012 (15:00 UTC)

2012-08-21 Thread Simon Schampijer
Hi, today we will have our weekly dev team meeting. Time: 21. August 2012 (15:00 UTC) Place: #sugar-meeting (freenode) Topics: - introducing new contributors - 0.98 Feature proposal deadline - follow up the shell port: http://wiki.sugarlabs.org/go/Features/GTK3/Shell (manuq) - follow up

Re: [Sugar-devel] [DESIGN] Journal: confirmation before erasing/duplicating an entry

2012-08-21 Thread Simon Schampijer
On 08/21/2012 01:57 PM, Gary Martin wrote: Hi Simon, On 21 Aug 2012, at 05:17, Simon Schampijer si...@schampijer.de wrote: On 08/20/2012 11:21 PM, Manuel Quiñones wrote: 2012/8/19 Simon Schampijer si...@schampijer.de: Hi, I have been working on the confirmation alert for the Journal

Re: [Sugar-devel] [FEATURE] [DESIGN] Display Device

2012-08-21 Thread Simon Schampijer
Hi Gary, thanks for having a look! On 08/21/2012 02:34 PM, Gary Martin wrote: Hi Simon, On 21 Aug 2012, at 12:18, Simon Schampijer si...@schampijer.de wrote: Hi, this Feature Display Device [1] has been proposed for 0.96 inclusion already but did not make it in due to time constraints

Re: [Sugar-devel] [FEATURE] [DESIGN] Display Device

2012-08-21 Thread Simon Schampijer
Hi Gary, On 08/21/2012 04:13 PM, Gary Martin wrote: Hi Simon, On 21 Aug 2012, at 13:44, Simon Schampijer si...@schampijer.de wrote: Hi Gary, thanks for having a look! On 08/21/2012 02:34 PM, Gary Martin wrote: Hi Simon, On 21 Aug 2012, at 12:18, Simon Schampijer si...@schampijer.de wrote

[Sugar-devel] pop-up window

2012-08-21 Thread Simon Schampijer
Hi, those are ack by me, do not cause any harm on Metacity so if this makes other window manager users happy, please go ahead. http://patchwork.sugarlabs.org/patch/826/ http://patchwork.sugarlabs.org/patch/827/ Please submit as well a patch for toolkit-gtk3. Regards, Simon

[Sugar-devel] [MINUTES] Development team meeting --- 21 August 2012 (15:00 UTC)

2012-08-21 Thread Simon Schampijer
Minutes: http://meeting.sugarlabs.org/sugar-meeting/meetings/2012-08-21T14:59:21.html Log: http://meeting.sugarlabs.org/sugar-meeting/meetings/2012-08-21T14:59:21 Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org

Re: [Sugar-devel] [DESIGN] Frame Device icon Volumes

2012-08-20 Thread Simon Schampijer
On 08/19/2012 08:04 PM, Gary Martin wrote: On 19 Aug 2012, at 15:54, Simon Schampijer si...@schampijer.de wrote: On 08/19/2012 03:45 PM, Gonzalo Odiard wrote: There are a convention about the position of the primary action? Should be the closest to the button or the first at top

Re: [Sugar-devel] [PATCH sugar] Frame: new behavior for revealing/hiding the Frame with the mouse

2012-08-20 Thread Simon Schampijer
On 08/20/2012 04:44 PM, Manuel Quiñones wrote: 2012/8/17 Simon Schampijer si...@schampijer.de: On 08/17/2012 12:48 AM, Manuel Quiñones wrote: I've tested an earlier patch for this and now I reviewed it. This is a much more solid interaction with the frame, and less error prone. All looks

[Sugar-devel] [RELEASE] sugar-0.97.1

2012-08-20 Thread Simon Schampijer
The 'no-hippo' release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar/sugar-0.97.1.tar.bz2 == News == * Release 0.97.1 (Simon Schampijer) * SpreadLayout: do not remove items from the grid if there is none yet, SL #3814 (Simon Schampijer) * Use the gdk window to get

Re: [Sugar-devel] [PATCH sugar] SpreadLayout: do not remove items from the grid if there is none yet, SL #3814

2012-08-20 Thread Simon Schampijer
On 08/20/2012 05:45 PM, Manuel Quiñones wrote: Good fix. I was seeing this issue of not initialized grid in the shell port too. 2012/8/19 Simon Schampijer si...@schampijer.de: A grid is added to the ViewContainer when the children are allocated, we can not do it earlier because we need

Re: [Sugar-devel] [PATCH sugar] Making the buddy icons in the Views reveal the Palette on left click or touch

2012-08-20 Thread Simon Schampijer
On 08/16/2012 02:07 PM, Manuel Quiñones wrote: Very good Simon, 2012/8/15 Simon Schampijer si...@schampijer.de: The owner icon (in the Home, Group and Neighborhood View) has no primary action. On left click we agreed to always reveal the Palette. This will give a better experience for users

Re: [Sugar-devel] [PATCH sugar] Neighborhood View: reveal Palette on left click/touch instead of a primary action

2012-08-20 Thread Simon Schampijer
On 08/16/2012 02:10 PM, Manuel Quiñones wrote: 2012/8/15 Simon Schampijer si...@schampijer.de: Having a primary action for the icons in the Neighborhood View like the AP icon, the Ad-hoc, the Mesh network icon and the icon for a shared activity has never been a fully working UI design because

Re: [Sugar-devel] [PATCH sugar] Frame: new behavior for revealing/hiding the Frame with the mouse

2012-08-20 Thread Simon Schampijer
On 08/20/2012 05:06 PM, Manuel Quiñones wrote: 2012/8/20 Simon Schampijer si...@schampijer.de: On 08/20/2012 04:44 PM, Manuel Quiñones wrote: 2012/8/17 Simon Schampijer si...@schampijer.de: On 08/17/2012 12:48 AM, Manuel Quiñones wrote: I've tested an earlier patch for this and now I

Re: [Sugar-devel] [DESIGN] Journal: confirmation before erasing/duplicating an entry

2012-08-20 Thread Simon Schampijer
On 08/20/2012 11:21 PM, Manuel Quiñones wrote: 2012/8/19 Simon Schampijer si...@schampijer.de: Hi, I have been working on the confirmation alert for the Journal, submitted a patch [1]. Erasing an entry in the Journal does not ask for confirmation before doing the erase. This patch adds

[Sugar-devel] [PATCH sugar] Frame: reveal Palette on left click for device, friends and clipboard items v2

2012-08-19 Thread Simon Schampijer
further (return False) so that the state change when selecting another item is picked up. Signed-off-by: Simon Schampijer si...@laptop.org [1] http://developer.gnome.org/gtk3/3.4/GtkToggleToolButton.html#gtk-toggle-tool-button-set-active ---v2--- Add bhavior for the Frame Device icon Volumes

[Sugar-devel] [PATCH sugar] Journal: add alert to confirm before erasing an entry

2012-08-19 Thread Simon Schampijer
Erasing an entry in the Journal does not ask for confirmation before doing the erase. This patch adds an alert to the ListView and the DetailView that asks for confirmation before doing the erase. This is part of the touch interaction work [1]. Signed-off-by: Simon Schampijer si...@laptop.org [1

[Sugar-devel] [DESIGN] Journal: confirmation before erasing/duplicating an entry

2012-08-19 Thread Simon Schampijer
Hi, I have been working on the confirmation alert for the Journal, submitted a patch [1]. Erasing an entry in the Journal does not ask for confirmation before doing the erase. This patch adds an alert to the ListView and the DetailView that asks for confirmation before doing the erase. This

Re: [Sugar-devel] Maintenance, reviews, QA co

2012-08-19 Thread Simon Schampijer
Hi Sascha, On 08/11/2012 10:53 PM, Sascha Silbe wrote: Dear Sugar Labs members, == Executive Summary == The current review process isn't a good fit for the current Sugar contributors and causes a lot of frustration on both sides. There are better ways to reach the same goals. The two major

[Sugar-devel] [PATCH sugar] Frame: new behavior for revealing/hiding the Frame with the mouse

2012-08-17 Thread Simon Schampijer
is selected - (as before) you can use 'alt-tab' to cycle through the running activities - drag drop is currently not working, SL #3811 v2: fixed cycling through running activities Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/frame/activitiestray.py | 2 ++ src/jarabe/frame

Re: [Sugar-devel] [PATCH sugar] Frame: new behavior for revealing/hiding the Frame with the mouse

2012-08-17 Thread Simon Schampijer
On 08/17/2012 12:48 AM, Manuel Quiñones wrote: I've tested an earlier patch for this and now I reviewed it. This is a much more solid interaction with the frame, and less error prone. All looks good. Please commit. Thanks Manuel for testing and the review. I have fixed the 'cycling through

Re: [Sugar-devel] [PATCH sugar] Create a default unencrypted keyring, OLPC #10290

2012-08-17 Thread Simon Schampijer
On 06/11/2012 07:11 PM, Simon Schampijer wrote: Follow-up: Upstream seem to work on the possibility to use the XDG dirs, so one can specify an alternative path. https://bugzilla.gnome.org/show_bug.cgi?id=613644 Thanks to Marco for pointing that out, Simon The enhancement to use the XDG

Re: [Sugar-devel] [PATCH] Use the gdk window to get the depth of the preview pixmap - SL#3804

2012-08-17 Thread Simon Schampijer
On 08/17/2012 03:06 PM, Manuel Quiñones wrote: This prevents harcoding the depth, and uses the one from the gdk window. For this, the preview has to be done after the window is realized, so the code is wrapped in the expose-event callback. Also add a white background to the preview, otherwise

[Sugar-devel] [PATCH sugar] Frame: reveal Palette on left click for device, friends and clipboard items

2012-08-16 Thread Simon Schampijer
further (return False) so that the state change when selecting another item is picked up. Signed-off-by: Simon Schampijer si...@laptop.org [1] http://developer.gnome.org/gtk3/3.4/GtkToggleToolButton.html#gtk-toggle-tool-button-set-active --- extensions/deviceicon/battery.py | 5

[Sugar-devel] [DESIGN] Frame Device icon Volumes

2012-08-16 Thread Simon Schampijer
Hi, working on the 'reveal palette on left click' behavior change for the Frame device icons [1] I came across the following behavior for the Volumes device icons: - when you click on the icon it will resume the Journal and show the contents of the volume - if you reveal the Palette

[Sugar-devel] [RELEASE] sugar-toolkit-0.97.0

2012-08-16 Thread Simon Schampijer
== Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit/sugar-toolkit-0.97.0.tar.bz2 == News == * Release 0.97.0 (Simon Schampijer) * Use json as included in Python SL #3142 (Simon Schampijer) * Allow to build outside source directory (Daniel Narvaez) * presence: use

[Sugar-devel] [PATCH sugar] Journal, no-hippo: set white background for no-matching-entry message, SL #3808

2012-08-16 Thread Simon Schampijer
The 'no-matching-entry' message in the Journal listview is grey after the hippo removal. Add a gtk.EventBox because the gtk.VBox doesn't have a gtk.gdk.Window associated with it and the background can't be set otherwise. See d9fbf9d for the same resolution of the issue. Signed-off-by: Simon

Re: [Sugar-devel] [PATCH sugar] Journal, no-hippo: set white background for no-matching-entry message, SL #3808

2012-08-16 Thread Simon Schampijer
On 08/16/2012 12:33 PM, Simon Schampijer wrote: The 'no-matching-entry' message in the Journal listview is grey after the hippo removal. Add a gtk.EventBox because the gtk.VBox doesn't have a gtk.gdk.Window associated with it and the background can't be set otherwise. See d9fbf9d for the same

[Sugar-devel] [PATCH sugar] Frame: new behavior for revealing/hiding the Frame with the mouse

2012-08-16 Thread Simon Schampijer
is selected - drag drop is currently not working, SL #3811 Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/frame/activitiestray.py | 2 ++ src/jarabe/frame/frame.py | 51 ++ src/jarabe/frame/zoomtoolbar.py| 6 + 3 files changed, 21

[Sugar-devel] [RELEASE] sugar-toolkit-gtk3-0.96.5

2012-08-15 Thread Simon Schampijer
== Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit-gtk3/sugar-toolkit-gtk3-0.96.5.tar.bz2 == News == * Release 0.96.5 (Simon Schampijer) * Replace signal used in UnfullscreenButton to enable use with touch - SL #3798 (Gonzalo Odiard) * Solve errors

[Sugar-devel] [RELEASE] sugar-toolkit-gtk3-0.97.0

2012-08-15 Thread Simon Schampijer
== Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit-gtk3/sugar-toolkit-gtk3-0.97.0.tar.bz2 == News == * Release 0.97.0 (Simon Schampijer) * Replace signal used in UnfullscreenButton to enable use with touch - SL #3798 (Gonzalo Odiard) * Solve errors

Re: [Sugar-devel] [PATCH] Add icon zoom-to-width

2012-08-15 Thread Simon Schampijer
Looks good, please get it in. Simon On 08/15/2012 03:27 PM, Manuel Quiñones wrote: Was made by Gonzalo Odiard for Read activity, based in other zoom icons. And was cleaned by Gary Martin for inclussion in the Sugar Artwork. Signed-off-by: Manuel Quiñones ma...@laptop.org ---

<    1   2   3   4   5   6   7   8   9   10   >