[Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread Martin Abente Lahaye
Hello Everyone, Christofer Roibal, has submitted a patch [1] for changing the mime type of journal entries in the details view. This idea comes from a GCI task [2] which he has completed. What he did is replacing the Gtk.Label, that shows the mime type, for a Gtk.ComboBox. The combo is set to the

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread Gonzalo Odiard
My principal concern is a user can change the mime type, and later the activities can't manage the object. How common is the problem described in the bug [1]? Is a alternative show the combo only if the user press a shortcut? Or maybe er need add a "More options" button in the detailview, and reo

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread Daniel Narvaez
The ticket mention web servers misconfiguration. That might be pretty common but I think the right fix for that case is to use GIO to get the mime type (which will look at the file content) instead of trusting the server. If GIO detects the mime incorrectly (does that really happen?), then I don't

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread Gonzalo Odiard
+1 I think that is already done: https://git.sugarlabs.org/browse/mainline/blobs/master/downloadmanager.py#line210 May be we should detect if taht is not working in particular cases, and solve them. Gonzalo On Mon, Nov 25, 2013 at 3:42 PM, Daniel Narvaez wrote: > The ticket mention web serv

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread James Cameron
I'm fine with the change by Christofer. While it is possible for a learner to change the mime type to something that cannot be managed by an activity, the risk is low, because detail view requires deliberate action to obtain, and the mime type can always be changed back. If the risk is found to b

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-25 Thread James Cameron
The second screenshot shows no apparent ordering for the entries in the Gtk.ComboBox. Perhaps it should be sorted. On Mon, Nov 25, 2013 at 11:45:48PM -0200, Christofer Roibal wrote: > Imágenes integradas 1Imágenes integradas 2 > > > 2013/11/25 James Cameron > > I'm fine with the change by

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-26 Thread Gonzalo Odiard
I insist. If we need a mechanism to change the mime type, maybe is better create a activity to do it. Expose all that options in the detail view in the Journal is not a good idea for me. Gonzalo On Mon, Nov 25, 2013 at 11:04 PM, James Cameron wrote: > The second screenshot shows no apparent or

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-26 Thread Ignacio Rodríguez
For design I like it (my idea): [image: Imágenes integradas 1] [image: Imágenes integradas 2] (Need to be tested in Sugar) Code Saludos. Ignacio Rodríguez 2013/11/26 Gonzalo Odiard > I insist. If we need a mechanism to change the mime

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-26 Thread Gonzalo Odiard
Certainly is better. But I need ask, how is supposed the user can know the right mime type he/she would select? Gonzalo On Tue, Nov 26, 2013 at 8:16 AM, Ignacio Rodríguez wrote: > For design I like it (my idea): > > [image: Imágenes integradas 1] > > [image: Imágenes integradas 2] > > (Need to

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-11-26 Thread Daniel Narvaez
It would be good to know what exactly is the use case, if nothing else... On Tuesday, 26 November 2013, Gonzalo Odiard wrote: > I insist. If we need a mechanism to change the mime type, maybe is better > create a activity to do it. > Expose all that options in the detail view in the Journal is no

Re: [Sugar-devel] [DESIGN] Changing mime type in journal details view.

2013-12-03 Thread Manuel Quiñones
James, 2013/11/25 James Cameron : > I'm fine with the change by Christofer. > > While it is possible for a learner to change the mime type to > something that cannot be managed by an activity, the risk is low, > because detail view requires deliberate action to obtain, and the mime > type can alwa