Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

On Sat, Jun 18, 2011 at 11:23 AM, Gonzalo Odiard gonz...@laptop.org wrote: On Sat, Jun 18, 2011 at 8:44 AM, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Gonzalo Odiard's message of Wed Jun 08 17:04:41 +0200 2011: To test with multiple tabs, in F14 I needed to

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

Excerpts from godiard's message of Wed Jun 08 17:09:14 +0200 2011: If the user go back, or select any page in the history and close the activity, need restore at the next start, the history, and the index in the history too. Thanks for the patch! Pushed as 7072ec5 [1]. Sascha [1]

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

On Sat, Jun 18, 2011 at 8:44 AM, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Gonzalo Odiard's message of Wed Jun 08 17:04:41 +0200 2011: To test with multiple tabs, in F14 I needed to replace: -self._disable_multiple_tabs = cairo.cairo_version() = 10810

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

Thanks by the review. Gonzalo On Sat, Jun 18, 2011 at 8:33 AM, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from godiard's message of Wed Jun 08 17:09:14 +0200 2011: If the user go back, or select any page in the history and close the activity, need restore at the

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

Thanks Rafael Gonzalo On Wed, Jun 15, 2011 at 1:31 PM, Rafael Ortiz raf...@activitycentral.comwrote: On Wed, Jun 15, 2011 at 7:01 AM, Gonzalo Odiard godi...@gmail.com wrote: Any of the Browse developers is interested in review this patch? Thanks I'm not a Browse developer but I've

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

Any of the Browse developers is interested in review this patch? Thanks Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

On Wed, Jun 15, 2011 at 7:01 AM, Gonzalo Odiard godi...@gmail.com wrote: Any of the Browse developers is interested in review this patch? Thanks I'm not a Browse developer but I've tested this change and works for me. btw I also tested with your cairo modification on sugar-0.88/sweets for

[Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

From: Gonzalo Odiard godi...@gmail.com If the user go back, or select any page in the history and close the activity, need restore at the next start, the history, and the index in the history too. --- browser.py |7 ++- webactivity.py | 26 ++ webtoolbar.py

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

Sasha: In this patch I have addressed your comments. To test with multiple tabs, in F14 I needed to replace: -self._disable_multiple_tabs = cairo.cairo_version() = 10810 +self._disable_multiple_tabs = cairo.cairo_version() = 10810 \ +and cairo.cairo_version()