[Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-13 Thread shanjit
From: Shanjit Singh Jajmann Muting by clicking on the icon is killed. --- extensions/deviceicon/speaker.py | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py index 3a54464..4242105 100644 --- a/ex

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-13 Thread Gonzalo Odiard
Reviewed-By: gonz...@laptop.org On Sat, Nov 13, 2010 at 7:08 AM, wrote: > From: Shanjit Singh Jajmann > > Muting by clicking on the icon is killed. > --- > extensions/deviceicon/speaker.py | 10 -- > 1 files changed, 0 insertions(+), 10 deletions(-) > > diff --git a/extensions/device

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-14 Thread James Cameron
On Sat, Nov 13, 2010 at 05:38:14PM +0530, shan...@seeta.in wrote: > From: Shanjit Singh Jajmann > > Muting by clicking on the icon is killed. This disables unmuting as well. Hope that is what you intended. Reviewed-by: James Cameron -- James Cameron http://quozl.linux.org.au/ __

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-15 Thread Martin Dengler
On Sat, Nov 13, 2010 at 05:38:14PM +0530, shan...@seeta.in wrote: > From: Shanjit Singh Jajmann > > Muting by clicking on the icon is killed. NAK. This functionality was requested by a deployment[1], AFAICS. Martin 1. http://dev.laptop.org/ticket/7730#comment:16 pgpoRC8z3sPpB.pgp Descriptio

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-27 Thread Sascha Silbe
Excerpts from shanjit's message of Sat Nov 13 13:08:14 +0100 2010: > diff --git a/extensions/deviceicon/speaker.py > b/extensions/deviceicon/speaker.py > index 3a54464..4242105 100644 > --- a/extensions/deviceicon/speaker.py > +++ b/extensions/deviceicon/speaker.py > @@ -50,9 +50,6 @@ class Devic

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-28 Thread Gary Martin
On 27 Nov 2010, at 20:41, Sascha Silbe wrote: > Excerpts from shanjit's message of Sat Nov 13 13:08:14 +0100 2010: > >> diff --git a/extensions/deviceicon/speaker.py >> b/extensions/deviceicon/speaker.py >> index 3a54464..4242105 100644 >> --- a/extensions/deviceicon/speaker.py >> +++ b/extens

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-11-29 Thread Simon Schampijer
On 11/28/2010 11:11 AM, Gary Martin wrote: On 27 Nov 2010, at 20:41, Sascha Silbe wrote: Excerpts from shanjit's message of Sat Nov 13 13:08:14 +0100 2010: diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py index 3a54464..4242105 100644 --- a/extensions/devicei

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-12-06 Thread Shanjit Singh Jajmann
Team, I thank you all for having a look at the patch and for recommending necessary changes. I am sending a revised patch for the same. Feedback and Response appreciated. Shan On Sat, Nov 13, 2010 at 6:45 PM, Gonzalo Odiard wrote: > Reviewed-By: gonz...@laptop.org > > > On Sat, Nov 13, 2010

Re: [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

2010-12-06 Thread Shanjit Singh Jajmann
Team, I tried sending a patch to this thread by following the standard procedure of copying and pasting the message id to the "in-reply-to : ". However, for some reason the patch goes on to the different thread. Please find the link to the patch, http://patchwork.sugarlabs.org/patch/519/ Shan