Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-28 Thread Tomeu Vizoso
On Fri, Apr 23, 2010 at 23:21, Walter Bender wrote: > On Fri, Apr 23, 2010 at 2:52 PM, Daniel Drake wrote: >> On 23 April 2010 15:02, Sascha Silbe >> wrote: >>> I like the proposal of renaming Keep to Copy and placing it in the palette >>> of the Stop button. I was a bit worried about it gettin

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-24 Thread Frederick Grose
On Fri, Apr 23, 2010 at 2:02 PM, Sascha Silbe < sascha-ml-ui-sugar-de...@silbe.org> wrote: > On Fri, Apr 23, 2010 at 01:10:53PM -0400, Frederick Grose wrote: > > I imagine that with the 'Keep a copy' action option on the proposed, >> 'Stop' button panel, Sugar Learners might see that phrase, and

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Walter Bender
On Fri, Apr 23, 2010 at 2:52 PM, Daniel Drake wrote: > On 23 April 2010 15:02, Sascha Silbe > wrote: >> I like the proposal of renaming Keep to Copy and placing it in the palette >> of the Stop button. I was a bit worried about it getting confused with the >> clipboard action of the same name, b

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Daniel Drake
On 23 April 2010 15:02, Sascha Silbe wrote: > I like the proposal of renaming Keep to Copy and placing it in the palette > of the Stop button. I was a bit worried about it getting confused with the > clipboard action of the same name, but making it a secondary action of the > Stop button should he

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Sascha Silbe
On Fri, Apr 23, 2010 at 09:48:30AM -0400, Bernie Innocenti wrote: Ugh. We clearly need to put a lot more thought into Journal interaction: FWIW, we mostly need someone to actually implement many of the nice Journal designs [1] - somebody has already put some thought into the design, but so far

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Sascha Silbe
On Fri, Apr 23, 2010 at 01:10:53PM -0400, Frederick Grose wrote: I imagine that with the 'Keep a copy' action option on the proposed, 'Stop' button panel, Sugar Learners might see that phrase, and again, panic about 'saving' their Activity. An action option labelled 'Copy' may instead suggest

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Frederick Grose
On Fri, Apr 23, 2010 at 9:48 AM, Bernie Innocenti wrote: > On Thu, 2010-04-22 at 23:35 -0400, Frederick Grose wrote: > > > > Yes that would work, and wouldn't leave a hidden button taking up > > space on the tool bar. > > Ok, we'll work on a patch to do this. > > > > By the way, I don't see how on

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-23 Thread Bernie Innocenti
On Thu, 2010-04-22 at 23:35 -0400, Frederick Grose wrote: > Yes that would work, and wouldn't leave a hidden button taking up > space on the tool bar. Ok, we'll work on a patch to do this. > By the way, I don't see how one keeps a copy from the Journal to a new > Journal item. One can copy to

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-22 Thread Frederick Grose
On Thu, Apr 22, 2010 at 8:46 PM, Bernie Innocenti wrote: > On Wed, 2010-04-21 at 20:34 -0400, Frederick Grose wrote: > > > Got it, sounds good, thanks. Here's the obvious patch. > > > > > > -0.5 > > > Please, let's move halfway so we don't break workflows already > > established. For exa

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-22 Thread Bernie Innocenti
On Wed, 2010-04-21 at 20:34 -0400, Frederick Grose wrote: > Got it, sounds good, thanks. Here's the obvious patch. > > > -0.5 > Please, let's move halfway so we don't break workflows already > established. For example, someone has already developed lessons for > that involve keeping P

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-22 Thread Sascha Silbe
On Thu, Apr 22, 2010 at 08:32:05AM -0400, Benjamin M. Schwartz wrote: In English a comma may or may not be used before the final conjunction (and, or, nor) in a list of more than two elements. Interesting; thanks for the quote. CU Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-22 Thread Benjamin M. Schwartz
Sascha Silbe wrote: > On Wed, Apr 21, 2010 at 07:35:44PM -0400, Chris Ball wrote: > >> """The Activity toolbar with the Journal entry title, sharing, >> - Keep and Stop buttons >> + and Stop button > Nitpick: please remove the comma after sharing. http://en.wikipedia.org/wiki/Co

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 07:35:44PM -0400, Chris Ball wrote: """The Activity toolbar with the Journal entry title, sharing, - Keep and Stop buttons + and Stop button Nitpick: please remove the comma after sharing. After this change: Reviewed-By: Sascha Silbe CU Sascha -- h

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-21 Thread Frederick Grose
On Wed, Apr 21, 2010 at 7:35 PM, Chris Ball wrote: > Hi, > > > No, sorry. The current prompt-on-quit is fine, as it only occurs > > when you stop a brand new activity instance. It basically asks > > "do you want me to keep track of this thing in your Journal," and > > from then on it wil

[Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-21 Thread Chris Ball
Hi, > No, sorry. The current prompt-on-quit is fine, as it only occurs > when you stop a brand new activity instance. It basically asks > "do you want me to keep track of this thing in your Journal," and > from then on it will auto-save as usual. > > Since the Keep button is ca