Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-06-09 Thread James Cameron
On Thu, May 20, 2010 at 07:15:08AM +1000, James Cameron wrote: > Reviewed-by: James Cameron This review tag didn't reach git. http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/d6ebfcbb4d93610bf30df517fcd5360fdd083b50 -- James Cameron http://quozl.linux.org.au/

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-26 Thread Sascha Silbe
Excerpts from Tomeu Vizoso's message of Wed May 19 12:34:57 + 2010: > From: Tomeu Vizoso > > --- Please provide a more complete patch description. Only after Bernie posted his version of your patch did I understand what the point of it was. [src/jarabe/util/emulator.py] > @@ -152,11 +150,1

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-26 Thread James Cameron
On Wed, May 26, 2010 at 11:05:11AM +0200, Tomeu Vizoso wrote: > On Wed, May 19, 2010 at 23:15, James Cameron wrote: > > I'm unsure of the reasons for the change. > > > > Instead of setting DISPLAY and SUGAR_EMULATOR_PID environment variables > > repeatedly for each attempt to run Xephyr, set the v

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-26 Thread Tomeu Vizoso
On Wed, May 19, 2010 at 23:21, Bert Freudenberg wrote: > On 19.05.2010, at 14:15, James Cameron wrote: >> >>  each attempt to run Xephyr > > Just want to mention that I've been using the VNC-based Sugar emulator for > quite a while, and it works much better than Xephyr. > > http://bugs.sugarlabs.

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-26 Thread Tomeu Vizoso
On Wed, May 19, 2010 at 23:15, James Cameron wrote: > I'm unsure of the reasons for the change. > > Instead of setting DISPLAY and SUGAR_EMULATOR_PID environment variables > repeatedly for each attempt to run Xephyr, set the variables once. But that's what the patch does, moves setting those vari

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-19 Thread James Cameron
On Wed, May 19, 2010 at 02:21:01PM -0700, Bert Freudenberg wrote: > Just want to mention that I've been using the VNC-based Sugar emulator > for quite a while, and it works much better than Xephyr. Good point, so it does. I've respun the patch and posted it for further review. -- James Cameron

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-19 Thread Bert Freudenberg
On 19.05.2010, at 14:15, James Cameron wrote: > > each attempt to run Xephyr Just want to mention that I've been using the VNC-based Sugar emulator for quite a while, and it works much better than Xephyr. http://bugs.sugarlabs.org/ticket/1659 - Bert - ___

Re: [Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-19 Thread James Cameron
I'm unsure of the reasons for the change. Instead of setting DISPLAY and SUGAR_EMULATOR_PID environment variables repeatedly for each attempt to run Xephyr, set the variables once. This would be effective in reducing CPU cost if there is contention in display numbers. Further efficiency during c

[Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched

2010-05-19 Thread Tomeu Vizoso
From: Tomeu Vizoso --- src/jarabe/util/emulator.py | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py index 3eb817f..4155985 100644 --- a/src/jarabe/util/emulator.py +++ b/src/jarabe/util/emulator.py @@ -

[Sugar-devel] [PATCH] Set the DISPLAY env var once Xephyr has been launched #1860

2010-05-19 Thread Tomeu Vizoso
Hi, reviews appreciated. Thanks, Tomeu ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel