Re: [Sugar-devel] [PATCH] XO_Packager: package files in git and the locale folder

2011-09-19 Thread Simon Schampijer
On 09/19/2011 06:17 PM, Daniel Drake wrote: On Tue, Sep 13, 2011 at 11:13 AM, Simon Schampijer wrote: I just tested this patch while doing the Browse release (you have to be in a jhbuild environment to not use the system-wide bundle builder). Works for me as expected. Comments/Review on the pat

Re: [Sugar-devel] [PATCH] XO_Packager: package files in git and the locale folder

2011-09-19 Thread Daniel Drake
On Tue, Sep 13, 2011 at 11:13 AM, Simon Schampijer wrote: > I just tested this patch while doing the Browse release (you have to be in a > jhbuild environment to not use the system-wide bundle builder). Works for me > as expected. Comments/Review on the patch? Reviewed. Looks fine for API-frozen

Re: [Sugar-devel] [PATCH] XO_Packager: package files in git and the locale folder

2011-09-13 Thread Simon Schampijer
On 09/10/2011 04:07 PM, Simon Schampijer wrote: For clarification: the code does fallback to the previous behavior when the git-ls command does fail. So for example you can do a bundle from your activity folder on the XO, so as well when it is not a git checkout. Thanks Gary for clarifying this

Re: [Sugar-devel] [PATCH] XO_Packager: package files in git and the locale folder

2011-09-10 Thread Simon Schampijer
For clarification: the code does fallback to the previous behavior when the git-ls command does fail. So for example you can do a bundle from your activity folder on the XO, so as well when it is not a git checkout.   Thanks Gary for clarifying this point,    Simon      Simon Schampijer hat am 10

[Sugar-devel] [PATCH] XO_Packager: package files in git and the locale folder

2011-09-10 Thread Simon Schampijer
Hi, there have been reports (e.g. [1]) about Activities that had unexpected files in the xo bundle (e.g. patches). There have been a recent change that the support for the MANIFEST has been removed from the bundle builder. The MANIFEST 'controlled' which files were bundled. The current code does