Because of missing initialization and a weak test for the existence of
the object (self._update_signal_match is not None) Turtle Art was
crashing when resuming from the Journal.
Signed-off-by: Raúl Gutiérrez S.
Ackd-by: Bernie Innocenti
---
src/sugar/datastore/datastore.py |1 +
1 files ch
Forgot to mention that this is for 0.84 branch, 0.88 does it right.
On Mon, 2010-04-26 at 15:50 -0400, Raul Gutierrez Segales wrote:
> Because of missing initialization and a weak test for the existence of
> the object (self._update_signal_match is not None) Turtle Art was
> crashing when resumi
On Mon, Apr 26, 2010 at 03:50:17PM -0400, Raul Gutierrez Segales wrote:
> Because of missing initialization and a weak test for the existence of
> the object (self._update_signal_match is not None) Turtle Art was
> crashing when resuming from the Journal.
Reviewed, but I didn't understand. This
James,
On Tue, 2010-04-27 at 11:25 +1000, James Cameron wrote:
> On Mon, Apr 26, 2010 at 03:50:17PM -0400, Raul Gutierrez Segales wrote:
> > Because of missing initialization and a weak test for the existence of
> > the object (self._update_signal_match is not None) Turtle Art was
> > crashing wh
On Tue, Apr 27, 2010 at 09:43:21AM -0400, Raul Gutierrez Segales wrote:
> Looking at it with more detail, the problem is that
> self._update_signal_match is initialized in the wrong order (after a
> call to set_object_id that depends on it).
No worries, now I understand, and approve.
Reviewed-by
On Wed, 2010-04-28 at 09:56 +1000, James Cameron wrote:
> On Tue, Apr 27, 2010 at 09:43:21AM -0400, Raul Gutierrez Segales wrote:
> > Looking at it with more detail, the problem is that
> > self._update_signal_match is initialized in the wrong order (after a
> > call to set_object_id that depends o
On Wed, Apr 28, 2010 at 10:57:24AM -0400, Raul Gutierrez Segales wrote:
Great, what is the next step for inclusion? (I have no commit access
to sugar-toolkit).
Please provide the updated patch (i.e. including
Reviewed-By/Tested-By/... lines) as a separate MIME part (I don't care
whether it's m
El Wed, 28-04-2010 a las 19:33 +0200, Sascha Silbe escribió:
> Please provide the updated patch (i.e. including
> Reviewed-By/Tested-By/... lines) as a separate MIME part (I don't care
> whether it's marked inline or attachment, but it needs to be a separate
> MIME part so it doesn't get munged
On Thu, Apr 29, 2010 at 12:32:25AM -0400, Bernie Innocenti wrote:
> Hmm... sugar-toolkit is missing a MAINTAINERS file.
+1
> It would be good to add it, or document the current maintainer
> mappings somewhere (gitorious, wiki...)
Only put it somewhere else if you don't want people to find it whe
9 matches
Mail list logo
