Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-07-06 Thread Sascha Silbe
Excerpts from Walter Bender's message of Thu May 19 13:56:51 +0200 2011: > Also attached is a new version of the patch to volumestoolbar.py since > Gary's icon has a different name than the one I had been using. Please send patches inline for easier review and to see them on Patchwork, making sur

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-19 Thread Martin Langhoff
On Thu, May 19, 2011 at 8:48 AM, Rodolfo D. Arce S. wrote: > I was wondering if you had considered if the Documents folder is translated. > I know that gnome when changing the default language for the user sometimes > renames the folders ("Documents" -> "Documentos, "Download" -> "Descargas", > et

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-19 Thread Rodolfo D. Arce S.
Hello: I was wondering if you had considered if the Documents folder is translated. I know that gnome when changing the default language for the user sometimes renames the folders ("Documents" -> "Documentos, "Download" -> "Descargas", etc) This is made usually during instalation or when the user

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-19 Thread Walter Bender
On Thu, May 19, 2011 at 7:50 AM, Walter Bender wrote: > > > On Mon, May 16, 2011 at 2:54 PM, Walter Bender wrote: > >> On Mon, May 16, 2011 at 2:17 PM, Gary Martin >> wrote: >> > Hi Walter, >> > >> > On 14 May 2011, at 15:35, Walter Bender wrote: >> > >> >> On Sat, May 14, 2011 at 10:21 AM, Gary

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-19 Thread Walter Bender
On Mon, May 16, 2011 at 2:54 PM, Walter Bender wrote: > On Mon, May 16, 2011 at 2:17 PM, Gary Martin > wrote: > > Hi Walter, > > > > On 14 May 2011, at 15:35, Walter Bender wrote: > > > >> On Sat, May 14, 2011 at 10:21 AM, Gary Martin > >> wrote: > >>> Hi Walter, > >>> > >>> On 10 May 2011, at 1

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-16 Thread Walter Bender
On Mon, May 16, 2011 at 2:17 PM, Gary Martin wrote: > Hi Walter, > > On 14 May 2011, at 15:35, Walter Bender wrote: > >> On Sat, May 14, 2011 at 10:21 AM, Gary Martin >> wrote: >>> Hi Walter, >>> >>> On 10 May 2011, at 13:54, Walter Bender wrote: >>> As per a discussion at the EduJam and Sug

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-16 Thread Gary Martin
Hi Walter, On 14 May 2011, at 15:35, Walter Bender wrote: > On Sat, May 14, 2011 at 10:21 AM, Gary Martin > wrote: >> Hi Walter, >> >> On 10 May 2011, at 13:54, Walter Bender wrote: >> >>> As per a discussion at the EduJam and Sugar Code Sprint, I have >>> modified a patch by tch to add access

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-14 Thread Walter Bender
On Sat, May 14, 2011 at 10:21 AM, Gary Martin wrote: > Hi Walter, > > On 10 May 2011, at 13:54, Walter Bender wrote: > >> As per a discussion at the EduJam and Sugar Code Sprint, I have >> modified a patch by tch to add access to ~/Documents to the volume >> toolbar in the Journal. >> >> Two patch

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-14 Thread Gary Martin
Hi Walter, On 10 May 2011, at 13:54, Walter Bender wrote: > As per a discussion at the EduJam and Sugar Code Sprint, I have > modified a patch by tch to add access to ~/Documents to the volume > toolbar in the Journal. > > Two patches: (1) a new icon; and (2) the patch to volumestoolbar.py > >

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-11 Thread Walter Bender
On Tue, May 10, 2011 at 8:54 AM, Walter Bender wrote: > As per a discussion at the EduJam and Sugar Code Sprint, I have > modified a patch by tch to add access to ~/Documents to the volume > toolbar in the Journal. > > Two patches: (1) a new icon; and (2) the patch to volumestoolbar.py > > (Gary.

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-11 Thread Walter Bender
Hmm. I created it based on an updated clone of sugar mainline. I actually have a slight change I will post as soon as I get a decent network connection, where I first check for the existence of $HOME/Documents before trying to mount. One question we need to face is whether or not we want to add ~/D

Re: [Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-10 Thread Martin Abente
My own version was based on Jorge Saldivar patch :) btw, for which sugar version is this patch? Is not applying cleanly on mainline sugar. Can someone else check this too? On Tue, May 10, 2011 at 8:54 AM, Walter Bender wrote: > As per a discussion at the EduJam and Sugar Code Sprint, I have > mo

[Sugar-devel] [PATCH] adding $HOME/Documents to the volumes toolbar

2011-05-10 Thread Walter Bender
As per a discussion at the EduJam and Sugar Code Sprint, I have modified a patch by tch to add access to ~/Documents to the volume toolbar in the Journal. Two patches: (1) a new icon; and (2) the patch to volumestoolbar.py (Gary. could you please look at the icon?) -walter -- Walter Bender Sug