Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-03 Thread Tim McNamara
On 2 July 2010 20:42, Sascha Silbe sascha-ml-ui-sugar-de...@silbe.orgwrote: TypeError should be catched in jarabe.desktop.schoolserver.register_laptop() and rethrown as a RegisterError. Sascha diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py index

Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-03 Thread Sascha Silbe
Excerpts from Tim McNamara's message of Sat Jul 03 11:49:50 + 2010: diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py index fc9ddeb..a05f56c 100644 --- a/src/jarabe/desktop/schoolserver.py +++ b/src/jarabe/desktop/schoolserver.py @@ -99,7 +99,7 @@ def

Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-03 Thread Bernie Innocenti
El Sat, 03-07-2010 a las 12:41 +, Sascha Silbe escribió: Excerpts from Tim McNamara's message of Sat Jul 03 11:49:50 + 2010: diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py index fc9ddeb..a05f56c 100644 ---

Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-03 Thread Sascha Silbe
Excerpts from Bernie Innocenti's message of Sat Jul 03 13:32:44 + 2010: -except (Error, socket.error): +except (Error, TypeError, socket.error): Tim, thank you very much for fixing this. I would like to include your fix in my Sugar 0.88 packages. Could you please repost the

Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-02 Thread Sascha Silbe
Excerpts from Tim McNamara's message of Fri Jul 02 02:09:17 + 2010: Index: src/jarabe/desktop/favoritesview.py === --- a/src/jarabe/desktop/favoritesview.py +++ b/src/jarabe/desktop/favoritesview.py @@ -323,6 +323,12 @@

[Sugar-devel] [PATCH] fixes sl#2062

2010-07-01 Thread Tim McNamara
Hi all ref http://bugs.sugarlabs.org/ticket/2062 Simple fix, have captured the exception that's raised and have told user to connect to the nework: This commit fixes sl#2062. This bug causes XS registrations to fail silently when the XO is offline. The fix is to catch the TypeError provide an

Re: [Sugar-devel] [PATCH] fixes sl#2062

2010-07-01 Thread James Cameron
On Fri, Jul 02, 2010 at 02:09:17PM +1200, Tim McNamara wrote: This commit fixes sl#2062. This bug causes XS registrations to fail silently when the XO is offline. The fix is to catch the TypeError provide an alert to the user upon failure. Trivial typo in second line of comment.