Ok. I addressed all concerns from the previous mails and the comments in
irc.
This patch take the supported mime types from the pixbuf library and open
the image at the desired size to optimize if possible the io.
Gonzalo
On Wed, Sep 15, 2010 at 7:58 AM, Simon Schampijer wrote:
> Hi Gonzalo,
>
>
On Wed, Sep 15, 2010 at 12:58, Simon Schampijer wrote:
> Hi Gonzalo,
>
> thanks for the new patch. Would be good to tell in a few words what you
> did change to the previous one, like: "I addressed all concerns." or
> "That one I did not address since..."
Also, the commit message should describe
Sorry for the vry long time I left this in patch purgatory. I haven't
had internet access for quite a while.
Sacha, thanks for picking it up.
On 15 Sep 2010 11:58, "Simon Schampijer" wrote:
Hi Gonzalo,
thanks for the new patch. Would be good to tell in a few words what you
did change to th
Hi Gonzalo,
thanks for the new patch. Would be good to tell in a few words what you
did change to the previous one, like: "I addressed all concerns." or
"That one I did not address since..."
Regards,
Simon
On 09/14/2010 08:06 PM, godi...@sugarlabs.org wrote:
> From: Gonzalo Odiard
>
> ---
On Wed, Sep 15, 2010 at 02:10, James Cameron wrote:
> Unrelated to the patch being reviewed, but of interest ...
>
> On Tue, Sep 14, 2010 at 06:14:55PM +0200, Simon Schampijer wrote:
>> Please use one underscore for private methods. Two underscores for
>> callbacks.
>
> Is a gobject idle add funct
Unrelated to the patch being reviewed, but of interest ...
On Tue, Sep 14, 2010 at 06:14:55PM +0200, Simon Schampijer wrote:
> Please use one underscore for private methods. Two underscores for
> callbacks.
Is a gobject idle add function a callback?
--
James Cameron
http://quozl.linux.org.au/
From: Gonzalo Odiard
---
downloadmanager.py | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/downloadmanager.py b/downloadmanager.py
index 3eec649..24d3911 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -36,6 +36,7 @@ from suga
Hi Gonzalo,
thanks for your patch!
> ---
> downloadmanager.py | 32
> 1 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/downloadmanager.py b/downloadmanager.py
> index 3eec649..8a90964 100644
> --- a/downloadmanager.py
> +++ b/downloadmanager
> > +if self._mime_type in
> ('image/bmp','image/gif','image/jpeg','image/png','image/tiff'):
> > +self.dl_jobject.metadata['preview'] =
> self.__get_preview_image()
> > +else:
> > +self.dl_jobject.metadata['preview'] = ''
>
> What about svg?
From: Gonzalo Odiard
---
downloadmanager.py | 32
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/downloadmanager.py b/downloadmanager.py
index 3eec649..8a90964 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -36,6 +36,7 @@ from suga
On Tue, Sep 14, 2010 at 9:50 AM, wrote:
> From: Gonzalo Odiard
>
> ---
> downloadmanager.py | 28
> 1 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/downloadmanager.py b/downloadmanager.py
> index 3eec649..f9d8ef7 100644
> --- a/downloadmanager.p
From: Gonzalo Odiard
---
downloadmanager.py | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/downloadmanager.py b/downloadmanager.py
index 3eec649..f9d8ef7 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -36,6 +36,7 @@ from sugar im
12 matches
Mail list logo
